From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, rmanohar@codeaurora.org
Subject: Re: [PATCH v2 1/3] mac80211: fix mesh moving average stuck
Date: Wed, 08 Feb 2017 09:30:34 +0100 [thread overview]
Message-ID: <1486542634.4603.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1485893272-6893-1-git-send-email-rmanohar@qca.qualcomm.com>
On Tue, 2017-01-31 at 12:07 -0800, Rajkumar Manoharan wrote:
> As moving average is not considering fractional part after
> certain ratio, it will stuck at the same state. For example
> with current values, moving average stuck at 96 and it will
> not move forward. Fortunately current threshold is matching
> against 95%. If thresold is increased more than 96, mesh path
> never be deactivated under worst case. Fix failure average
> movement by bumping up average at stuck state.
This is ... really strange to me.
Can't we just actually take into account fractional parts instead?
I think you should instead convert this to the EMWA helpers (see
include/linux/average.h).
johannes
prev parent reply other threads:[~2017-02-08 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 20:07 [PATCH v2 1/3] mac80211: fix mesh moving average stuck Rajkumar Manoharan
2017-01-31 20:07 ` [PATCH v2 2/3] mac80211: Make mesh failure moving average configurable Rajkumar Manoharan
2017-02-08 8:31 ` Johannes Berg
2017-01-31 20:07 ` [PATCH v2 3/3] mac80211: clear failure average upon mesh path deactivation Rajkumar Manoharan
2017-02-08 8:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486542634.4603.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.