From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/irq: Improve/fix migrate_irqs()
Date: Thu, 09 Feb 2017 11:40:03 +1100 [thread overview]
Message-ID: <1486600803.3401.9.camel@kernel.crashing.org> (raw)
In-Reply-To: <874m059f00.fsf@concordia.ellerman.id.au>
On Wed, 2017-02-08 at 21:02 +1100, Michael Ellerman wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > migrate_irqs() is used by some platforms to migrate interrupts
> > away from a CPU about to be offlined.
> >
> > The current implementation had various issues such as not taking
> > the descriptor lock before manipulating it.
>
> ... and not checking for a NULL chip (but presumably that's never
> happened), and always calling irq_set_affinity() even for IRQs not on
> the CPU.
>
> But, any reason we can't use irq_migrate_all_off_this_cpu() ?
> Which is in generic code.
Nope, I didn't notice it. I'll give that a spin.
Cheers,
Ben.
prev parent reply other threads:[~2017-02-09 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 0:36 [PATCH] powerpc/irq: Improve/fix migrate_irqs() Benjamin Herrenschmidt
2017-02-08 10:02 ` Michael Ellerman
2017-02-09 0:40 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486600803.3401.9.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.