From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Shanth Murthy <shanth.murthy@intel.com>
Cc: platform-driver-x86@vger.kernel.org, dvhart@infradead.org,
qipeng.zha@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API
Date: Thu, 09 Feb 2017 13:33:06 +0200 [thread overview]
Message-ID: <1486639986.2133.425.camel@linux.intel.com> (raw)
In-Reply-To: <20170209064717.GA24247@rajaneesh-OptiPlex-9010>
On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote:
> On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote:
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > +static int intel_pmc_s0ix_counter_read(u64 *data)
> > +{
> > + return -EINVAL;
> > +}
> > +
>
> How about making it static inline and return -ENOSYS instead of
> -EINVAL?
I'm not sure what's going on.
Your SoB is in this patch and now it feels like you are reviewing this
patch.
What should I do?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-02-09 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 13:09 [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API Shanth Murthy
2017-02-06 14:01 ` kbuild test robot
2017-02-06 14:01 ` kbuild test robot
2017-02-06 18:31 ` Rajneesh Bhardwaj
2017-02-07 10:19 ` Andy Shevchenko
2017-02-08 12:02 ` Rajneesh Bhardwaj
2017-02-08 12:52 ` Andy Shevchenko
2017-02-09 6:47 ` Rajneesh Bhardwaj
2017-02-09 11:33 ` Andy Shevchenko [this message]
2017-02-09 12:02 ` Rajneesh Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486639986.2133.425.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=rajneesh.bhardwaj@intel.com \
--cc=shanth.murthy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.