All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets.
Date: Thu, 09 Feb 2017 17:48:03 +0100	[thread overview]
Message-ID: <1486658883.31104.71.camel@redhat.com> (raw)
In-Reply-To: <20170209135851.GC4742@redhat.com>

> Gerd, just squash
> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 77f2a99..bffc650 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3529,7 +3529,7 @@ static int vnc_display_get_address(const char *addrstr,
>      } else {
>          const char *port;
>          size_t hostlen;
> -        unsigned long long baseport;
> +        unsigned long long baseport = 0;
>          InetSocketAddress *inet;
>  
>          port = strrchr(addrstr, ':');
> 
> 
> Into this commit:
> 
>     ui: refactor code for populating SocketAddress from vnc_display_open
> 
> Just confirmed this fixes it with a local clang build

Thanks.  Done, new pull on the way.

> 
> Regards,
> Daniel

      reply	other threads:[~2017-02-09 16:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 13:01 [Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 01/10] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear() Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 02/10] vnc: do not disconnect on EAGAIN Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 03/10] ui: fix regression handling bare 'websocket' option to -vnc Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 04/10] ui: fix reporting of VNC auth in query-vnc-servers Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 05/10] ui: refactor VncDisplay to allow multiple listening sockets Gerd Hoffmann
2017-02-16 15:28   ` Peter Maydell
2017-02-09 13:01 ` [Qemu-devel] [PULL 06/10] ui: refactor code for populating SocketAddress from vnc_display_open Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 07/10] ui: extract code to connect/listen " Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 08/10] ui: let VNC server listen on all resolved IP addresses Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 09/10] util: add iterators for QemuOpts values Gerd Hoffmann
2017-02-09 13:01 ` [Qemu-devel] [PULL 10/10] ui: add ability to specify multiple VNC listen addresses Gerd Hoffmann
2017-02-09 13:15 ` [Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets Peter Maydell
2017-02-09 13:58   ` Daniel P. Berrange
2017-02-09 16:48     ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486658883.31104.71.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.