From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0030.hostedemail.com ([216.40.44.30] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cc5ls-0000PI-27 for ath10k@lists.infradead.org; Fri, 10 Feb 2017 07:37:35 +0000 Message-ID: <1486712222.2192.3.camel@perches.com> Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() From: Joe Perches Date: Thu, 09 Feb 2017 23:37:02 -0800 In-Reply-To: References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> <87y3xi4b28.fsf@qca.qualcomm.com> <5899DDD7.7000605@candelatech.com> <87tw82il32.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Adrian Chadd , "Valo, Kalle" Cc: "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , Amadeusz =?UTF-8?Q?S=C5=82awi=C5=84ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List , Ben Greear On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and linux and what in your opinion are the best naming schemes to make these functions easiest to read and implement without resorting to excessive identifier lengths? If you have some, please provide examples. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:58047 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750979AbdBJHhM (ORCPT ); Fri, 10 Feb 2017 02:37:12 -0500 Message-ID: <1486712222.2192.3.camel@perches.com> (sfid-20170210_083753_171786_0B272397) Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() From: Joe Perches To: Adrian Chadd , "Valo, Kalle" Cc: Ben Greear , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , Amadeusz =?UTF-8?Q?S=C5=82awi=C5=84ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List Date: Thu, 09 Feb 2017 23:37:02 -0800 In-Reply-To: References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> <87y3xi4b28.fsf@qca.qualcomm.com> <5899DDD7.7000605@candelatech.com> <87tw82il32.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and linux and what in your opinion are the best naming schemes to make these functions easiest to read and implement without resorting to excessive identifier lengths? If you have some, please provide examples.