From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cyril Bur <cyrilbur@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: mikey@neuling.org, joel@jms.id.au, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver
Date: Sat, 11 Feb 2017 07:59:21 +1100 [thread overview]
Message-ID: <1486760361.3401.48.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170207234247.19425-1-cyrilbur@gmail.com>
On Wed, 2017-02-08 at 10:42 +1100, Cyril Bur wrote:
> +struct aspeed_lpc_ctrl_mapping {
> + __u8 window_type;
> + __u8 window_id;
> + __u16 flags;
> + __u32 addr;
> + __u32 offset;
> + __u32 size;
> +};
> +
Please document the fields
Cheers,
Ben.
prev parent reply other threads:[~2017-02-10 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:42 [PATCH v4] drivers/misc: Add Aspeed LPC control driver Cyril Bur
2017-02-08 0:06 ` Andy Shevchenko
2017-02-08 4:54 ` Benjamin Herrenschmidt
2017-02-10 14:30 ` Greg KH
2017-02-10 14:56 ` Patrick Williams
2017-02-10 20:55 ` Benjamin Herrenschmidt
2017-02-11 2:52 ` Joel Stanley
2017-02-10 20:59 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486760361.3401.48.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=cyrilbur@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.