All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 0/5] NVMe pci fixes, for-4.11
Date: Fri, 10 Feb 2017 18:15:48 -0500	[thread overview]
Message-ID: <1486768553-13738-1-git-send-email-keith.busch@intel.com> (raw)

These are some fixes for some more device and CPU hot plug scenarios. The
end result should fix up a long-standing deadlock caused by requests
entering a quiesced queue that block blk_mq_freeze_queue_wait forever. I'd
previously tried to fix that here:

  http://lists.infradead.org/pipermail/linux-nvme/2017-January/007620.html

But that was overly complex and overkill anyway on ending requests that
could have been successful. This time is much simpler, isolated to the
nvme driver, and more likely to not fail good IO.

This is based off linux-block/for-next because I needed to make use
of the "was_suspend" bool that was recently added with the Opal patch
set. I also merged in the nvme git tree for final testing, and noticed
there is a conflict between the following to commits:

  https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=06406d81a2d7cfb8abcc4fa6cdfeb8e5897007c5
  http://git.infradead.org/nvme.git/commitdiff/73494e87734f2c2cd4f9e91e98700cd4fd5f3e05

It's a trivial fix, but I think we gotta sort out our merging flow among
these trees.

Anyway, these are addressing real issues I'll be happy to see fixed for
4.11, but rare enough that I don't think any qualify for stable.

Keith Busch (5):
  nvme/pci: Disable on removal when disconnected
  nvme/pci: Cancel work after watchdog disabled
  nvme/core: Fix race kicking freed request_queue
  nvme/pci: No special case for queue busy on IO
  nvme/pci: Complete all stuck requests

 drivers/nvme/host/core.c | 39 ++++++++++++++++++++++++++++++++++++---
 drivers/nvme/host/nvme.h |  3 +++
 drivers/nvme/host/pci.c  | 45 ++++++++++++++++++++++++++++++++++++++-------
 3 files changed, 77 insertions(+), 10 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2017-02-10 23:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 23:15 Keith Busch [this message]
2017-02-10 23:15 ` [PATCH 1/5] nvme/pci: Disable on removal when disconnected Keith Busch
2017-02-13 10:18   ` Johannes Thumshirn
2017-02-13 13:51   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 2/5] nvme/pci: Cancel work after watchdog disabled Keith Busch
2017-02-13 10:25   ` Johannes Thumshirn
2017-02-13 13:51   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 3/5] nvme/core: Fix race kicking freed request_queue Keith Busch
2017-02-13 10:33   ` Johannes Thumshirn
2017-02-13 13:53   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 4/5] nvme/pci: No special case for queue busy on IO Keith Busch
2017-02-13 13:53   ` Christoph Hellwig
2017-02-10 23:15 ` [PATCH 5/5] nvme/pci: Complete all stuck requests Keith Busch
2017-02-15  9:50   ` Sagi Grimberg
2017-02-15 15:46     ` Keith Busch
2017-02-15 16:04       ` Marc MERLIN
2017-02-15 17:36         ` J Freyensee
2017-02-16  9:12         ` Sagi Grimberg
2017-02-16 22:51           ` Keith Busch
2017-02-17  8:25             ` Christoph Hellwig
2017-02-15 18:14   ` Marc MERLIN
2017-12-14  3:36     ` Marc MERLIN
2018-02-28  2:22       ` Marc MERLIN
2017-02-17 15:27   ` Christoph Hellwig
2017-02-17 16:33     ` Keith Busch
2017-02-20 10:05       ` Christoph Hellwig
2017-02-21 15:57         ` Keith Busch
2017-02-22  7:17           ` Christoph Hellwig
2017-02-22 14:45             ` Keith Busch
2017-02-23 15:06               ` Christoph Hellwig
2017-02-23 15:21                 ` Keith Busch
2017-02-23 15:16                   ` Christoph Hellwig
2017-02-21 21:55       ` Sagi Grimberg
2017-02-21 23:26         ` Keith Busch
2017-02-15  9:40 ` [PATCH 0/5] NVMe pci fixes, for-4.11 Sagi Grimberg
     [not found] <20170313153319.fmy6ww72fjtx74xq@merlins.org>
     [not found] ` <20170313143649.GC6994@localhost.localdomain>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486768553-13738-1-git-send-email-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.