All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yi Sun <yi.y.sun@linux.intel.com>
To: xen-devel@lists.xenproject.org
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
	andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
	he.chen@linux.intel.com, ian.jackson@eu.citrix.com,
	Yi Sun <yi.y.sun@linux.intel.com>,
	mengxu@cis.upenn.edu, jbeulich@suse.com,
	chao.p.peng@linux.intel.com
Subject: [PATCH v7 14/24] x86: refactor psr: implement get hw info flow for CDP.
Date: Mon, 13 Feb 2017 14:32:26 +0800	[thread overview]
Message-ID: <1486967556-3702-15-git-send-email-yi.y.sun@linux.intel.com> (raw)
In-Reply-To: <1486967556-3702-1-git-send-email-yi.y.sun@linux.intel.com>

This patch implements get HW info flow for CDP including L3 CDP callback
function.

It also changes sysctl function to make it work for CDP.

With this patch, 'psr-hwinfo' can work for L3 CDP.

Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
---
 xen/arch/x86/psr.c    | 18 ++++++++++++++++++
 xen/arch/x86/sysctl.c | 24 +++++++++++++++++++++---
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 2e061b5..71bfdd6 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -267,6 +267,10 @@ static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type)
     case PSR_CBM_TYPE_L3:
         feat_type = PSR_SOCKET_L3_CAT;
         break;
+    case PSR_CBM_TYPE_L3_DATA:
+    case PSR_CBM_TYPE_L3_CODE:
+        feat_type = PSR_SOCKET_L3_CDP;
+        break;
     default:
         feat_type = PSR_SOCKET_UNKNOWN;
         break;
@@ -525,8 +529,22 @@ static unsigned int l3_cdp_get_cos_max(const struct feat_node *feat)
     return feat->info.l3_cdp_info.cos_max;
 }
 
+static bool l3_cdp_get_feat_info(const struct feat_node *feat,
+                                 uint32_t data[], uint32_t array_len)
+{
+    if ( !data || 3 > array_len )
+        return false;
+
+    data[CBM_LEN] = feat->info.l3_cdp_info.cbm_len;
+    data[COS_MAX] = feat->info.l3_cdp_info.cos_max;
+    data[PSR_FLAG] |= XEN_SYSCTL_PSR_CAT_L3_CDP;
+
+    return true;
+}
+
 struct feat_ops l3_cdp_ops = {
     .get_cos_max = l3_cdp_get_cos_max,
+    .get_feat_info = l3_cdp_get_feat_info,
 };
 
 static void __init parse_psr_bool(char *s, char *value, char *feature,
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index e340baa..568bfe9 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -181,9 +181,27 @@ long arch_do_sysctl(
             ret = psr_get_info(sysctl->u.psr_cat_op.target,
                                PSR_CBM_TYPE_L3, data, 3);
 
-            sysctl->u.psr_cat_op.u.l3_info.cbm_len = data[CBM_LEN];
-            sysctl->u.psr_cat_op.u.l3_info.cos_max = data[COS_MAX];
-            sysctl->u.psr_cat_op.u.l3_info.flags   = data[PSR_FLAG];
+            if ( !ret )
+            {
+                sysctl->u.psr_cat_op.u.l3_info.cbm_len = data[CBM_LEN];
+                sysctl->u.psr_cat_op.u.l3_info.cos_max = data[COS_MAX];
+                sysctl->u.psr_cat_op.u.l3_info.flags   = data[PSR_FLAG];
+            } else {
+                /*
+                 * Check if CDP is enabled.
+                 *
+                 * Per spec, L3 CAT and CDP cannot co-exist. So, we need replace
+                 * output values to CDP's if it is enabled.
+                 */
+                ret = psr_get_info(sysctl->u.psr_cat_op.target,
+                               PSR_CBM_TYPE_L3_CODE, data, 3);
+                if ( !ret )
+                {
+                    sysctl->u.psr_cat_op.u.l3_info.cbm_len = data[CBM_LEN];
+                    sysctl->u.psr_cat_op.u.l3_info.cos_max = data[COS_MAX];
+                    sysctl->u.psr_cat_op.u.l3_info.flags   = data[PSR_FLAG];
+                }
+            }
 
             if ( !ret && __copy_field_to_guest(u_sysctl, sysctl, u.psr_cat_op) )
                 ret = -EFAULT;
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-02-13  6:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13  6:32 [PATCH v7 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c Yi Sun
2017-02-13  6:32 ` [PATCH v7 01/24] docs: create Cache Allocation Technology (CAT) and Code and Data Prioritization (CDP) feature document Yi Sun
2017-02-14 15:56   ` Konrad Rzeszutek Wilk
2017-02-13  6:32 ` [PATCH v7 02/24] x86: refactor psr: remove L3 CAT/CDP codes Yi Sun
2017-02-13  6:32 ` [PATCH v7 03/24] x86: refactor psr: implement main data structures Yi Sun
2017-02-13  6:32 ` [PATCH v7 04/24] x86: refactor psr: implement CPU init and free flow Yi Sun
2017-02-14 16:01   ` Konrad Rzeszutek Wilk
2017-02-13  6:32 ` [PATCH v7 05/24] x86: refactor psr: implement Domain init/free and schedule flows Yi Sun
2017-02-13  6:32 ` [PATCH v7 06/24] x86: refactor psr: implement get hw info flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 07/24] x86: refactor psr: implement get value flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 08/24] x86: refactor psr: set value: implement framework Yi Sun
2017-02-13  6:32 ` [PATCH v7 09/24] x86: refactor psr: set value: assemble features value array Yi Sun
2017-02-13  6:32 ` [PATCH v7 10/24] x86: refactor psr: set value: implement cos finding flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 11/24] x86: refactor psr: set value: implement cos id picking flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 12/24] x86: refactor psr: set value: implement write msr flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 13/24] x86: refactor psr: implement CPU init and free flow for CDP Yi Sun
2017-02-13  6:32 ` Yi Sun [this message]
2017-02-13  6:32 ` [PATCH v7 15/24] x86: refactor psr: implement get value " Yi Sun
2017-02-13  6:32 ` [PATCH v7 16/24] x86: refactor psr: implement set value callback functions " Yi Sun
2017-02-13  6:32 ` [PATCH v7 17/24] x86: L2 CAT: implement CPU init and free flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 18/24] x86: L2 CAT: implement get hw info flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 19/24] x86: L2 CAT: implement get value flow Yi Sun
2017-02-13  6:32 ` [PATCH v7 20/24] x86: L2 CAT: implement set " Yi Sun
2017-02-13  6:32 ` [PATCH v7 21/24] tools: L2 CAT: support get HW info for L2 CAT Yi Sun
2017-02-13  6:32 ` [PATCH v7 22/24] tools: L2 CAT: support show cbm " Yi Sun
2017-02-13  6:32 ` [PATCH v7 23/24] tools: L2 CAT: support set " Yi Sun
2017-02-13  6:32 ` [PATCH v7 24/24] docs: add L2 CAT description in docs Yi Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486967556-3702-15-git-send-email-yi.y.sun@linux.intel.com \
    --to=yi.y.sun@linux.intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=dario.faggioli@citrix.com \
    --cc=he.chen@linux.intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=mengxu@cis.upenn.edu \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.