From: "De Marchi, Lucas" <lucas.demarchi@intel.com>
To: "jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Cc: "wsa@the-dreams.de" <wsa@the-dreams.de>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Nehal-bakulchandra.Shah@amd.com"
<Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH] Revert "i2c: designware: detect when dynamic tar update is possible"
Date: Mon, 13 Feb 2017 17:22:42 +0000 [thread overview]
Message-ID: <1487006561.2767.6.camel@intel.com> (raw)
In-Reply-To: <20170213091819.4370-1-jarkko.nikula@linux.intel.com>
On Mon, 2017-02-13 at 11:18 +0200, Jarkko Nikula wrote:
> This reverts commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3.
>
> It caused a regression on platforms where I2C controller is synthesized
> with dynamic TAR update disabled. Detection code is testing is bit
> DW_IC_CON_10BITADDR_MASTER in register DW_IC_CON read-only but fails to
> restore original value in case bit is read-write.
>
> Instead of fixing this we revert the commit since it was preparation for
> the commit 0317e6c0f1dc ("i2c: designware: do not disable adapter after
> transfer") which was also reverted.
>
> Reported-by: Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@amd.com>
> Reported-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: <stable@vger.kernel.org> # v4.9+
> Fixes: 63d0f0a6952a ("i2c: designware: detect when dynamic tar update is possible")
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-By: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
next prev parent reply other threads:[~2017-02-13 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 9:18 [PATCH] Revert "i2c: designware: detect when dynamic tar update is possible" Jarkko Nikula
2017-02-13 17:22 ` De Marchi, Lucas [this message]
2017-02-14 21:10 ` Wolfram Sang
2017-02-14 21:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487006561.2767.6.camel@intel.com \
--to=lucas.demarchi@intel.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.