diff for duplicates of <1487020366.2719.5.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index ecc70c5..e847102 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,40 +1,25 @@ On Mon, 2017-02-13 at 22:01 +0100, Paolo Valente wrote: -> -static struct elevator_type *elevator_get(const char *name, bool try_loa= -ding) -> +static struct elevator_type *elevator_get(const char *name, bool try_loa= -ding, +> -static struct elevator_type *elevator_get(const char *name, bool try_loading) +> +static struct elevator_type *elevator_get(const char *name, bool try_loading, > + bool mq_ops) -Please choose a better name for that argument, e.q. "mq". To me the name "m= -q_ops" +Please choose a better name for that argument, e.q. "mq". To me the name "mq_ops" means "a pointer to a data structure with operation function pointers". -> + if (e && (e->uses_mq !=3D mq_ops)) { +> + if (e && (e->uses_mq != mq_ops)) { > + pr_err("ERROR: attempted to choose %s %s I/O scheduler in blk%s", > + name, e->uses_mq ? "blk-mq" : "legacy", mq_ops ? "-mq" : ""); -> + e =3D NULL; +> + e = NULL; > + } How about changing the above into: -+=A0=A0=A0=A0=A0=A0=A0if (e && e->uses_mq !=3D mq) { -+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pr_err("ERROR: attempt to con= -figure %s as I/O scheduler for a %s queue\n", -+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0name, mq= - ? "blk-mq" : "legacy"); -+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0e =3D NULL; -+=A0=A0=A0=A0=A0=A0=A0} ++ if (e && e->uses_mq != mq) { ++ pr_err("ERROR: attempt to configure %s as I/O scheduler for a %s queue\n", ++ name, mq ? "blk-mq" : "legacy"); ++ e = NULL; ++ } Thanks, Bart. -Western Digital Corporation (and its subsidiaries) E-mail Confidentiality N= -otice & Disclaimer: - -This e-mail and any files transmitted with it may contain confidential or l= -egally privileged information of WDC and/or its affiliates, and are intende= -d solely for the use of the individual or entity to which they are addresse= -d. If you are not the intended recipient, any disclosure, copying, distribu= -tion or any action taken or omitted to be taken in reliance on it, is prohi= -bited. If you have received this e-mail in error, please notify the sender = -immediately and delete the e-mail in its entirety from your system. diff --git a/a/content_digest b/N1/content_digest index e507370..06a4480 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,44 +14,29 @@ "\00:1\0" "b\0" "On Mon, 2017-02-13 at 22:01 +0100, Paolo Valente wrote:\n" - "> -static struct elevator_type *elevator_get(const char *name, bool try_loa=\n" - "ding)\n" - "> +static struct elevator_type *elevator_get(const char *name, bool try_loa=\n" - "ding,\n" + "> -static struct elevator_type *elevator_get(const char *name, bool try_loading)\n" + "> +static struct elevator_type *elevator_get(const char *name, bool try_loading,\n" "> +\t\t\t\t\t bool mq_ops)\n" "\n" - "Please choose a better name for that argument, e.q. \"mq\". To me the name \"m=\n" - "q_ops\"\n" + "Please choose a better name for that argument, e.q. \"mq\". To me the name \"mq_ops\"\n" "means \"a pointer to a data structure with operation function pointers\".\n" "\n" - "> +\tif (e && (e->uses_mq !=3D mq_ops)) {\n" + "> +\tif (e && (e->uses_mq != mq_ops)) {\n" "> +\t\tpr_err(\"ERROR: attempted to choose %s %s I/O scheduler in blk%s\",\n" "> +\t\t name, e->uses_mq ? \"blk-mq\" : \"legacy\", mq_ops ? \"-mq\" : \"\");\n" - "> +\t\te =3D NULL;\n" + "> +\t\te = NULL;\n" "> +\t}\n" "\n" "How about changing the above into:\n" "\n" - "+=A0=A0=A0=A0=A0=A0=A0if (e && e->uses_mq !=3D mq) {\n" - "+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pr_err(\"ERROR: attempt to con=\n" - "figure %s as I/O scheduler for a %s queue\\n\",\n" - "+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0name, mq=\n" - " ? \"blk-mq\" : \"legacy\");\n" - "+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0e =3D NULL;\n" - "+=A0=A0=A0=A0=A0=A0=A0}\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (e && e->uses_mq != mq) {\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pr_err(\"ERROR: attempt to configure %s as I/O scheduler for a %s queue\\n\",\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240name, mq ? \"blk-mq\" : \"legacy\");\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240e = NULL;\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "\n" "Thanks,\n" "\n" - "Bart.\n" - "Western Digital Corporation (and its subsidiaries) E-mail Confidentiality N=\n" - "otice & Disclaimer:\n" - "\n" - "This e-mail and any files transmitted with it may contain confidential or l=\n" - "egally privileged information of WDC and/or its affiliates, and are intende=\n" - "d solely for the use of the individual or entity to which they are addresse=\n" - "d. If you are not the intended recipient, any disclosure, copying, distribu=\n" - "tion or any action taken or omitted to be taken in reliance on it, is prohi=\n" - "bited. If you have received this e-mail in error, please notify the sender =\n" - immediately and delete the e-mail in its entirety from your system. + Bart. -962631f21194443151134700ff823ab2a40b7a46ebff396d2c8444540021fb69 +06e714957df5796a71f6a8f91134e685859dc12e094aab97bd89cf7734897502
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.