Re: [RFC/CI] drm/i915: Sanitize GuC client initialization

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [RFC/CI] drm/i915: Sanitize GuC client initialization
Date: Tue, 14 Feb 2017 15:54:59 +0200	[thread overview]
Message-ID: <1487080499.3057.48.camel@linux.intel.com> (raw)
In-Reply-To: <20170210143639.GE7903@nuc-i3427.alporthouse.com>

On pe, 2017-02-10 at 14:36 +0000, Chris Wilson wrote:
> On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> > 
> > +static unsigned long __reserve_cacheline(struct intel_guc* guc)
> >  {
> > -	const uint32_t cacheline_size = cache_line_size();
> > -	uint32_t offset;
> > +	unsigned long offset;
> >  
> >  	/* Doorbell uses a single cache line within a page */
> >  	offset = offset_in_page(guc->db_cacheline);
> 
> But unsigned long? I was trying to work out why we might need unsigned
> long doorbell_offset, for when the doorbell object is of known size.
> 
> That's the only thing that stuck out like a sore thumb.

Fixing that type took me for a too long journey, so I aborted mission.
Added a follow-up task.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx