All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: In the submission cleanup, do not bail out if there is no execbuf_client
Date: Tue, 14 Feb 2017 16:20:04 +0200	[thread overview]
Message-ID: <1487082004.3057.54.camel@linux.intel.com> (raw)
In-Reply-To: <fa3a03f3-1f46-a480-66dc-708c695a5d87@intel.com>

On ma, 2017-02-13 at 07:55 -0800, Oscar Mateo wrote:
> 
> On 02/10/2017 04:04 AM, Chris Wilson wrote:
> > 
> > On Thu, Feb 09, 2017 at 02:24:25AM -0800, Oscar Mateo wrote:
> > > 
> > > There is other stuff that potentially needs cleaning, even if we didn't get to the point of
> > > creating an execbuf_client.
> > Just because the allocator doesn't employ onion unwinding?
> > Or is there more to come?
> No, nothing more to come. I just saw this was wrong in passing and 
> decided to send a patch. But I see Joonas is spearheading a bigger 
> cleanup, so maybe this can be fixed there.

I was actually inspired by this change (I had it in my TODO list) which
I completed while going through the code. Would be great if you can do
a similar fixup of the code to include proper onion teardown to
submission_init and make submission_fini without condition checks.

In the guc_client case it brought up quite good fixes and
irregularities in phasing the init and teardown.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-14 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 10:24 [PATCH] drm/i915/guc: In the submission cleanup, do not bail out if there is no execbuf_client Oscar Mateo
2017-02-09 19:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-10 12:04 ` [PATCH] " Chris Wilson
2017-02-13 15:55   ` Oscar Mateo
2017-02-14 14:20     ` Joonas Lahtinen [this message]
2017-02-16 14:18       ` [PATCH] drm/i915/guc: Add onion teardown to the GuC setup Oscar Mateo
2017-02-16 14:21         ` Oscar Mateo
2017-02-17 23:06         ` Daniele Ceraolo Spurio
2017-02-20 10:39           ` Joonas Lahtinen
2017-02-20 10:52         ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487082004.3057.54.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=oscar.mateo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.