From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbdBNUoJ (ORCPT ); Tue, 14 Feb 2017 15:44:09 -0500 Received: from smtprelay0176.hostedemail.com ([216.40.44.176]:48536 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751642AbdBNUoC (ORCPT ); Tue, 14 Feb 2017 15:44:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:4321:5007:6119:8957:10004:10400:10848:11026:11658:11914:12043:12296:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21060:21080:21451:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:8,LUA_SUMMARY:none X-HE-Tag: sun57_5c9fe8b5ba1f X-Filterd-Recvd-Size: 1421 Message-ID: <1487105038.6214.30.camel@perches.com> Subject: Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name From: Joe Perches To: Arushi Singhal , arnaud.patard@rtp-net.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 14 Feb 2017 12:43:58 -0800 In-Reply-To: <20170214203300.GA10308@arushi-HP-Pavilion-Notebook> References: <20170214203300.GA10308@arushi-HP-Pavilion-Notebook> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' should also have > an identifier name. [] > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h [] > @@ -1,6 +1,6 @@ > #ifndef _VBINIT_ > #define _VBINIT_ > unsigned char XGIInitNew(struct pci_dev *pdev); > -void XGIRegInit(struct vb_device_info *, unsigned long); > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long); Why do one argument but not the other?