From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848AbdBODbZ (ORCPT ); Tue, 14 Feb 2017 22:31:25 -0500 Received: from smtprelay0050.hostedemail.com ([216.40.44.50]:50435 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751781AbdBODbX (ORCPT ); Tue, 14 Feb 2017 22:31:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:421:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3874:4321:5007:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13311:13357:13439:14659:21080:21324:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: steam04_4619909b96f25 X-Filterd-Recvd-Size: 1542 Message-ID: <1487129480.6214.39.camel@perches.com> Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues From: Joe Perches To: SIMRAN SINGHAL Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 14 Feb 2017 19:31:20 -0800 In-Reply-To: References: <20170214201432.GA4150@singhal-Inspiron-5558> <1487103799.6214.27.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: > Yes, I totally agree with joe. > > But as there is no coding style issue in this patch. Style is more than just checkpatch conformity. > So, do I have to resend the complete patch series again? I'm not applying any of these so that's entirely up to Greg. Perhaps he might apply the first 5 patches and reject this one, maybe he might apply all the patches. In any case, do strive to develop some reasonable semblance of style and do more than just checkpatch suggested patches and find and fix some actual defect somewhere.