All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
	linux-wireless@vger.kernel.org
Cc: j@w1.fi, greearb@candelatech.com
Subject: Re: [RFC v2 3/7] ieee80211: add new VHT capability fields/parsing
Date: Wed, 15 Feb 2017 10:16:56 +0100	[thread overview]
Message-ID: <1487150216.4026.18.camel@sipsolutions.net> (raw)
In-Reply-To: <281180d5-2a7e-00b5-f12b-13bf568812da@broadcom.com> (sfid-20170215_100812_870620_DD85F105)

On Wed, 2017-02-15 at 10:08 +0100, Arend Van Spriel wrote:
> [snip]
> 
> Looks good to me.

Thanks for checking :)

> > +	/* not covered or invalid combination received */
> 
> Do you want to inform about the invalid/reserved combination.

I'm not really sure what to do - we don't really want to print a
message on something that might have been received from the peer, I
think? Though I suppose we should return 0 for the invalid
combinations, indicating that they're not supported.

johannes

  reply	other threads:[~2017-02-15  9:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 13:22 VHT extended NSS BW support framework Johannes Berg
2017-02-14 13:22 ` [RFC v2 1/7] ieee80211: rename CCFS1/CCFS2 to CCFS0/CCFS1 Johannes Berg
2017-02-14 13:22 ` [RFC v2 2/7] ieee80211: define HT operation CCFS2 field Johannes Berg
2017-02-14 13:22 ` [RFC v2 3/7] ieee80211: add new VHT capability fields/parsing Johannes Berg
2017-02-15  9:08   ` Arend Van Spriel
2017-02-15  9:16     ` Johannes Berg [this message]
2017-02-15  9:36       ` Arend Van Spriel
2017-02-15  9:48         ` Johannes Berg
2017-02-15 10:34           ` Arend Van Spriel
2017-02-15 10:34             ` Arend Van Spriel
2017-02-15 10:41               ` Johannes Berg
2017-02-15 10:54                 ` Arend Van Spriel
2017-02-14 13:22 ` [RFC v2 4/7] mac80211: remove local pointer from rate_ctrl_ref Johannes Berg
2017-02-14 13:22 ` [RFC v2 5/7] mac80211: introduce capability flags for VHT EXT NSS support Johannes Berg
2017-02-14 13:22 ` [RFC v2 6/7] mac80211: add ability to parse CCFS2 Johannes Berg
2017-02-14 13:22 ` [RFC v2 7/7] mac80211: copy VHT EXT NSS BW Support/Capable data to station Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487150216.4026.18.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=greearb@candelatech.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.