From: Bastien Nocera <hadess@hadess.net>
To: Ping Cheng <pinglinux@gmail.com>, linux-input@vger.kernel.org
Cc: jikos@kernel.org, benjamin.tissoires@gmail.com,
dmitry.torokhov@gmail.com, Ping Cheng <pingc@wacom.com>,
Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH 3/3] HID: wacom: generic: support touch on/off softkey
Date: Wed, 15 Feb 2017 11:27:59 +0100 [thread overview]
Message-ID: <1487154479.3089.2.camel@hadess.net> (raw)
In-Reply-To: <1487136465-5255-1-git-send-email-pingc@wacom.com>
On Tue, 2017-02-14 at 21:27 -0800, Ping Cheng wrote:
> Wacom Cintiq Pro has a softkey to turn touch on/off. Since it is
> a softkey, hardware/firmware still reports touch events no matter
> what state the softkey is. We need to ignore touch events when
> the key is in off mode.
Why can't this simply be reported to user-space to handle? This would
allow an OSD popping up. Implementing everything in the driver means
that we're setting ourselves up for "fat finger" bug reports where the
user doesn't know that they disabled the tablet, as there would be no
notification of the change.
next prev parent reply other threads:[~2017-02-15 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 5:27 [PATCH 3/3] HID: wacom: generic: support touch on/off softkey Ping Cheng
2017-02-15 10:27 ` Bastien Nocera [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-15 20:13 Ping Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487154479.3089.2.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=pingc@wacom.com \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.