Re: [PATCH v1 2/6] iommu/dmar: Rectify return code handling in detect_intel_iommu()

From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Mika Westerberg
	<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Rafael J . Wysocki"
	<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v1 2/6] iommu/dmar: Rectify return code handling in detect_intel_iommu()
Date: Wed, 15 Feb 2017 16:58:52 +0200	[thread overview]
Message-ID: <1487170732.2133.487.camel@linux.intel.com> (raw)
In-Reply-To: <20170215144226.34519-2-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On Wed, 2017-02-15 at 16:42 +0200, Andy Shevchenko wrote:
> There is inconsistency in return codes across the functions called
> from
> detect_intel_iommu().
> 
> Make it consistent and propagate return code to the caller.

> @@ -911,10 +911,9 @@ int __init detect_intel_iommu(void)
>  	}
>  	up_write(&dmar_global_lock);
>  
> -	return ret ? 1 : -ENODEV;
> +	return ret;

Accidentally it works since we have no late_init() defined.

I will fix this in v2, but will wait for the comments regarding the rest
of the series.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu