From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl Date: Thu, 16 Feb 2017 15:42:20 +0200 Message-ID: <1487252540.3071.1.camel@linux.intel.com> References: <20170216125441.30923-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170216125441.30923-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 10-rc1+" , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTctMDItMTYgYXQgMTI6NTQgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBX ZSB3YWl0IHVwb24gamlmZmllcywgYnV0IHJlcG9ydCB0aGUgdGltZSBlbGFwc2VkIHVzaW5nIGEK PiBoaWdoLXJlc29sdXRpb24gdGltZXIuIFRoaXMgZGlzY3JlcGFuY3kgY2FuIGxlYWQgdG8gdXMg dGltaW5nIG91dCB0aGUKPiB3YWl0IHByaW9yIHRvIHVzIHJlcG9ydGluZyB0aGUgZWxhcHNlZCB0 aW1lIGFzIGNvbXBsZXRlLgo+IAo+IFRoaXMgcmVzdG9yZXMgdGhlIHNxdWVsY2hpbmcgbG9zdCBp biBjb21taXQgZTk1NDMzYzczYTExICgiZHJtL2k5MTU6Cj4gUmVhcnJhbmdlIGk5MTVfd2FpdF9y ZXF1ZXN0KCkgYWNjb3VudGluZyB3aXRoIGNhbGxlcnMiKS4KPiAKPiBGaXhlczogZTk1NDMzYzcz YTExICgiZHJtL2k5MTU6IFJlYXJyYW5nZSBpOTE1X3dhaXRfcmVxdWVzdCgpIGFjY291bnRpbmcg d2l0aCBjYWxsZXJzIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBDYzogTWF0dGhldyBBdWxkIDxtYXR0aGV3LndpbGxpYW0uYXVsZEBn bWFpbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogPGRybS1pbnRlbC1maXhlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmc+ICMg djQuMTAtcmMxKwo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCgpSZXZpZXdlZC1ieTogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgoKUmVnYXJkcywg Sm9vbmFzCi0tIApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK SW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:57766 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbdBPNm3 (ORCPT ); Thu, 16 Feb 2017 08:42:29 -0500 Message-ID: <1487252540.3071.1.camel@linux.intel.com> Subject: Re: [PATCH] drm/i915: Squelch any ktime/jiffie rounding errors for wait-ioctl From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Matthew Auld , "# v4 . 10-rc1+" , stable@vger.kernel.org Date: Thu, 16 Feb 2017 15:42:20 +0200 In-Reply-To: <20170216125441.30923-1-chris@chris-wilson.co.uk> References: <20170216125441.30923-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On to, 2017-02-16 at 12:54 +0000, Chris Wilson wrote: > We wait upon jiffies, but report the time elapsed using a > high-resolution timer. This discrepancy can lead to us timing out the > wait prior to us reporting the elapsed time as complete. > > This restores the squelching lost in commit e95433c73a11 ("drm/i915: > Rearrange i915_wait_request() accounting with callers"). > > Fixes: e95433c73a11 ("drm/i915: Rearrange i915_wait_request() accounting with callers") > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Joonas Lahtinen > Cc: # v4.10-rc1+ > Cc: stable@vger.kernel.org Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation