From: Josef Bacik <jbacik@fb.com>
To: <linux-block@vger.kernel.org>, <kernel-team@fb.com>,
<nbd-general@lists.sourceforge.net>, <axboe@kernel.dk>
Subject: Re: [PATCH V2] nbd: ref count the socks array
Date: Thu, 16 Feb 2017 10:06:45 -0500 [thread overview]
Message-ID: <1487257605.16181.0.camel@fb.com> (raw)
In-Reply-To: <1486566305-10039-1-git-send-email-jbacik@fb.com>
On Wed, 2017-02-08 at 10:05 -0500, Josef Bacik wrote:
> In preparation for allowing seamless reconnects we need a way to make
> sure that we don't free the socks array out from underneath
> ourselves.
> So a socks_ref counter in order to keep track of who is using the
> socks
> array, and only free it and change num_connections once our reference
> reduces to zero.
>
> We also need to make sure that somebody calling SET_SOCK isn't coming
> in
> before we're done with our socks array, so add a waitqueue to wait on
> previous users of the socks array before initiating a new socks
> array.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Actually turns out I need to do this slightly differently to deal with
the netlink device addition interface, so I'm just going to drop this
altogether and do it the other way rather than reworking it in another
patch. Thanks,
Josef
prev parent reply other threads:[~2017-02-16 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 22:10 [PATCH] nbd: ref count the socks array Josef Bacik
2017-02-08 15:05 ` [PATCH V2] " Josef Bacik
2017-02-16 15:06 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487257605.16181.0.camel@fb.com \
--to=jbacik@fb.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.