From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
qemu-devel@nongnu.org, zyy@google.comdovgaluk@ispras.ru,
marcandre.lureau@gmail.com
Subject: Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic
Date: Thu, 16 Feb 2017 16:12:30 +0100 [thread overview]
Message-ID: <1487257950.32455.0.camel@redhat.com> (raw)
In-Reply-To: <a268900c-a44f-fbc1-9f6e-92a127c5dcbf@redhat.com>
On Di, 2017-02-14 at 12:59 +0100, Paolo Bonzini wrote:
>
> On 14/02/2017 08:15, Pavel Dovgalyuk wrote:
> > This patch changes resetting strategy of the audio polling timer.
> > It does not change expiration time if the timer is already set.
> > This patch is needed to make this timer deterministic and to use execution
> > record/replay for audio devices.
> >
> > audio_reset_timer is used in the function audio_vm_change_state_handler.
> > Therefore every time VM is stopped or restarted the timer will be reset
> > to new timeout. Virtual clock does not proceed while VM is stopped.
> > Therefore there is no need in resetting the timeout when VM restarts.
> >
> > v2: updated commit message
> > v3: now using timer_mod_anticipate function (as suggested by Yurii Zubrytskyi)
>
> Gerd, feel free to pick either v2 or v3.
Picked up v3 now.
thanks,
Gerd
next prev parent reply other threads:[~2017-02-16 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 7:15 [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic Pavel Dovgalyuk
2017-02-14 11:59 ` Paolo Bonzini
2017-02-16 15:12 ` Gerd Hoffmann [this message]
2017-02-16 15:16 ` Pavel Dovgalyuk
2017-02-16 15:17 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487257950.32455.0.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zyy@google.comdovgaluk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.