From: Patrick Ohly <patrick.ohly@intel.com>
To: "André Draszik" <git@andred.net>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-swupd][PATCH 3/3] bundles.py: fix copying of full image to full bundle when no SWUPD_BUNDLES
Date: Thu, 16 Feb 2017 16:50:31 +0100 [thread overview]
Message-ID: <1487260231.13854.471.camel@intel.com> (raw)
In-Reply-To: <1487259700.13854.467.camel@intel.com>
On Thu, 2017-02-16 at 16:41 +0100, Patrick Ohly wrote:
> On Thu, 2017-02-16 at 14:58 +0000, André Draszik wrote:
> > When SWUPD_BUNDLES is not set, exceptions are thrown, stopping the
> > build - there are two issues in here:
> > - the debug statement references a non-existent variable, 'bundle' was
> > renamed to fulltar
> > - copyxattrfiles() needs a list of files as 2nd argument, not a filename
> > of a file which contains this list
> >
> > This got broken in commit 6c097131ad39
> > ("meta-swupd: support rm_work.bbclass") while support for rm_work
> > was being added.
>
> I should have fixed that already in commit
> 531a8e636 "bundles.py: fix "no bundles" special case". Can you rebase
> onto current master and retest.
Never mind, my bad. The commit you mentioned is after my fix, so in
other words, I fixed it, changed something, and broke it again. Clearly
this whole layer needs automated test cases :-/
Something to do for a maintainer with a bit more time available. There
is https://bugzilla.yoctoproject.org/show_bug.cgi?id=9783 for it, but I
don't think I'll be able to work on that anytime soon.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
prev parent reply other threads:[~2017-02-16 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 14:58 [meta-swupd][PATCH 0/3] fixes for when SWUPD_BUNDLES is undefined André Draszik
2017-02-16 14:58 ` [meta-swupd][PATCH 1/3] swupd-image.bbclass: don't fail parsing if " André Draszik
2017-02-16 14:58 ` [meta-swupd][PATCH 2/3] path.py: always clean up temporary file in copyxattrfiles() André Draszik
2017-02-16 14:58 ` [meta-swupd][PATCH 3/3] bundles.py: fix copying of full image to full bundle when no SWUPD_BUNDLES André Draszik
2017-02-16 15:41 ` Patrick Ohly
2017-02-16 15:50 ` Patrick Ohly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487260231.13854.471.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=git@andred.net \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.