From: Martin Wilck <mwilck@suse.com>
To: tang.junhui@zte.com.cn
Cc: tang.wenjun3@zte.com.cn, zhang.kai16@zte.com.cn,
dm-devel@redhat.com, bart.vanassche@sandisk.com
Subject: Re: 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices
Date: Fri, 17 Feb 2017 12:40:14 +0100 [thread overview]
Message-ID: <1487331614.4629.19.camel@suse.com> (raw)
In-Reply-To: <201702171124101816133@zte.com.cn>
On Fri, 2017-02-17 at 11:24 +0800, tang.junhui@zte.com.cn wrote:
> Hello Martin,
>
> Thanks for your responsible,
>
> ＞ I'd like the following better for this check. It uses much less cyc
> les.
>
> ＞ static bool
> ＞ can_discard_by_devpath(const char *devpath)
>
> ＞ This would be better readable and faster if you'd put the "kernel"
> ＞ tests first so that you need to check only "action" later:
>
> ＞ if (!strncmp(later-＞kernel, "dm-", 3) ||
> ＞ strcmp(earlier-＞kernel, later-＞kernel))
> ＞ return false;
>
> Yes, I think these codes can be reworked, but since they have no
> logical
> effect, and this patch takes too long time, can you commit a new
> patch
> to rework these codes?
Yes, I could do that.
Regards
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2017-02-17 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 3:24 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices tang.junhui
2017-02-17 6:32 ` Benjamin Marzinski
2017-02-17 11:40 ` Martin Wilck [this message]
2017-02-20 11:08 ` Martin Wilck
-- strict thread matches above, loose matches on Subject: below --
2017-02-21 5:34 tang.junhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487331614.4629.19.camel@suse.com \
--to=mwilck@suse.com \
--cc=bart.vanassche@sandisk.com \
--cc=dm-devel@redhat.com \
--cc=tang.junhui@zte.com.cn \
--cc=tang.wenjun3@zte.com.cn \
--cc=zhang.kai16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.