From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Egbert Eich <eich@suse.com>
Subject: Re: [PATCH 2/2] drm/ast: Support AST2500
Date: Sun, 19 Feb 2017 09:22:00 +1100 [thread overview]
Message-ID: <1487456520.23576.156.camel@kernel.crashing.org> (raw)
In-Reply-To: <CACvgo51Sb1vwNDxVUSNMz9_L3iZNyCRtRtTNxgoeXAs69Fvtew@mail.gmail.com>
On Sat, 2017-02-18 at 15:43 +0000, Emil Velikov wrote:
>
> Out of curiosity - can you try testing with and w/o the ddr_test_2500
> bug fix(?).
> Would be interesting to see if any of the omitted code [in
> ast_dram_init_2500] has noticeable effect.
Afaik, the original ddr_test_2500 from aspeed wasn't buggy, was it ?
I thought I introduced the bug you found when I turned the values
into bools.
Anyway, I can't test the POST code so... I'll have to wait for Y.C.Chen
to do that.
> > I've changed my refactoring of mmc_test_* to be closer to the
> > original
> > code as I had missed a difference in loop exit condition.
> >
>
> The series looks a lot, better. Thank you for addressing my
> suggestions !
>
> Regards
> Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-18 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 9:09 [PATCH 2/2] drm/ast: Support AST2500 Benjamin Herrenschmidt
2017-02-16 11:40 ` Benjamin Herrenschmidt
2017-02-16 17:33 ` Emil Velikov
2017-02-16 21:09 ` Benjamin Herrenschmidt
2017-02-17 21:27 ` Emil Velikov
2017-02-17 21:36 ` Benjamin Herrenschmidt
2017-02-18 14:55 ` Emil Velikov
2017-02-18 3:41 ` Benjamin Herrenschmidt
2017-02-18 15:43 ` Emil Velikov
2017-02-18 22:22 ` Benjamin Herrenschmidt [this message]
2017-02-20 15:21 ` Emil Velikov
2017-02-16 21:12 ` Benjamin Herrenschmidt
2017-02-16 21:14 ` Benjamin Herrenschmidt
2017-02-16 21:16 ` Benjamin Herrenschmidt
2017-02-16 21:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487456520.23576.156.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eich@suse.com \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.