From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Date: Sun, 19 Feb 2017 13:59:39 +0000 Subject: Re: [PATCH] RDMA/qedr: Fix some error handling Message-Id: <1487512779.86943.118.camel@redhat.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-UGgB60q0HiriAfa1gEH3" List-Id: References: <20170218112815.9329-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170218112815.9329-1-christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org> To: Christophe JAILLET , sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ram.Amrani-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, Michal.Kalderon-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, rajesh.borundia-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, weiyongjun1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --=-UGgB60q0HiriAfa1gEH3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote: > 'qedr_alloc_pbl_tbl()' can not return NULL. >=20 > In qedr_init_user_queue(): > =C2=A0- simplify the test for the return value, no need to test for NULL > =C2=A0- propagate the error pointer if needed, otherwise 0 (success) is > returned. > =C2=A0=C2=A0 This is spurious. >=20 > In init_mr_info(): > =C2=A0- test the return value with IS_ERR > =C2=A0- propagate the error pointer if needed instead of an exlictit > -ENOMEM. > =C2=A0=C2=A0 This is a no-op as the only error pointer that we can have h= ere is > =C2=A0=C2=A0 already -ENOMEM >=20 > Signed-off-by: Christophe JAILLET Thanks, applied. --=20 Doug Ledford =C2=A0 =C2=A0 GPG KeyID: B826A3330E572FDD =C2=A0 =C2=A0 Key fingerprint =3D AE6B 1BDA 122B 23B4 265B =C2=A01274 B826 A333 0E57 2FDD --=-UGgB60q0HiriAfa1gEH3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYqaTLAAoJELgmozMOVy/diFEP/10sPSLolkFQ6Q2W5EdSufFD tRxIx7e3h3/F0kCA1Nxk+Q/nC1p8OQ9cukK1yAtQvWOTy0rylor+jmF22rYqrB/Z IfEX9pOCYNrPmy1TkuEonT9n3ILaHHXp0kqY2OgAjBV/pSMUl+7FRCM/gObuyXQP Jr6PlgS2HAqlo5mDSLomrR7a/Nn0JmWa5ETFF9I6UZGKFil+9JS44UV68V1DnrcM IXd3G5CySlMQP5Mqxq1nEEhvUD2tgDKSg4hgMSuq7ozI0RSNxgfpiM0IYut6nqdq 1CI8nEtswUsTkOIHCtTaKKjjhepUzye/FqwZKcgNqh5mE3CfGc7t2bnQGVT3viaF f4Y1XicezHDJJ+NM25n0/Bnl5kNtBRWa+pTczQGkW+anFQGAj70XIxNLq9JYoqkT m73uWIHm5/S72RfeQgOyiRRuxddnphB0J3qWhp43r1GxPPJIc/syBXSNdx2QCs03 Xdl1JmTNI96VUjJeyZekNGzNZxB88j7wSy4h2uSJPOPyxsayMPO++8JZwXdwB8Bv jUSHeMzB0qkgDNVazQl4oAUZiTDE1SSM84NyHjWYyj9BeJRkJSS7SO8TKyBZPy34 dnH49UYiqxhIVqWK/lny9qkZ/rm27a8ndWmkISD5JVIvImc5tibRXIqQtvp2CYf4 XerV7qyQkJQXKba/zfff =+CHP -----END PGP SIGNATURE----- --=-UGgB60q0HiriAfa1gEH3-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] RDMA/qedr: Fix some error handling Date: Sun, 19 Feb 2017 08:59:39 -0500 Message-ID: <1487512779.86943.118.camel@redhat.com> References: <20170218112815.9329-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-UGgB60q0HiriAfa1gEH3" Return-path: In-Reply-To: <20170218112815.9329-1-christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christophe JAILLET , sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ram.Amrani-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, Michal.Kalderon-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, rajesh.borundia-74tsMCuadCbQT0dZR+AlfA@public.gmane.org, weiyongjun1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org --=-UGgB60q0HiriAfa1gEH3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote: > 'qedr_alloc_pbl_tbl()' can not return NULL. >=20 > In qedr_init_user_queue(): > =C2=A0- simplify the test for the return value, no need to test for NULL > =C2=A0- propagate the error pointer if needed, otherwise 0 (success) is > returned. > =C2=A0=C2=A0 This is spurious. >=20 > In init_mr_info(): > =C2=A0- test the return value with IS_ERR > =C2=A0- propagate the error pointer if needed instead of an exlictit > -ENOMEM. > =C2=A0=C2=A0 This is a no-op as the only error pointer that we can have h= ere is > =C2=A0=C2=A0 already -ENOMEM >=20 > Signed-off-by: Christophe JAILLET Thanks, applied. --=20 Doug Ledford =C2=A0 =C2=A0 GPG KeyID: B826A3330E572FDD =C2=A0 =C2=A0 Key fingerprint =3D AE6B 1BDA 122B 23B4 265B =C2=A01274 B826 A333 0E57 2FDD --=-UGgB60q0HiriAfa1gEH3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYqaTLAAoJELgmozMOVy/diFEP/10sPSLolkFQ6Q2W5EdSufFD tRxIx7e3h3/F0kCA1Nxk+Q/nC1p8OQ9cukK1yAtQvWOTy0rylor+jmF22rYqrB/Z IfEX9pOCYNrPmy1TkuEonT9n3ILaHHXp0kqY2OgAjBV/pSMUl+7FRCM/gObuyXQP Jr6PlgS2HAqlo5mDSLomrR7a/Nn0JmWa5ETFF9I6UZGKFil+9JS44UV68V1DnrcM IXd3G5CySlMQP5Mqxq1nEEhvUD2tgDKSg4hgMSuq7ozI0RSNxgfpiM0IYut6nqdq 1CI8nEtswUsTkOIHCtTaKKjjhepUzye/FqwZKcgNqh5mE3CfGc7t2bnQGVT3viaF f4Y1XicezHDJJ+NM25n0/Bnl5kNtBRWa+pTczQGkW+anFQGAj70XIxNLq9JYoqkT m73uWIHm5/S72RfeQgOyiRRuxddnphB0J3qWhp43r1GxPPJIc/syBXSNdx2QCs03 Xdl1JmTNI96VUjJeyZekNGzNZxB88j7wSy4h2uSJPOPyxsayMPO++8JZwXdwB8Bv jUSHeMzB0qkgDNVazQl4oAUZiTDE1SSM84NyHjWYyj9BeJRkJSS7SO8TKyBZPy34 dnH49UYiqxhIVqWK/lny9qkZ/rm27a8ndWmkISD5JVIvImc5tibRXIqQtvp2CYf4 XerV7qyQkJQXKba/zfff =+CHP -----END PGP SIGNATURE----- --=-UGgB60q0HiriAfa1gEH3-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdBSN7n (ORCPT ); Sun, 19 Feb 2017 08:59:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbdBSN7m (ORCPT ); Sun, 19 Feb 2017 08:59:42 -0500 Message-ID: <1487512779.86943.118.camel@redhat.com> Subject: Re: [PATCH] RDMA/qedr: Fix some error handling From: Doug Ledford To: Christophe JAILLET , sean.hefty@intel.com, hal.rosenstock@gmail.com, Ram.Amrani@Cavium.com, Michal.Kalderon@Cavium.com, rajesh.borundia@Cavium.com, weiyongjun1@huawei.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sun, 19 Feb 2017 08:59:39 -0500 In-Reply-To: <20170218112815.9329-1-christophe.jaillet@wanadoo.fr> References: <20170218112815.9329-1-christophe.jaillet@wanadoo.fr> Organization: Red Hat, Inc. Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-UGgB60q0HiriAfa1gEH3" Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 19 Feb 2017 13:59:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-UGgB60q0HiriAfa1gEH3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote: > 'qedr_alloc_pbl_tbl()' can not return NULL. >=20 > In qedr_init_user_queue(): > =C2=A0- simplify the test for the return value, no need to test for NULL > =C2=A0- propagate the error pointer if needed, otherwise 0 (success) is > returned. > =C2=A0=C2=A0 This is spurious. >=20 > In init_mr_info(): > =C2=A0- test the return value with IS_ERR > =C2=A0- propagate the error pointer if needed instead of an exlictit > -ENOMEM. > =C2=A0=C2=A0 This is a no-op as the only error pointer that we can have h= ere is > =C2=A0=C2=A0 already -ENOMEM >=20 > Signed-off-by: Christophe JAILLET Thanks, applied. --=20 Doug Ledford =C2=A0 =C2=A0 GPG KeyID: B826A3330E572FDD =C2=A0 =C2=A0 Key fingerprint =3D AE6B 1BDA 122B 23B4 265B =C2=A01274 B826 A333 0E57 2FDD --=-UGgB60q0HiriAfa1gEH3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYqaTLAAoJELgmozMOVy/diFEP/10sPSLolkFQ6Q2W5EdSufFD tRxIx7e3h3/F0kCA1Nxk+Q/nC1p8OQ9cukK1yAtQvWOTy0rylor+jmF22rYqrB/Z IfEX9pOCYNrPmy1TkuEonT9n3ILaHHXp0kqY2OgAjBV/pSMUl+7FRCM/gObuyXQP Jr6PlgS2HAqlo5mDSLomrR7a/Nn0JmWa5ETFF9I6UZGKFil+9JS44UV68V1DnrcM IXd3G5CySlMQP5Mqxq1nEEhvUD2tgDKSg4hgMSuq7ozI0RSNxgfpiM0IYut6nqdq 1CI8nEtswUsTkOIHCtTaKKjjhepUzye/FqwZKcgNqh5mE3CfGc7t2bnQGVT3viaF f4Y1XicezHDJJ+NM25n0/Bnl5kNtBRWa+pTczQGkW+anFQGAj70XIxNLq9JYoqkT m73uWIHm5/S72RfeQgOyiRRuxddnphB0J3qWhp43r1GxPPJIc/syBXSNdx2QCs03 Xdl1JmTNI96VUjJeyZekNGzNZxB88j7wSy4h2uSJPOPyxsayMPO++8JZwXdwB8Bv jUSHeMzB0qkgDNVazQl4oAUZiTDE1SSM84NyHjWYyj9BeJRkJSS7SO8TKyBZPy34 dnH49UYiqxhIVqWK/lny9qkZ/rm27a8ndWmkISD5JVIvImc5tibRXIqQtvp2CYf4 XerV7qyQkJQXKba/zfff =+CHP -----END PGP SIGNATURE----- --=-UGgB60q0HiriAfa1gEH3--