diff for duplicates of <1487585243.3734.3.camel@baylibre.com> diff --git a/a/1.txt b/N1/1.txt index 6749408..2a55368 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,10 +3,10 @@ On Sun, 2017-02-19 at 21:33 +0100, Heiner Kallweit wrote: > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- -> ?arch/arm64/boot/dts/amlogic/meson-gx.dtsi???| 2 +- -> ?arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ -> ?include/dt-bindings/clock/gxbb-clkc.h???????| 1 + -> ?3 files changed, 7 insertions(+), 1 deletion(-) +> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +- +> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ +> include/dt-bindings/clock/gxbb-clkc.h | 1 + +> 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi @@ -14,25 +14,25 @@ On Sun, 2017-02-19 at 21:33 +0100, Heiner Kallweit wrote: > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -380,7 +380,7 @@ -> ? #size-cells = <2>; -> ? ranges = <0x0 0x0 0x0 0xc8834000 0x0 +> #size-cells = <2>; +> ranges = <0x0 0x0 0x0 0xc8834000 0x0 > 0x2000>; -> ? +> > - rng { > + hwrng: rng { -> ? compatible = "amlogic,meson-rng"; -> ? reg = <0x0 0x0 0x0 0x4>; -> ? }; +> compatible = "amlogic,meson-rng"; +> reg = <0x0 0x0 0x0 0x4>; +> }; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 04b3324b..a375cb21 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -524,3 +524,8 @@ -> ?&vpu { -> ? compatible = "amlogic,meson-gxbb-vpu", "amlogic,meson-gx- +> &vpu { +> compatible = "amlogic,meson-gxbb-vpu", "amlogic,meson-gx- > vpu"; -> ?}; +> }; > + > +&hwrng { > + clocks = <&clkc CLKID_RNG0>; @@ -44,9 +44,9 @@ On Sun, 2017-02-19 at 21:33 +0100, Heiner Kallweit wrote: > --- a/include/dt-bindings/clock/gxbb-clkc.h > +++ b/include/dt-bindings/clock/gxbb-clkc.h > @@ -15,6 +15,7 @@ -> ?#define CLKID_SPI 34 -> ?#define CLKID_I2C 22 -> ?#define CLKID_SAR_ADC 23 +> #define CLKID_SPI 34 +> #define CLKID_I2C 22 +> #define CLKID_SAR_ADC 23 > +#define CLKID_RNG0 25 Shouldn't you comment out the corresponding "define" in @@ -62,19 +62,19 @@ For this to happen, please remember the patch should be sent to them as well. Here you are missing the clock and dt guys: * Stephen Boyd <sboyd@codeaurora.org> * Michael Turquette <mturquette@baylibre.com> -* linux-clk at vger.kernel.org -* devicetree at vger.kernel.org +* linux-clk@vger.kernel.org +* devicetree@vger.kernel.org scripts/get_maintainer.pl can help you finding all people your patch should be sent to. The remaining part of this patch involves DT, so the subject should start with "ARM64: dts: meson-gx:" -You also need to add devicetree at vger.kernel.org in CC. +You also need to add devicetree@vger.kernel.org in CC. Apart from these minor remarks, the patchset looks good to me. Thx ! -> ?#define CLKID_ETH 36 -> ?#define CLKID_USB0 50 -> ?#define CLKID_USB1 51 +> #define CLKID_ETH 36 +> #define CLKID_USB0 50 +> #define CLKID_USB1 51 diff --git a/a/content_digest b/N1/content_digest index b8e0038..569c9bc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,14 @@ "ref\000b2a4cc-686e-0cc0-43e8-552b70a1e868@gmail.com\0" "ref\0a02b078d-9171-cf66-d5d8-84259f9f9a88@gmail.com\0" - "From\0jbrunet@baylibre.com (Jerome Brunet)\0" - "Subject\0[PATCH 1/2] hwrng: meson: expose RNG0 clock via DT\0" + "From\0Jerome Brunet <jbrunet@baylibre.com>\0" + "Subject\0Re: [PATCH 1/2] hwrng: meson: expose RNG0 clock via DT\0" "Date\0Mon, 20 Feb 2017 11:07:23 +0100\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0Heiner Kallweit <hkallweit1@gmail.com>" + Kevin Hilman <khilman@baylibre.com> + " Herbert Xu <herbert@gondor.apana.org.au>\0" + "Cc\0linux-amlogic@lists.infradead.org" + linux-crypto@vger.kernel.org + " Neil Armstrong <narmstrong@baylibre.com>\0" "\00:1\0" "b\0" "On Sun, 2017-02-19 at 21:33 +0100, Heiner Kallweit wrote:\n" @@ -11,10 +16,10 @@ "> \n" "> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n" "> ---\n" - "> ?arch/arm64/boot/dts/amlogic/meson-gx.dtsi???| 2 +-\n" - "> ?arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++\n" - "> ?include/dt-bindings/clock/gxbb-clkc.h???????| 1 +\n" - "> ?3 files changed, 7 insertions(+), 1 deletion(-)\n" + "> \302\240arch/arm64/boot/dts/amlogic/meson-gx.dtsi\302\240\302\240\302\240| 2 +-\n" + "> \302\240arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++\n" + "> \302\240include/dt-bindings/clock/gxbb-clkc.h\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 1 +\n" + "> \302\2403 files changed, 7 insertions(+), 1 deletion(-)\n" "> \n" "> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi\n" "> b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi\n" @@ -22,25 +27,25 @@ "> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi\n" "> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi\n" "> @@ -380,7 +380,7 @@\n" - "> ?\t\t\t#size-cells = <2>;\n" - "> ?\t\t\tranges = <0x0 0x0 0x0 0xc8834000 0x0\n" + "> \302\240\t\t\t#size-cells = <2>;\n" + "> \302\240\t\t\tranges = <0x0 0x0 0x0 0xc8834000 0x0\n" "> 0x2000>;\n" - "> ?\n" + "> \302\240\n" "> -\t\t\trng {\n" "> +\t\t\thwrng: rng {\n" - "> ?\t\t\t\tcompatible = \"amlogic,meson-rng\";\n" - "> ?\t\t\t\treg = <0x0 0x0 0x0 0x4>;\n" - "> ?\t\t\t};\n" + "> \302\240\t\t\t\tcompatible = \"amlogic,meson-rng\";\n" + "> \302\240\t\t\t\treg = <0x0 0x0 0x0 0x4>;\n" + "> \302\240\t\t\t};\n" "> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi\n" "> b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi\n" "> index 04b3324b..a375cb21 100644\n" "> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi\n" "> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi\n" "> @@ -524,3 +524,8 @@\n" - "> ?&vpu {\n" - "> ?\tcompatible = \"amlogic,meson-gxbb-vpu\", \"amlogic,meson-gx-\n" + "> \302\240&vpu {\n" + "> \302\240\tcompatible = \"amlogic,meson-gxbb-vpu\", \"amlogic,meson-gx-\n" "> vpu\";\n" - "> ?};\n" + "> \302\240};\n" "> +\n" "> +&hwrng {\n" "> +\tclocks = <&clkc CLKID_RNG0>;\n" @@ -52,9 +57,9 @@ "> --- a/include/dt-bindings/clock/gxbb-clkc.h\n" "> +++ b/include/dt-bindings/clock/gxbb-clkc.h\n" "> @@ -15,6 +15,7 @@\n" - "> ?#define CLKID_SPI\t\t34\n" - "> ?#define CLKID_I2C\t\t22\n" - "> ?#define CLKID_SAR_ADC\t\t23\n" + "> \302\240#define CLKID_SPI\t\t34\n" + "> \302\240#define CLKID_I2C\t\t22\n" + "> \302\240#define CLKID_SAR_ADC\t\t23\n" "> +#define CLKID_RNG0\t\t25\n" "\n" "Shouldn't you comment out the corresponding \"define\" in\n" @@ -70,21 +75,21 @@ "well. Here you are missing the clock and dt guys:\n" "* Stephen Boyd <sboyd@codeaurora.org>\n" "* Michael Turquette <mturquette@baylibre.com>\n" - "* linux-clk at vger.kernel.org\n" - "* devicetree at vger.kernel.org\n" + "* linux-clk@vger.kernel.org\n" + "* devicetree@vger.kernel.org\n" "\n" "scripts/get_maintainer.pl can help you finding all people your patch\n" "should be sent to.\n" "\n" "The remaining part of this patch involves DT, so the subject should\n" "start with \"ARM64: dts: meson-gx:\"\n" - "You also need to add devicetree at vger.kernel.org in CC.\n" + "You also need to add devicetree@vger.kernel.org in CC.\n" "\n" "Apart from these minor remarks, the patchset looks good to me.\n" "Thx !\n" "\n" - "> ?#define CLKID_ETH\t\t36\n" - "> ?#define CLKID_USB0\t\t50\n" - "> ?#define CLKID_USB1\t\t51" + "> \302\240#define CLKID_ETH\t\t36\n" + "> \302\240#define CLKID_USB0\t\t50\n" + "> \302\240#define CLKID_USB1\t\t51" -0e404cff8749e3249438d3788552fe3d794425a4e5d3c41b10a412ab6374c28f +194e00784aa7548231c7bef51f696763fcbb05350dbbc758ee8199ba133bf481
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.