From: "Philippe Rivest" <technophil98@gmail.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bitbake: fetch2/git: Escape parentheses in git src name
Date: Tue, 23 Apr 2024 06:51:30 -0700 [thread overview]
Message-ID: <14877.1713880290929319572@lists.openembedded.org> (raw)
In-Reply-To: <638cc02f-c0b8-42e5-9ee6-81114812427e@myneves.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
I considered quoting the clone directory. However, since the base implementation used replace calls, I followed suit.
Whenever there was a parenthesis in the repo name, the clone would fail with the original implementation.
There should not be any side effects: no released version of Bitbake/git fetcher has support for parentheses in
in the repo name.
I agree that a replacement list/map is a more scalable solution, but might come with a higher risk of side effects.
The same can be said for quoting the clone directory. Adding replace calls was a simple fix to a simple and narrow problem.
[-- Attachment #2: Type: text/html, Size: 627 bytes --]
prev parent reply other threads:[~2024-04-23 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 3:33 [PATCH] bitbake: fetch2/git: Escape parentheses in git src name Philippe Rivest
2024-04-13 10:20 ` [bitbake-devel] " Paulo Neves
2024-04-23 13:51 ` Philippe Rivest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14877.1713880290929319572@lists.openembedded.org \
--to=technophil98@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.