From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: Re: [PATCH v3 3/6] drm/i915: Amalgamate flushing of display objects
Date: Wed, 22 Feb 2017 12:57:51 +0200 [thread overview]
Message-ID: <1487761071.3483.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170222094121.30959-3-chris@chris-wilson.co.uk>
Add the message from your reply.
On ke, 2017-02-22 at 09:41 +0000, Chris Wilson wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
<SNIP>
> @@ -1613,23 +1613,16 @@ i915_gem_sw_finish_ioctl(struct drm_device *dev, void *data,
> {
> struct drm_i915_gem_sw_finish *args = data;
> struct drm_i915_gem_object *obj;
> - int err = 0;
>
> obj = i915_gem_object_lookup(file, args->handle);
> if (!obj)
> return -ENOENT;
>
> /* Pinned buffers may be scanout, so flush the cache */
> - if (READ_ONCE(obj->pin_display)) {
> - err = i915_mutex_lock_interruptible(dev);
> - if (!err) {
> - i915_gem_object_flush_cpu_write_domain(obj);
> - mutex_unlock(&dev->struct_mutex);
> - }
> - }
> -
> + i915_gem_object_flush_to_display(obj);
.._flush_if_display() and this is
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-22 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 9:41 [PATCH v3 1/6] drm/i915: Remove change_domain tracepoint Chris Wilson
2017-02-22 9:41 ` [PATCH v3 2/6] drm/i915: Move cpu_cache_is_coherent() to header Chris Wilson
2017-02-22 11:02 ` Joonas Lahtinen
2017-02-22 9:41 ` [PATCH v3 3/6] drm/i915: Amalgamate flushing of display objects Chris Wilson
2017-02-22 9:54 ` Chris Wilson
2017-02-22 10:57 ` Joonas Lahtinen [this message]
2017-02-22 9:41 ` [PATCH v3 4/6] drm/i915: Skip clflushes for all non-page backed objects Chris Wilson
2017-02-22 9:41 ` [PATCH v3 5/6] drm/i915: Perform object clflushing asynchronously Chris Wilson
2017-02-22 11:01 ` Joonas Lahtinen
2017-02-22 9:41 ` [PATCH v3 6/6] drm/i915: Remove 'retire' parameter from intel_fb_obj_flush Chris Wilson
2017-02-22 11:04 ` Joonas Lahtinen
2017-02-22 10:22 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/6] drm/i915: Remove change_domain tracepoint Patchwork
2017-02-22 10:30 ` [PATCH v3 1/6] " Joonas Lahtinen
-- strict thread matches above, loose matches on Subject: below --
2017-09-12 22:11 [PATCH v3 3/6] drm/i915: Amalgamate flushing of display objects Yaroslav Shabalin
2017-09-14 10:48 ` Yaroslav Shabalin
2017-09-14 10:57 ` Chris Wilson
2017-09-14 12:27 ` Yaroslav Shabalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487761071.3483.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.