From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Remove Braswell GGTT update w/a
Date: Wed, 22 Feb 2017 13:27:41 +0200 [thread overview]
Message-ID: <1487762861.3483.8.camel@linux.intel.com> (raw)
In-Reply-To: <20170220124718.14796-1-chris@chris-wilson.co.uk>
On ma, 2017-02-20 at 12:47 +0000, Chris Wilson wrote:
> Testing with concurrent GGTT accesses no longer show the coherency
> problems from yonder, commit 5bab6f60cb4d ("drm/i915: Serialise updates
> to GGTT with access through GGTT on Braswell"). My presumption is that
> the root cause was more likely fixed by commit 3b5724d702ef ("drm/i915:
> Wait for writes through the GTT to land before reading back"), along
> with the use of WC updates to the global gTT in commit 8448661d65f6
> ("drm/i915: Convert clflushed pagetables over to WC maps". Given
> that the original symptoms can no longer be reproduced, time to remove
> the workaround.
>
> Testcase: igt/gem_concurrenct_blit
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Makes one think if the original fix has been appropriate, when adding
stop_machine for a software bug :P
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-22 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 12:47 [PATCH] drm/i915: Remove Braswell GGTT update w/a Chris Wilson
2017-02-20 13:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-22 11:27 ` Joonas Lahtinen [this message]
2017-02-22 11:39 ` [PATCH] " Chris Wilson
2017-02-22 18:02 ` Chris Wilson
2017-02-22 23:04 ` Chris Wilson
2017-02-23 9:33 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487762861.3483.8.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.