From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks Date: Wed, 22 Feb 2017 17:14:35 +0100 Message-ID: <1487780078-18510-2-git-send-email-michael.hennerich@analog.com> References: <1487780078-18510-1-git-send-email-michael.hennerich@analog.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-bl2nam02on0084.outbound.protection.outlook.com ([104.47.38.84]:37568 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754320AbdBVQOZ (ORCPT ); Wed, 22 Feb 2017 11:14:25 -0500 In-Reply-To: <1487780078-18510-1-git-send-email-michael.hennerich@analog.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich From: Michael Hennerich Mask only applied to the top byte of the register Signed-off-by: Michael Hennerich --- drivers/input/touchscreen/ad7879-spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c index f2c06b5..b995891 100644 --- a/drivers/input/touchscreen/ad7879-spi.c +++ b/drivers/input/touchscreen/ad7879-spi.c @@ -19,8 +19,8 @@ #define MAX_SPI_FREQ_HZ 5000000 -#define AD7879_CMD_MAGIC 0xE000 -#define AD7879_CMD_READ BIT(10) +#define AD7879_CMD_MAGIC 0xE0 +#define AD7879_CMD_READ BIT(2) static const struct regmap_config ad7879_spi_regmap_config = { .reg_bits = 16, -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933113AbdBVQPN (ORCPT ); Wed, 22 Feb 2017 11:15:13 -0500 Received: from mail-bl2nam02on0084.outbound.protection.outlook.com ([104.47.38.84]:37568 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754320AbdBVQOZ (ORCPT ); Wed, 22 Feb 2017 11:14:25 -0500 Authentication-Results: spf=pass (sender IP is 137.71.25.55) smtp.mailfrom=analog.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=analog.com; From: To: CC: , , "Michael Hennerich" Subject: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks Date: Wed, 22 Feb 2017 17:14:35 +0100 Message-ID: <1487780078-18510-2-git-send-email-michael.hennerich@analog.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487780078-18510-1-git-send-email-michael.hennerich@analog.com> References: <1487780078-18510-1-git-send-email-michael.hennerich@analog.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39860400002)(39450400003)(39410400002)(39840400002)(39850400002)(2980300002)(438002)(189002)(199003)(50466002)(2876002)(2950100002)(110136004)(48376002)(4326007)(39060400002)(2906002)(50226002)(2351001)(76176999)(6916009)(8936002)(246002)(38730400002)(107886003)(106466001)(77096006)(626004)(7636002)(6666003)(8676002)(50986999)(356003)(92566002)(33646002)(305945005)(54906002)(5003940100001)(36756003)(5660300001)(189998001)(86152003)(86362001)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0301MB0835;H:nwd2mta1.analog.com;FPR:;SPF:Pass;PTR:nwd2mail10.analog.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC005;1:3y2dUV30VSe0Y+OhdOBUA4vyoeo/e37vj9sX0+Sy5NWbaGs/HdM+UQ0Ay8nUcpNBWo3JI+ESF85fHk3CBfEFwfRaYml+yRjIBqM4kQXGAHy+H9aH7apRdopfL5GV2UB67tN8XmVOMMP2suSkJqMUPfTEiR1J4Sxj9hJWzqYyQBSJLIduSJHuHk4fyt81rE5OrxSQ/MS2Q5lGFuq33gBB4ObDXlIu7i1SONmUq2Q80m8LiqDoz7/YRZCPpZB+b0OZW5GTckydY50Vdgijma5wHc/6rKQcxDojmEY3BOCqsfSfuBslUyJTw5h9aF55ebf1LegDDKpHnkojmtn0axYF0AcsPkjV4LDnjNziL3Cae+FNOaC3GBAGEnO2fqKiy6yirEW0Dha45sNMd9SOJXOS0DNKqtAiQCjBs2bup3ahwhzpi+/WJZPG3pt6MOzK9BPBp5IekB/O3nU7YxKvSn+teGwANeUCsUHD494BIWie9KL1PiOdUAdYHmXfiaW/E+cRpS5jJKPgboOU9mrgXKv6Fohpc3GPRLHMJ/8Q+HCCjtXlQoST7lHDEhFkouGshSKg/tyHUVOGsdmJK/BOwIcmvw== X-MS-Office365-Filtering-Correlation-Id: d379698b-e4b0-438f-b883-08d45b3dbc9c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN3PR0301MB0835; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0835;3:L2bLSeQRJ45F02lAmcsejPevHCSEGzMHr2zALI+wC5hQU6AXQhyXkfmF5uRfttgV6VofjdQIkuJDaphnwl+dzN0KjhU1LNJarS+5JqzMDKOn366F3IMnEEg1ZHRp4MHHz7Zdyj3k5KzutD3BHpbiP1SKFyCDwaILtxDhzSWTRyI2zUeTRX1d+x4MizgFJ3tefzPqwSYid2SxbQa+Z/OKHlfqTOhQKLCetSvxCx16PVTFbqW3H2EbtOm9jl81nxsa6FZR44W0Bm43rSx542Dh3fKW0YJyBgxhFm8hAY2TNW80F1awPT9I+yT9pd692j1Fg/TY1ykqDA7RYDNraPIfaitR7g+OZusHg5kE1sii9/yga5t3EYUAPAG38A3nRpIkNTRjLEZbmTsTQNR07n6hRw==;25:U7B/e7oM/xVK+XadEsasAOeJOFkHNgZmK8TdEkKNl8G90sGm2Mdvm5h9e9+KkCB2IjJQUvX0Y94kfxLGgcOjEkgHmbleApHvQG8puO+XYF8Xqt8zvB6DR8jnqbbD3qEVRBCMf2h9wB6JE4OHdx3rN+HF4nVG+eXJg8JCMpHYXfQBIaFP7Q6AeHdiMO/eJuj1eO0jqPvZ+uPj8TRT+NGKM6/+pOkxFAG6mvj4gq/+Jmb/OJOfZmsE/nE3oeNDGZo72vl7ymbmfBRMPWXhe32v9tBBO0nOEJl/o+GFpnfOespu0Vkd0eoRXoer9EZj+ascJyoA0RROjxGdXkdpIvwODKoumkq90o0BMrjYSqleKKEsiGMY8556f/yrS4/FSdMgWryi5re7SraFvWaEKoiEOAQlBZdneuy17HZ8OOk0guXN1BNGXTGEOOTRnW1ABSARzRJIaxn0ZHCEeVwG7JcWMw== X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0835;31:FyyJxt94dS85eyG5vq+ZCK0AZ4RsAEdWz5gp1s6v13xriSdTISk4TD5iWMLt647cbrFsSHGuk1+/EIQ7UqKmqx3TywhKMD3ERQO5+v+GymiEyxLy+53VH2ocDW62AmH9WapUgnml9PxeHhZ86d+tLB/wtDy2HQm9OMpeGCtWxAs6Tn98JW50cZt4bXW/OuvVGpzQwIPRXBke53CaJMJ/3pI8nNikwYwmxIU8PB8L/jZ5ufgro467/yfOfVyfmEMRQ4/U31zJdv0OjV4loCVpe4o4uRdp1QXok3A95wvn1Zk=;20:KfUU9LTe8nmxMsFo34gj8cSaMZvddDKF2mZ7NgMg/E3X8/taLFhh4rituW8WQ/5Wpg/0MjDZ09pPCHAXaY2+PCbrgN+/wScCMWfTqbJt4UcV2SOxtLmcql1qhByUZNq9bmyKBNEZlUFLBcQ46U3TCLQZN3+L9kIl1/mHah5TExJmvk+T2FGpFYDfNbfquhFTR2Q8S9azxENgtuGojSmknofO7m2KFOBHlx1mODr7ouRfSpYUbkeMAVs3k+hIAQpzmHMjF65uXAqUNM7GyUXQNkFzTxNxKwbFbeU9rll9ZzaK+r09+WysV8wnp+wNXkx8+g02zTXZUljciv3dMHgtsd6PE1+zIeCcJGTd3urOl2HzqVEkM5DmG9EPtwy+1f98LD0AsyiH76Vb3RvDXl7Bha+f4J9rkm2tH5UReveH1fjvi11QjI0Tww3cIJlIwJkGRH7hU2AdOg8wYz4rCC5AwgXL+Z8mDzfcnHH1S1RFAZT+X328JmNN6QGVlyqpgD3V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13018025)(8121501046)(5005006)(13017025)(13024025)(13015025)(13023025)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:BN3PR0301MB0835;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB0835; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0835;4:kt51c/yiTtCPmgIogHjxesrQ2WT5Bm4vlNQc+UuNvT5TerF0K5nLR2f01zlYNSFteNrcqm7kaKHIZGD2mbjdR6Db95qHuF05SK7oInFRfo9GyxTjcJZszz0LITVLeccJ7Qe1YM+CNync0dRsSDOX+oM3nYdGI4uF5e0JcRM2+yuEH7+jtfYv/4334nymZE0rZrQTfP1gwO2OnMRN4UKH0OVeaj+749oGEshFq8EdEQwY7wzR0ouDY0/1XJTiah4W3NxfnbG2Fhu8mewu38rLQqXkJRiPBAEMx9XywdJkgc34yQQaTHdY2txPKm5q88ubD47ujokvG8yi8WZUlwLnI3BXXFezHbuZUCren4NJE3bG7M3rHn2b3nAJ+HVqj9xOybq7fMAm4NLkQJb185jUorzAuVger9ymmMmo07t96UuL/5bGHdQe0XAT5CO9A/7MIpA+qeFyaDKbmWKf+Ko9ZtBDi0l+1soKX0mpGPmp5WV43Zc9X7rZIB6JYeml21IrZem12W3VVvY82cP+R2dyBXA8VEPJcS40p5dp0iuhDUNBQFTPRlUq6xSS5xZ3fhmvT4N0GLhZg5j8Uem+0nFLGgp5nXR3uZSpVmmxgk5TJD6Kc9XCwLsWe6EwSxGmO96Ri8SmzNtj+7qwspDipcSDtKTScW9+LnembVcA0jfg8V/FUw0uoMSpmTIA2ugf5moxSsD09TmZb/CNRSCvZDC6zIiW6WN3aZo1FVkhBUrq0sVZQ2enBiz1qgwQSiGP01o92pgpNW1BszwoOlK4m1fCQw== X-Forefront-PRVS: 022649CC2C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB0835;23:SZSHByfgN0zxsWqU0bKOWAJcPnZNhASTq5zLDYW?= =?us-ascii?Q?yHIbj/wpPG+q2rB2zygYAEXmeMobWutrdzKL7gITe56g54+Bf77UxO+kk/q2?= =?us-ascii?Q?04uDelSAL71bFyxFsNZNlJGW5GQS5JoJoLpXAWS5iOU9Z0VWqGK6+Rfoioqr?= =?us-ascii?Q?D7HN5aT58YBj5CKBAr8L/JHcGXYKcBClBHO7BvJ5HBtDJdveiAtfSgSASbHS?= =?us-ascii?Q?QcrfpzQB4hauQSNkayBRws/SsY6ag/MnbQDIaQXFGx5WQpIefVu2I1kdAw6L?= =?us-ascii?Q?7vC/C+uhg2uLikSnToqErE3U64ttNBV+H2qd7ZhawSa75vAMecv2xhpn6dP9?= =?us-ascii?Q?ItIZVXgQ+LtUpGOfKlPcGhIJ3iVQ+oVg4JWBFXAAfe6Vc1zE3gJeZZpn+E+U?= =?us-ascii?Q?ZoJy3hIoM3XAH4CtTxaP5nJHscb4IxeSgXR//MGnN60g4CqTGryidb5P/a0i?= =?us-ascii?Q?wtq4gi1+oe7+4Rw+vxpZQZxoCtr42u0y5iu66Ip2GC51GUo6z1qS145ehnyf?= =?us-ascii?Q?vd3dgLHnpqD0cqjOEkcVig76rTzhj9OtsjK5e8YgOpl4MXORJCOpM5uZuY9d?= =?us-ascii?Q?lU8TqDTKcHy4PkNp+CFAIHEHv/dCMqkjdVZXFZjmCM5BSLNvXXI+CpwuOrJK?= =?us-ascii?Q?b2nm7VwUuPTtSny06b1RpI/PkKjPQBj9ZjAJqXGTBZ+hQl2PJPtPhRnXN1fE?= =?us-ascii?Q?QgYWyYm3hRU1BYQaz8DMXZ69FdSuHfKk9vsKYYfQpoAWuqb9glnbJetF3G6j?= =?us-ascii?Q?GARYTE2QjbsshRs6njt/nefDByEf/cDIVDFhC0ynm+GPzwof3NChkHJvEJw2?= =?us-ascii?Q?Xu9SCrmq4fPD9R8+rOoW4Ehw7IvytR3rbYWV68+Wbvr6WetPw2S21pYIuLRg?= =?us-ascii?Q?kvmpjD8kR7Ey7+A9LaXfj1zUYIA4PWc4Cmu/pzd6vUrMLTYnWgep5QML2OHF?= =?us-ascii?Q?1sNXvHmR2QJjKxZ9/cDDuaNRxutrlnHBM9ndVv3YmnAAV/+VZvAn86/Usgps?= =?us-ascii?Q?ZgUcMdontNs0ryxrX+GD2LoTPviS19vIGPq1OsxP8b6RHj/edp9MOQazlhcI?= =?us-ascii?Q?Ps9O6ESR2b+8uYg6vEm7V2oyV70gvUfzDSi3t48sM/GHNx2j17uYYyA4Ga3n?= =?us-ascii?Q?BbvuL1iuFCMg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0835;6:ltp+0Ddv7SwGXyXMyuSiOZmztiKNt3YgHRLzIy3Lsmj+j2FSMGXt/7o6FO1C6UTt1eWM0H+PEpvggA6GlYX0w6YEJh8bUPVLEZCgF6r6ffOouZX6DkJARoRHUgn4wNpcm1qkl3ZsdQ6xHqwdztpOrxX97e5IhJVRs16DMWz8TisnFbdPLqbk5Wg5MpzDzs652WVTX9LVeJgYwGjv3He4wEEmyDv1DgtjmejbVCgWfOTpy+ztlNGHnr3KlQe8qprP2T1QJbZxIh1JewngGHa17MWgJh6CJrrhn5pvQhCm/W1tj7kmhqoDGlTaDFF3GvQxOPY1nQkDrRa9EQgM+DP8sRiLtkWXX9fDSxFnTiWxxuWLPC17cR22nX8O40FUvw4u3szJ2zRLlPhBEFOih1wV20iEL7XqAZAlnM8a166dkLU=;5:ol5mCksSbAxSmiveGmYvzSwOSve8xnzvd37q9LV2WWb5DvMKHQnWwrukTdInOj6M9Yh4Y57jbak2JS3iUMoLfHcRYYhrxO7ZD731MDThn2MSM2qOmu7BLDn1wVDG/U+W3/E2s/d1ri5WCctdxm4hiQ==;24:tjhHR2Eqc0GaHmScg63vdxw89s3Pyh2t5ynTtmEHIyg5ZzLqXR46Nv4R5aPuKtSa3XxHdCSijlR22ZFaX/Kd2CYGWb7QpP2w3AutW8LvOGE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0835;7:08L/MLprLuSykVwZRgOqVw0z1LkXGJ5mInwqGDUtpV3D48rl6TiOYidvb66AcM/1TsPtC79lQv14DXGwjjgMKnoy3bUTZ2ngU9tUVCp6+tUx4qP3jtw76RLRA4d/boNNcCS6ZwN+BehHy7cQrnD9YyTLEbiob82+E9Tn6vQw+x04j3uCvtk4+RZLD6W6kNBZuRLtJyXEMG7h52IrJjnizclvZdhzOD36Lxgekk9Vp+vwEn05b4xYIpTSvvCPXur8JZlkyl3eWvNvNOGw+hc1ad5edriZ9rt29NFXpoxetZwmk9Xr3g4cnBrX18GveTcwfZUBMQLp0JOc0GeECFASjw== X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 16:13:28.0666 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0835 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Hennerich Mask only applied to the top byte of the register Signed-off-by: Michael Hennerich --- drivers/input/touchscreen/ad7879-spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c index f2c06b5..b995891 100644 --- a/drivers/input/touchscreen/ad7879-spi.c +++ b/drivers/input/touchscreen/ad7879-spi.c @@ -19,8 +19,8 @@ #define MAX_SPI_FREQ_HZ 5000000 -#define AD7879_CMD_MAGIC 0xE000 -#define AD7879_CMD_READ BIT(10) +#define AD7879_CMD_MAGIC 0xE0 +#define AD7879_CMD_READ BIT(2) static const struct regmap_config ad7879_spi_regmap_config = { .reg_bits = 16, -- 2.7.4