diff for duplicates of <1487793793.5907.25.camel@collabora.com> diff --git a/a/1.txt b/N1/1.txt index ba48f24..fd26883 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : +Le mercredi 22 f?vrier 2017 ? 15:57 -0300, Thibault Saunier a ?crit?: > On 02/22/2017 03:06 PM, Hans Verkuil wrote: > > > > On 02/22/2017 05:05 AM, Thibault Saunier wrote: @@ -23,21 +23,21 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > > > > > don't agree on the display resolution that should be used as > > > > > a threshold. > > > > > -> > > > > From EIA CEA 861B about colorimetry for various +> > > > > ? From EIA CEA 861B about colorimetry for various > > > > > resolutions: > > > > > -> > > > > - 5.1 480p, 480i, 576p, 576i, 240p, and 288p -> > > > > The color space used by the 480-line, 576-line, 240- +> > > > > ????- 5.1 480p, 480i, 576p, 576i, 240p, and 288p +> > > > > ??????The color space used by the 480-line, 576-line, 240- > > > > > line, and 288-line -> > > > > formats will likely be based on SMPTE 170M [1]. -> > > > > - 5.2 1080i, 1080p, and 720p -> > > > > The color space used by the high definition formats +> > > > > ??????formats will likely be based on SMPTE 170M [1]. +> > > > > ????- 5.2 1080i, 1080p, and 720p +> > > > > ??????The color space used by the high definition formats > > > > > will likely be -> > > > > based on ITU-R BT.709-4 +> > > > > ??????based on ITU-R BT.709-4 > > > > > > > > > > This indicates that in the case that userspace does not > > > > > specify what -> > > > > colorspace should be used, we should use 576p as a threshold +> > > > > colorspace should be used, we should use 576p??as a threshold > > > > > to set > > > > > V4L2_COLORSPACE_REC709 instead of V4L2_COLORSPACE_SMPTE170M. > > > > > Even if it is @@ -65,7 +65,7 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > > > > > Changes in v5: > > > > > - Squash commit to always use output colorspace on the > > > > > capture side -> > > > > inside this one +> > > > > ????inside this one > > > > > - Fix typo in commit message > > > > > > > > > > Changes in v4: @@ -79,10 +79,10 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > > > > > > > > > > Changes in v2: None > > > > > -> > > > > drivers/media/platform/exynos-gsc/gsc-core.c | 20 +> > > > > ???drivers/media/platform/exynos-gsc/gsc-core.c | 20 > > > > > +++++++++++++++----- -> > > > > drivers/media/platform/exynos-gsc/gsc-core.h | 1 + -> > > > > 2 files changed, 16 insertions(+), 5 deletions(-) +> > > > > ???drivers/media/platform/exynos-gsc/gsc-core.h |??1 + +> > > > > ???2 files changed, 16 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c > > > > > b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -91,30 +91,30 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > > > > > +++ b/drivers/media/platform/exynos-gsc/gsc-core.c > > > > > @@ -454,6 +454,7 @@ int gsc_try_fmt_mplane(struct gsc_ctx > > > > > *ctx, struct v4l2_format *f) -> > > > > } else { -> > > > > min_w = variant->pix_min->target_rot_dis_w; -> > > > > min_h = variant->pix_min->target_rot_dis_h; -> > > > > + pix_mp->colorspace = ctx->out_colorspace; -> > > > > } -> > > > > pr_debug("mod_x: %d, mod_y: %d, max_w: %d, max_h = +> > > > > ???????} else { +> > > > > ???????????min_w = variant->pix_min->target_rot_dis_w; +> > > > > ???????????min_h = variant->pix_min->target_rot_dis_h; +> > > > > +????????pix_mp->colorspace = ctx->out_colorspace; +> > > > > ???????} +> > > > > ?????????pr_debug("mod_x: %d, mod_y: %d, max_w: %d, max_h = > > > > > %d", > > > > > @@ -472,10 +473,15 @@ int gsc_try_fmt_mplane(struct gsc_ctx > > > > > *ctx, struct v4l2_format *f) -> > > > > pix_mp->num_planes = fmt->num_planes; -> > > > > - if (pix_mp->width >= 1280) /* HD */ -> > > > > - pix_mp->colorspace = V4L2_COLORSPACE_REC709; -> > > > > - else /* SD */ -> > > > > - pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; -> > > > > + if (pix_mp->colorspace == V4L2_COLORSPACE_DEFAULT) { -> > > > > + if (pix_mp->width > 720 && pix_mp->height > 576) /* +> > > > > ?????????pix_mp->num_planes = fmt->num_planes; +> > > > > ???-????if (pix_mp->width >= 1280) /* HD */ +> > > > > -????????pix_mp->colorspace = V4L2_COLORSPACE_REC709; +> > > > > -????else /* SD */ +> > > > > -????????pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; +> > > > > +????if (pix_mp->colorspace == V4L2_COLORSPACE_DEFAULT) { +> > > > > +????????if (pix_mp->width > 720 && pix_mp->height > 576) /* > > > > > HD */ > > > > > > > > I'd use || instead of && here. Ditto for the next patch. > > > > -> > > > > + pix_mp->colorspace = V4L2_COLORSPACE_REC709; -> > > > > + else /* SD */ -> > > > > + pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; -> > > > > + } +> > > > > +????????????pix_mp->colorspace = V4L2_COLORSPACE_REC709; +> > > > > +????????else /* SD */ +> > > > > +????????????pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; +> > > > > +????} > > > > > > > > Are you sure this is in fact how it is used? If the source of > > > > the video @@ -138,7 +138,7 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > Well, right, sorry I am talking in GStreamer terminlogy where what > you call > colorspace is called colorimetry, and colorspace is what I am -> talking +> talking? > about here. > > > In fact, I suspect (correct me if I am wrong) that it only converts @@ -171,7 +171,7 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > if the case the user is passing DEFAULT (meaning he does not know > what > it should be and lets the driver set it, this will happen in the -> case +> case? > where the > information was not contain in the source, which means the value has > to be @@ -182,7 +182,7 @@ Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > I would be happy to read more information about that subject and will > try to fix remaining suggested points once I have a better > understanding -> of the whole concepts and problems in that driver, but I still think +> of the whole concepts and problems in that driver, but I still think? > that this > patch is correct for what it is aiming at fixing. > @@ -239,3 +239,10 @@ v4l2_ycbcr_encoding and v4l2_quantization (ignoring hsv, as it does not apply). If you have a limited driver, that only target one of these 3 items, you will likely keep the colorspace as-is, and override the specific functions. +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: signature.asc +Type: application/pgp-signature +Size: 181 bytes +Desc: This is a digitally signed message part +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170222/80832c73/attachment.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index 2749816..0000000 --- a/a/2.bin +++ /dev/null @@ -1,7 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v2 - -iEYEABECAAYFAlit7oEACgkQcVMCLawGqBzzWgCfaNQ5E5PNv7NE+AMPS1TwHjRZ -GGUAoMXBLEvrEUFdLSKBwaUbjsMtIHuZ -=vKpv ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index da6d245..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,3 +0,0 @@ -Content-Type: application/pgp-signature; name="signature.asc" -Content-Description: This is a digitally signed message part -Content-Transfer-Encoding: 7bit diff --git a/a/content_digest b/N1/content_digest index cd932f5..4f95e6c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,30 +4,13 @@ "ref\058ee4eb5-981d-175f-52a9-445bbc265af0@osg.samsung.com\0" "ref\002a38e14-052b-faf2-a7a1-ef2f968f6d35@xs4all.nl\0" "ref\04fc7b224-b167-51f0-e60b-c4dff35a8986@osg.samsung.com\0" - "From\0Nicolas Dufresne <nicolas.dufresne@collabora.com>\0" - "Subject\0Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided\0" + "From\0nicolas.dufresne@collabora.com (Nicolas Dufresne)\0" + "Subject\0[PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided\0" "Date\0Wed, 22 Feb 2017 15:03:13 -0500\0" - "To\0Thibault Saunier <thibault.saunier@osg.samsung.com>" - Hans Verkuil <hverkuil@xs4all.nl> - " linux-kernel@vger.kernel.org\0" - "Cc\0Mauro Carvalho Chehab <mchehab@kernel.org>" - Marek Szyprowski <m.szyprowski@samsung.com> - Kukjin Kim <kgene@kernel.org> - Mauro Carvalho Chehab <mchehab@s-opensource.com> - Andi Shyti <andi.shyti@samsung.com> - linux-media@vger.kernel.org - Shuah Khan <shuahkh@osg.samsung.com> - Javier Martinez Canillas <javier@osg.samsung.com> - linux-samsung-soc@vger.kernel.org - Krzysztof Kozlowski <krzk@kernel.org> - Inki Dae <inki.dae@samsung.com> - Sylwester Nawrocki <s.nawrocki@samsung.com> - linux-arm-kernel@lists.infradead.org - Ulf Hansson <ulf.hansson@linaro.org> - " Hans Verkuil <hans.verkuil@cisco.com>\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" - "Le mercredi 22 f\303\251vrier 2017 \303\240 15:57 -0300, Thibault Saunier a \303\251crit\302\240:\n" + "Le mercredi 22 f?vrier 2017 ? 15:57 -0300, Thibault Saunier a ?crit?:\n" "> On 02/22/2017 03:06 PM, Hans Verkuil wrote:\n" "> > \n" "> > On 02/22/2017 05:05 AM, Thibault Saunier wrote:\n" @@ -52,21 +35,21 @@ "> > > > > don't agree on the display resolution that should be used as\n" "> > > > > a threshold.\n" "> > > > > \n" - "> > > > > \302\240 From EIA CEA 861B about colorimetry for various\n" + "> > > > > ? From EIA CEA 861B about colorimetry for various\n" "> > > > > resolutions:\n" "> > > > > \n" - "> > > > > \302\240\302\240\302\240\302\240- 5.1 480p, 480i, 576p, 576i, 240p, and 288p\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240The color space used by the 480-line, 576-line, 240-\n" + "> > > > > ????- 5.1 480p, 480i, 576p, 576i, 240p, and 288p\n" + "> > > > > ??????The color space used by the 480-line, 576-line, 240-\n" "> > > > > line, and 288-line\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240formats will likely be based on SMPTE 170M [1].\n" - "> > > > > \302\240\302\240\302\240\302\240- 5.2 1080i, 1080p, and 720p\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240The color space used by the high definition formats\n" + "> > > > > ??????formats will likely be based on SMPTE 170M [1].\n" + "> > > > > ????- 5.2 1080i, 1080p, and 720p\n" + "> > > > > ??????The color space used by the high definition formats\n" "> > > > > will likely be\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240based on ITU-R BT.709-4\n" + "> > > > > ??????based on ITU-R BT.709-4\n" "> > > > > \n" "> > > > > This indicates that in the case that userspace does not\n" "> > > > > specify what\n" - "> > > > > colorspace should be used, we should use 576p\302\240\302\240as a threshold\n" + "> > > > > colorspace should be used, we should use 576p??as a threshold\n" "> > > > > to set\n" "> > > > > V4L2_COLORSPACE_REC709 instead of V4L2_COLORSPACE_SMPTE170M.\n" "> > > > > Even if it is\n" @@ -94,7 +77,7 @@ "> > > > > Changes in v5:\n" "> > > > > - Squash commit to always use output colorspace on the\n" "> > > > > capture side\n" - "> > > > > \302\240\302\240\302\240\302\240inside this one\n" + "> > > > > ????inside this one\n" "> > > > > - Fix typo in commit message\n" "> > > > > \n" "> > > > > Changes in v4:\n" @@ -108,10 +91,10 @@ "> > > > > \n" "> > > > > Changes in v2: None\n" "> > > > > \n" - "> > > > > \302\240\302\240\302\240drivers/media/platform/exynos-gsc/gsc-core.c | 20\n" + "> > > > > ???drivers/media/platform/exynos-gsc/gsc-core.c | 20\n" "> > > > > +++++++++++++++-----\n" - "> > > > > \302\240\302\240\302\240drivers/media/platform/exynos-gsc/gsc-core.h |\302\240\302\2401 +\n" - "> > > > > \302\240\302\240\302\2402 files changed, 16 insertions(+), 5 deletions(-)\n" + "> > > > > ???drivers/media/platform/exynos-gsc/gsc-core.h |??1 +\n" + "> > > > > ???2 files changed, 16 insertions(+), 5 deletions(-)\n" "> > > > > \n" "> > > > > diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c\n" "> > > > > b/drivers/media/platform/exynos-gsc/gsc-core.c\n" @@ -120,30 +103,30 @@ "> > > > > +++ b/drivers/media/platform/exynos-gsc/gsc-core.c\n" "> > > > > @@ -454,6 +454,7 @@ int gsc_try_fmt_mplane(struct gsc_ctx\n" "> > > > > *ctx, struct v4l2_format *f)\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240} else {\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240min_w = variant->pix_min->target_rot_dis_w;\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240min_h = variant->pix_min->target_rot_dis_h;\n" - "> > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->colorspace = ctx->out_colorspace;\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pr_debug(\"mod_x: %d, mod_y: %d, max_w: %d, max_h =\n" + "> > > > > ???????} else {\n" + "> > > > > ???????????min_w = variant->pix_min->target_rot_dis_w;\n" + "> > > > > ???????????min_h = variant->pix_min->target_rot_dis_h;\n" + "> > > > > +????????pix_mp->colorspace = ctx->out_colorspace;\n" + "> > > > > ???????}\n" + "> > > > > ?????????pr_debug(\"mod_x: %d, mod_y: %d, max_w: %d, max_h =\n" "> > > > > %d\",\n" "> > > > > @@ -472,10 +473,15 @@ int gsc_try_fmt_mplane(struct gsc_ctx\n" "> > > > > *ctx, struct v4l2_format *f)\n" - "> > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->num_planes = fmt->num_planes;\n" - "> > > > > \302\240\302\240\302\240-\302\240\302\240\302\240\302\240if (pix_mp->width >= 1280) /* HD */\n" - "> > > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->colorspace = V4L2_COLORSPACE_REC709;\n" - "> > > > > -\302\240\302\240\302\240\302\240else /* SD */\n" - "> > > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M;\n" - "> > > > > +\302\240\302\240\302\240\302\240if (pix_mp->colorspace == V4L2_COLORSPACE_DEFAULT) {\n" - "> > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (pix_mp->width > 720 && pix_mp->height > 576) /*\n" + "> > > > > ?????????pix_mp->num_planes = fmt->num_planes;\n" + "> > > > > ???-????if (pix_mp->width >= 1280) /* HD */\n" + "> > > > > -????????pix_mp->colorspace = V4L2_COLORSPACE_REC709;\n" + "> > > > > -????else /* SD */\n" + "> > > > > -????????pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M;\n" + "> > > > > +????if (pix_mp->colorspace == V4L2_COLORSPACE_DEFAULT) {\n" + "> > > > > +????????if (pix_mp->width > 720 && pix_mp->height > 576) /*\n" "> > > > > HD */\n" "> > > > \n" "> > > > I'd use || instead of && here. Ditto for the next patch.\n" "> > > > \n" - "> > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->colorspace = V4L2_COLORSPACE_REC709;\n" - "> > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240else /* SD */\n" - "> > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M;\n" - "> > > > > +\302\240\302\240\302\240\302\240}\n" + "> > > > > +????????????pix_mp->colorspace = V4L2_COLORSPACE_REC709;\n" + "> > > > > +????????else /* SD */\n" + "> > > > > +????????????pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M;\n" + "> > > > > +????}\n" "> > > > \n" "> > > > Are you sure this is in fact how it is used? If the source of\n" "> > > > the video\n" @@ -167,7 +150,7 @@ "> Well, right, sorry I am talking in GStreamer terminlogy where what\n" "> you call\n" "> colorspace is called colorimetry, and colorspace is what I am\n" - "> talking\302\240\n" + "> talking?\n" "> about here.\n" "> \n" "> > In fact, I suspect (correct me if I am wrong) that it only converts\n" @@ -200,7 +183,7 @@ "> if the case the user is passing DEFAULT (meaning he does not know\n" "> what\n" "> it should be and lets the driver set it, this will happen in the\n" - "> case\302\240\n" + "> case?\n" "> where the\n" "> information was not contain in the source, which means the value has\n" "> to be\n" @@ -211,7 +194,7 @@ "> I would be happy to read more information about that subject and will\n" "> try to fix remaining suggested points once I have a better\n" "> understanding\n" - "> of the whole concepts and problems in that driver, but I still think\302\240\n" + "> of the whole concepts and problems in that driver, but I still think?\n" "> that this\n" "> patch is correct for what it is aiming at fixing.\n" "> \n" @@ -267,17 +250,13 @@ "v4l2_ycbcr_encoding and v4l2_quantization (ignoring hsv, as it does not\n" "apply). If you have a limited driver, that only target one of these 3\n" "items, you will likely keep the colorspace as-is, and override the\n" - specific functions. - "\01:2\0" - "fn\0signature.asc\0" - "d\0This is a digitally signed message part\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v2\n" - "\n" - "iEYEABECAAYFAlit7oEACgkQcVMCLawGqBzzWgCfaNQ5E5PNv7NE+AMPS1TwHjRZ\n" - "GGUAoMXBLEvrEUFdLSKBwaUbjsMtIHuZ\n" - "=vKpv\n" - "-----END PGP SIGNATURE-----\n" + "specific functions.\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: signature.asc\n" + "Type: application/pgp-signature\n" + "Size: 181 bytes\n" + "Desc: This is a digitally signed message part\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170222/80832c73/attachment.sig> -8d88694154ea30ff95f3df26eb5c18e86557c0dadc956fc0e716588f456de6de +bf835a230b43b1532a4b3d55be622e1e201ec320738b21fb37266c4fd348bd0b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.