From: Joe Perches <joe@perches.com>
To: Man Choy <manchoyy@gmail.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Walt Feasel <waltfeasel@gmail.com>,
Amitoj Kaur Chawla <amitoj1606@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Katie Dunne <kdunne@mail.ccsf.edu>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: synth: Fix checkpatch warning
Date: Thu, 23 Feb 2017 05:34:15 -0800 [thread overview]
Message-ID: <1487856855.14159.26.camel@perches.com> (raw)
In-Reply-To: <1487855731-18879-1-git-send-email-manchoyy@gmail.com>
On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
> if (!spk_quiet_boot)
> synth_printf("%s found\n", synth->long_name);
> if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> - &synth->attributes) < 0)
> + &synth->attributes) < 0)
Better would be
if (synth->attributes.name &&
sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
next prev parent reply other threads:[~2017-02-23 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 13:15 [PATCH] staging: speakup: synth: Fix checkpatch warning Man Choy
2017-02-23 13:34 ` Joe Perches [this message]
2017-02-23 14:28 ` Man Choy
-- strict thread matches above, loose matches on Subject: below --
2017-02-23 15:35 [PATCH] Staging: " Man Choy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487856855.14159.26.camel@perches.com \
--to=joe@perches.com \
--cc=amitoj1606@gmail.com \
--cc=chris@the-brannons.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kdunne@mail.ccsf.edu \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=manchoyy@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
--cc=waltfeasel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.