From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vTwBV1ykhzDqPG for ; Fri, 24 Feb 2017 13:33:06 +1100 (AEDT) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vTwBT49hmz9s7M for ; Fri, 24 Feb 2017 13:33:05 +1100 (AEDT) Message-ID: <1487903570.23576.252.camel@kernel.crashing.org> Subject: Re: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge From: Benjamin Herrenschmidt To: Joel Stanley Cc: dri-devel@lists.freedesktop.org, linuxppc-dev@ozlabs.org, airlied@redhat.com, "Y . C . Chen" , eich@suse.come Date: Fri, 24 Feb 2017 13:32:50 +1100 In-Reply-To: References: <20170223225357.9572-1-benh@kernel.crashing.org> <20170223225357.9572-2-benh@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2017-02-24 at 12:51 +1030, Joel Stanley wrote: > > Are these properties supposed to repeat the prefix "ast,ast"? > > We've chosen aspeed as the vendor prefix for Aspeed stuff. Sent my reply too early ... so yes, I can change that, our FW hasn't merge the FW side yet. I'll respin now. > > +       if (mcr_scu_strap & 0x2000) > > This bit confused me. Bit 13 of the strap (SCU70) is the SPI mode. The register is actually "MCR170: AST2000 Backward Compatible SCU Hardware Strapping Value" > > +               ref_pll = 14318; > > +       else > > +               ref_pll = 12000; > > + > > +       denum = mcr_scu_mpll & 0x1f; > > +       num = (mcr_scu_mpll & 0x3fe0) >> 5; > > +       dsel = (mcr_scu_mpll & 0xc000) >> 14; > > These calculations don't make sense for the ast2400 or ast2500. They do if you look at this: MCR120: AST2000 Backward Compatible SCU MPLL Parameter It's not the SCU version of the register it's the MCU "copy" of it that maintains some kind of legacy layout. Hence "mcr_scu" prefix not "scu". > > +       switch (dsel) { > > +       case 3: > > +               div = 0x4; > > +               break; > > +       case 2: > > +       case 1: > > +               div = 0x2; > > +               break; > > +       default: > > +               div = 0x1; > > +               break; > >         } > > +       ast->mclk = ref_pll * (num + 2) / (denum + 2) * (div * > > 1000); > >         return 0; > >  } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge Date: Fri, 24 Feb 2017 13:32:50 +1100 Message-ID: <1487903570.23576.252.camel@kernel.crashing.org> References: <20170223225357.9572-1-benh@kernel.crashing.org> <20170223225357.9572-2-benh@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EB516E0CE for ; Fri, 24 Feb 2017 02:33:02 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joel Stanley Cc: linuxppc-dev@ozlabs.org, eich@suse.come, dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE3LTAyLTI0IGF0IDEyOjUxICsxMDMwLCBKb2VsIFN0YW5sZXkgd3JvdGU6Cj4g Cj4gQXJlIHRoZXNlIHByb3BlcnRpZXMgc3VwcG9zZWQgdG8gcmVwZWF0IHRoZSBwcmVmaXggImFz dCxhc3QiPwo+IAo+IFdlJ3ZlIGNob3NlbiBhc3BlZWQgYXMgdGhlIHZlbmRvciBwcmVmaXggZm9y IEFzcGVlZCBzdHVmZi4KClNlbnQgbXkgcmVwbHkgdG9vIGVhcmx5IC4uLiBzbyB5ZXMsIEkgY2Fu IGNoYW5nZSB0aGF0LCBvdXIgRlcgaGFzbid0Cm1lcmdlIHRoZSBGVyBzaWRlIHlldC4gSSdsbCBy ZXNwaW4gbm93LgoKPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChtY3Jfc2N1X3N0cmFwICYgMHgyMDAw KQo+IAo+IFRoaXMgYml0IGNvbmZ1c2VkIG1lLiBCaXQgMTMgb2YgdGhlIHN0cmFwIChTQ1U3MCkg aXMgdGhlIFNQSSBtb2RlLgoKVGhlIHJlZ2lzdGVyIGlzIGFjdHVhbGx5ICJNQ1IxNzA6IEFTVDIw MDAgQmFja3dhcmQgQ29tcGF0aWJsZSBTQ1UKSGFyZHdhcmUgU3RyYXBwaW5nIFZhbHVlIgoKPiA+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZWZfcGxsID0gMTQzMTg7Cj4gPiArwqDC oMKgwqDCoMKgwqBlbHNlCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmVmX3Bs bCA9IDEyMDAwOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgZGVudW0gPSBtY3Jfc2N1X21wbGwg JiAweDFmOwo+ID4gK8KgwqDCoMKgwqDCoMKgbnVtID0gKG1jcl9zY3VfbXBsbCAmIDB4M2ZlMCkg Pj4gNTsKPiA+ICvCoMKgwqDCoMKgwqDCoGRzZWwgPSAobWNyX3NjdV9tcGxsICYgMHhjMDAwKSA+ PiAxNDsKPiAKPiBUaGVzZSBjYWxjdWxhdGlvbnMgZG9uJ3QgbWFrZSBzZW5zZSBmb3IgdGhlIGFz dDI0MDAgb3IgYXN0MjUwMC4KClRoZXkgZG8gaWYgeW91IGxvb2sgYXQgdGhpczoKCk1DUjEyMDog QVNUMjAwMCBCYWNrd2FyZCBDb21wYXRpYmxlIFNDVSBNUExMIFBhcmFtZXRlcgoKSXQncyBub3Qg dGhlIFNDVSB2ZXJzaW9uIG9mIHRoZSByZWdpc3RlciBpdCdzIHRoZSBNQ1UgImNvcHkiIG9mIGl0 CnRoYXQgbWFpbnRhaW5zIHNvbWUga2luZCBvZiBsZWdhY3kgbGF5b3V0LiBIZW5jZSAibWNyX3Nj dSIgcHJlZml4Cm5vdCAic2N1Ii4KCj4gPiArwqDCoMKgwqDCoMKgwqBzd2l0Y2ggKGRzZWwpIHsK PiA+ICvCoMKgwqDCoMKgwqDCoGNhc2UgMzoKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqBkaXYgPSAweDQ7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJlYWs7 Cj4gPiArwqDCoMKgwqDCoMKgwqBjYXNlIDI6Cj4gPiArwqDCoMKgwqDCoMKgwqBjYXNlIDE6Cj4g PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZGl2ID0gMHgyOwo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJyZWFrOwo+ID4gK8KgwqDCoMKgwqDCoMKgZGVmYXVsdDoK PiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBkaXYgPSAweDE7Cj4gPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJlYWs7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgfQo+ID4g K8KgwqDCoMKgwqDCoMKgYXN0LT5tY2xrID0gcmVmX3BsbCAqIChudW0gKyAyKSAvIChkZW51bSAr IDIpICogKGRpdiAqCj4gPiAxMDAwKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gMDsKPiA+ IMKgfQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK