diff for duplicates of <1488014402.6461.3.camel@nxp.com> diff --git a/a/1.txt b/N1/1.txt index de524d4..bda8505 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,24 @@ -T24gRnJpLCAyMDE3LTAyLTI0IGF0IDEyOjQ0IC0wODAwLCBTdGVwaGVuIEJveWQgd3JvdGU6DQo+ -IE9uIDAyLzIwLCBMZW9uYXJkIENyZXN0ZXogd3JvdGU6DQo+ID4gU29tZSBkcml2ZXJzIHVzZSBz -cHJpbnRmIHRvIGJ1aWxkIGNsayBjb25uZWN0aW9uIGlkIG5hbWVzIGJ1dCB0aGUNCj4gPiBjbGsN -Cj4gPiBjb3JlIHdpbGwgc2F2ZSB0aG9zZSBzdHJpbmdzIGFuZCBvY2Nhc2lvbmFsbHkgcHJpbnQg -dGhlbSBiYWNrLg0KPiA+IER1cGxpY2F0ZQ0KPiA+IHRoZSBjb25faWQgc3RyaW5ncyBpbnN0ZWFk -IG9mIGZpeGluZyBhbGwgdGhlIHVzZXJzLg0KPiANCj4gR29vZCBjYXRjaC4gV2hhdCBhYm91dCBk -ZXZfaWQgdGhvdWdoPyBUaGF0IGNvdWxkIGFsc28gaGF2ZSB0aGUNCj4gc2FtZSBwcm9ibGVtIGlm -IHNvbWUgZGV2aWNlIGlzIHJlbW92ZWQgYW5kIHdlJ3JlIHN0aWxsIGhvbGRpbmcgYQ0KPiByZWZl -cmVuY2UgdG8gdGhlIGtvYmplY3QncyBuYW1lLiBUaGlzIGlzIHByb2JhYmx5IG1vcmUgcmFyZSB0 -aGFuDQo+IHdoYXQgaXMgaGFwcGVuaW5nIGhlcmUsIGJ1dCBzdGlsbCBzZWVtcyBwb3NzaWJsZSB0 -aGF0IHdlIG1pZ2h0DQo+IHRyaXAgb3ZlciB0aGF0IGxhdGVyLg0KDQpBIGRldmljZSBzaG91bGQg -bm9ybWFsbHkgZnJlZSB0aGUgY2xrcyBpdCB1c2VzIGJlZm9yZSBpdCBpcyBkZXN0cm95ZWQuDQpU -aGlzIG1lYW5zIHRoYXQgaWYgZGV2X2lkIGlzIHBvaW50aW5nIHRvIGZyZWVkIG1lbW9yeSB0aGVu -IHRoZSBjbGsNCml0c2VsZiB3YXMgcHJvYmFibHkgbGVha2VkLCByaWdodD8NCg0KVGhpcyBpcyBv -YnZpb3VzIG1pc3VzZSBvZiB0aGUgQVBJLCBub3QgbGlrZSBzcHJpbnRmLWluZyBhIGNvbl9pZCBp -biBhDQpjb21wbGV4IGRyaXZlci4gSSBkb24ndCByZWFsbHkgdGhpbmsgaXQncyB3b3J0aCBjb3B5 -aW5nIHN0cmluZ3MgZm9yIGl0Lg0KDQotLQ0KUmVnYXJkcywNCkxlb25hcmQ= +On Fri, 2017-02-24 at 12:44 -0800, Stephen Boyd wrote: +> On 02/20, Leonard Crestez wrote: +> > Some drivers use sprintf to build clk connection id names but the +> > clk +> > core will save those strings and occasionally print them back. +> > Duplicate +> > the con_id strings instead of fixing all the users. +> +> Good catch. What about dev_id though? That could also have the +> same problem if some device is removed and we're still holding a +> reference to the kobject's name. This is probably more rare than +> what is happening here, but still seems possible that we might +> trip over that later. + +A device should normally free the clks it uses before it is destroyed. +This means that if dev_id is pointing to freed memory then the clk +itself was probably leaked, right? + +This is obvious misuse of the API, not like sprintf-ing a con_id in a +complex driver. I don't really think it's worth copying strings for it. + +-- +Regards, +Leonard diff --git a/a/content_digest b/N1/content_digest index 8776291..e435cdc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,22 +9,29 @@ " linux-clk@vger.kernel.org <linux-clk@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE3LTAyLTI0IGF0IDEyOjQ0IC0wODAwLCBTdGVwaGVuIEJveWQgd3JvdGU6DQo+\n" - "IE9uIDAyLzIwLCBMZW9uYXJkIENyZXN0ZXogd3JvdGU6DQo+ID4gU29tZSBkcml2ZXJzIHVzZSBz\n" - "cHJpbnRmIHRvIGJ1aWxkIGNsayBjb25uZWN0aW9uIGlkIG5hbWVzIGJ1dCB0aGUNCj4gPiBjbGsN\n" - "Cj4gPiBjb3JlIHdpbGwgc2F2ZSB0aG9zZSBzdHJpbmdzIGFuZCBvY2Nhc2lvbmFsbHkgcHJpbnQg\n" - "dGhlbSBiYWNrLg0KPiA+IER1cGxpY2F0ZQ0KPiA+IHRoZSBjb25faWQgc3RyaW5ncyBpbnN0ZWFk\n" - "IG9mIGZpeGluZyBhbGwgdGhlIHVzZXJzLg0KPiANCj4gR29vZCBjYXRjaC4gV2hhdCBhYm91dCBk\n" - "ZXZfaWQgdGhvdWdoPyBUaGF0IGNvdWxkIGFsc28gaGF2ZSB0aGUNCj4gc2FtZSBwcm9ibGVtIGlm\n" - "IHNvbWUgZGV2aWNlIGlzIHJlbW92ZWQgYW5kIHdlJ3JlIHN0aWxsIGhvbGRpbmcgYQ0KPiByZWZl\n" - "cmVuY2UgdG8gdGhlIGtvYmplY3QncyBuYW1lLiBUaGlzIGlzIHByb2JhYmx5IG1vcmUgcmFyZSB0\n" - "aGFuDQo+IHdoYXQgaXMgaGFwcGVuaW5nIGhlcmUsIGJ1dCBzdGlsbCBzZWVtcyBwb3NzaWJsZSB0\n" - "aGF0IHdlIG1pZ2h0DQo+IHRyaXAgb3ZlciB0aGF0IGxhdGVyLg0KDQpBIGRldmljZSBzaG91bGQg\n" - "bm9ybWFsbHkgZnJlZSB0aGUgY2xrcyBpdCB1c2VzIGJlZm9yZSBpdCBpcyBkZXN0cm95ZWQuDQpU\n" - "aGlzIG1lYW5zIHRoYXQgaWYgZGV2X2lkIGlzIHBvaW50aW5nIHRvIGZyZWVkIG1lbW9yeSB0aGVu\n" - "IHRoZSBjbGsNCml0c2VsZiB3YXMgcHJvYmFibHkgbGVha2VkLCByaWdodD8NCg0KVGhpcyBpcyBv\n" - "YnZpb3VzIG1pc3VzZSBvZiB0aGUgQVBJLCBub3QgbGlrZSBzcHJpbnRmLWluZyBhIGNvbl9pZCBp\n" - "biBhDQpjb21wbGV4IGRyaXZlci4gSSBkb24ndCByZWFsbHkgdGhpbmsgaXQncyB3b3J0aCBjb3B5\n" - aW5nIHN0cmluZ3MgZm9yIGl0Lg0KDQotLQ0KUmVnYXJkcywNCkxlb25hcmQ= + "On Fri, 2017-02-24 at 12:44 -0800, Stephen Boyd wrote:\n" + "> On 02/20, Leonard Crestez wrote:\n" + "> > Some drivers use sprintf to build clk connection id names but the\n" + "> > clk\n" + "> > core will save those strings and occasionally print them back.\n" + "> > Duplicate\n" + "> > the con_id strings instead of fixing all the users.\n" + "> \n" + "> Good catch. What about dev_id though? That could also have the\n" + "> same problem if some device is removed and we're still holding a\n" + "> reference to the kobject's name. This is probably more rare than\n" + "> what is happening here, but still seems possible that we might\n" + "> trip over that later.\n" + "\n" + "A device should normally free the clks it uses before it is destroyed.\n" + "This means that if dev_id is pointing to freed memory then the clk\n" + "itself was probably leaked, right?\n" + "\n" + "This is obvious misuse of the API, not like sprintf-ing a con_id in a\n" + "complex driver. I don't really think it's worth copying strings for it.\n" + "\n" + "--\n" + "Regards,\n" + Leonard -61b60033ca1f1967f421e385a6c51314f171e0a0a8c25da17b8d1715c1389157 +01c3610d82d2798cab6d83ec4454f92097b8fa61e953b6ee08a40b15265c5218
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.