From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"jth@kernel.org" <jth@kernel.org>
Subject: Re: [PATCHv2 4/5] scsi: make scsi_eh_scmd_add() always succeed
Date: Mon, 27 Feb 2017 22:27:44 +0000 [thread overview]
Message-ID: <1488234448.2597.9.camel@sandisk.com> (raw)
In-Reply-To: <1487779650-1338-5-git-send-email-hare@suse.de>
On Wed, 2017-02-22 at 17:07 +0100, Hannes Reinecke wrote:
> spin_lock_irqsave(shost->host_lock, flags);
> + WARN_ON(shost->shost_state != SHOST_RUNNING &&
> + shost->shost_state != SHOST_CANCEL &&
> + shost->shost_state != SHOST_RECOVERY &&
> + shost->shost_state != SHOST_CANCEL_RECOVERY);
> if (scsi_host_set_state(shost, SHOST_RECOVERY))
> - if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY))
> - goto out_unlock;
> + scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY);
Please issue a warning if the second scsi_host_set_state() fails. And once
that failure triggers a warning, I don't think we need the newly added
WARN_ON() statement anymore. Something else that surprised me is that you
consistently use WARN_ON() instead of WARN_ON_ONCE() in this patch?
Otherwise this patch looks fine to me.
Bart.
next prev parent reply other threads:[~2017-02-27 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:07 [PATCHv2 0/5] SCSI EH cleanup Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 1/5] libsas: allow async aborts Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 2/5] scsi: make eh_eflags persistent Hannes Reinecke
2017-02-27 22:15 ` Bart Van Assche
2017-02-28 12:09 ` Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 3/5] scsi_error: do not escalate failed EH command Hannes Reinecke
2017-02-27 22:21 ` Bart Van Assche
2017-02-22 16:07 ` [PATCHv2 4/5] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2017-02-27 22:27 ` Bart Van Assche [this message]
2017-02-28 12:16 ` Hannes Reinecke
2017-02-22 16:07 ` [PATCHv2 5/5] scsi: make asynchronous aborts mandatory Hannes Reinecke
2017-02-27 22:53 ` Bart Van Assche
2017-02-22 19:44 ` [PATCHv2 0/5] SCSI EH cleanup Bart Van Assche
2017-02-23 7:27 ` Hannes Reinecke
2017-02-22 21:21 ` Bart Van Assche
2017-02-23 7:35 ` Hannes Reinecke
2017-02-24 4:01 ` Bart Van Assche
2017-02-24 7:15 ` Hannes Reinecke
2017-02-27 22:10 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488234448.2597.9.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=jth@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.