All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org
Cc: patrik.flykt@linux.intel.com, stefan@osg.samsung.com,
	aar@pengutronix.de, linux-wpan@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH v5 6/6] 6lowpan: Fix IID format for Bluetooth
Date: Tue, 28 Feb 2017 11:13:28 +0200	[thread overview]
Message-ID: <1488273208.3344.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170224121440.32269-7-luiz.dentz@gmail.com>

Hi Luiz,

On Fri, 2017-02-24 at 14:14 +0200, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Accourding to RFC 7668 U/L bit shall not be used:
> 
> https://wiki.tools.ietf.org/html/rfc7668#section-3.2.2 [Page 10]:
> 
>    In the figure, letter 'b' represents a bit from the
>    Bluetooth device address, copied as is without any changes on any
>    bit.  This means that no bit in the IID indicates whether the
>    underlying Bluetooth device address is public or random.
> 
>    |0              1|1              3|3              4|4             
>  6|
>    |0              5|6              1|2              7|8             
>  3|
>    +----------------+----------------+----------------+------------
> ----+
>    |bbbbbbbbbbbbbbbb|bbbbbbbb11111111|11111110bbbbbbbb|bbbbbbbbbbbbbb
> bb|
>    +----------------+----------------+----------------+------------
> ----+
> 
> Because of this the code cannot figure out the address type from the
> IP
> address anymore thus it makes no sense to use peer_lookup_ba as it
> needs
> the peer address type.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>  include/net/6lowpan.h   |  4 ---
> 

Looks good.

Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>


Cheers,
Jukka

      parent reply	other threads:[~2017-02-28  9:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 12:14 [PATCH v5 0/6] Bluetooth: 6LoWPAN: Fix lladdr length Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 1/6] bluetooth: Set 6 byte device addresses Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 2/6] 6lowpan: Set MAC address length according to LOWPAN_LLTYPE Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 3/6] 6lowpan: iphc: override l2 packet information Luiz Augusto von Dentz
2017-02-24 12:14   ` Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 4/6] ipv6: addrconf: fix 48 bit 6lowpan autoconfiguration Luiz Augusto von Dentz
2017-02-24 12:14   ` Luiz Augusto von Dentz
2017-02-26  6:38   ` Alexander Aring
2017-03-01 11:09     ` Luiz Augusto von Dentz
2017-02-24 12:14 ` [PATCH v5 5/6] 6lowpan: Use netdev addr_len to determine lladdr len Luiz Augusto von Dentz
2017-02-27  7:13   ` Alexander Aring
2017-02-27  7:13     ` Alexander Aring
2017-02-27  7:24     ` Alexander Aring
2017-02-27  7:24       ` Alexander Aring
2017-02-24 12:14 ` [PATCH v5 6/6] 6lowpan: Fix IID format for Bluetooth Luiz Augusto von Dentz
2017-02-24 14:00   ` Stefan Schmidt
2017-02-24 14:00     ` Stefan Schmidt
2017-02-26  6:05   ` Alexander Aring
2017-02-26  6:05     ` Alexander Aring
2017-02-26  6:25     ` Alexander Aring
2017-02-26  6:25       ` Alexander Aring
2017-02-28  9:13   ` Jukka Rissanen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488273208.3344.1.camel@linux.intel.com \
    --to=jukka.rissanen@linux.intel.com \
    --cc=aar@pengutronix.de \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=patrik.flykt@linux.intel.com \
    --cc=stefan@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.