All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use BUILD_BUG_ON to detected missing engine definitions
Date: Tue, 28 Feb 2017 16:31:29 +0200	[thread overview]
Message-ID: <1488292289.3403.20.camel@linux.intel.com> (raw)
In-Reply-To: <a92060d0-91f0-3f67-f52f-965575bcdac5@linux.intel.com>

On ti, 2017-02-28 at 14:21 +0000, Tvrtko Ursulin wrote:
> The caller of this function iterates 0..ARRAY_SIZE(intel_engines) and 
> also filters with HAS_ENGINE before calling it so not sure this is 
> absolutely needed. Maybe instead:
> 
> GEM_BUG_ON(id >= ARRAY_SIZE(dev_priv->engine));

I think that's even better.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-28 14:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 14:00 [PATCH] drm/i915: Use BUILD_BUG_ON to detected missing engine definitions Michal Wajdeczko
2017-02-28 14:07 ` Joonas Lahtinen
2017-02-28 14:12 ` Chris Wilson
2017-02-28 14:18   ` Chris Wilson
2017-02-28 14:29   ` Michal Wajdeczko
2017-02-28 14:21 ` Tvrtko Ursulin
2017-02-28 14:31   ` Joonas Lahtinen [this message]
2017-02-28 14:52   ` Michal Wajdeczko
2017-02-28 15:04     ` Tvrtko Ursulin
2017-02-28 15:08     ` Chris Wilson
2017-02-28 16:36       ` Michal Wajdeczko
2017-02-28 17:53 ` ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488292289.3403.20.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.