Re: [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

On Tue, 2017-02-28 at 13:55 +0000, Andrew Cooper wrote:
> On 28/02/17 11:52, Dario Faggioli wrote:
> > 
> > +static inline bool_t same_node(unsigned int cpua, unsigned int
> > cpub)
> 
> s/bool_t/bool/g
> 
Oh.. Yes, you're right. Sorry!

> > +
> > +    if ( unlikely(tb_init_done) )
> > +    {
> > +        struct {
> > +            unsigned rqi:16, max_weight:16;
> 
> More commonly known as uint16_t :)
> 
Yeah, I know. :-)

But tracing code in Credit2 is done like above everywhere, and while I
see and agree on your point, I feel more comfortable in following suit.

And anyway, I'm considering a follow-up cleanup where I'll get rid of
all these 'if (tracing){...}' blocks, and substitute them with inline
functions, and I can certainly do the type change there as well.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel