Re: [PATCH v1] ASoC: Intel: bdw-rt5677: Use devm_gpiod_get()

[Liam Girdwood <liam.r.girdwood@intel.com>]

On Mon, 2017-02-20 at 19:46 +0200, Andy Shevchenko wrote:
> Since index is always 0 replace devm_gpiod_get_index() by devm_gpiod_get()
> and apply proper flags.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  sound/soc/intel/boards/bdw-rt5677.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/bdw-rt5677.c b/sound/soc/intel/boards/bdw-rt5677.c
> index ab383af14ca2..8284a40829be 100644
> --- a/sound/soc/intel/boards/bdw-rt5677.c
> +++ b/sound/soc/intel/boards/bdw-rt5677.c
> @@ -205,13 +205,12 @@ static int bdw_rt5677_init(struct snd_soc_pcm_runtime *rtd)
>  			RT5677_CLK_SEL_I2S1_ASRC);
>  
>  	/* Request rt5677 GPIO for headphone amp control */
> -	bdw_rt5677->gpio_hp_en = devm_gpiod_get_index(codec->dev,
> -			"headphone-enable", 0, 0);
> +	bdw_rt5677->gpio_hp_en = devm_gpiod_get(codec->dev, "headphone-enable",
> +						GPIOD_OUT_LOW);
>  	if (IS_ERR(bdw_rt5677->gpio_hp_en)) {
>  		dev_err(codec->dev, "Can't find HP_AMP_SHDN_L gpio\n");
>  		return PTR_ERR(bdw_rt5677->gpio_hp_en);
>  	}
> -	gpiod_direction_output(bdw_rt5677->gpio_hp_en, 0);
>  
>  	/* Create and initialize headphone jack */
>  	if (!snd_soc_card_jack_new(rtd->card, "Headphone Jack",

Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.