From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v5] drm/i915/guc: Extract param logic form guc_init_fw()
Date: Wed, 01 Mar 2017 14:18:01 +0200 [thread overview]
Message-ID: <1488370681.3122.0.camel@linux.intel.com> (raw)
In-Reply-To: <20170227125045.13925-1-arkadiusz.hiler@intel.com>
On ma, 2017-02-27 at 13:50 +0100, Arkadiusz Hiler wrote:
> Let intel_guc_init_fw() focus on determining and fetching the correct
> firmware.
>
> This patch introduces intel_uc_sanitize_options() that is called from
> intel_sanitize_options().
>
> Then, if we have GuC, we can call intel_guc_init_fw() conditionally
> and we do not have to do the internal checks.
>
> v2: fix comment, notify when nuking GuC explicitly enabled (M. Wajdeczko)
> v3: fix comment again, change the nuke message (M. Wajdeczko)
> v4: update title to reflect new function name + rebase
> v5: text && remove 2 uneccessary checks (M. Wajeczko)
>
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-01 12:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 15:39 [PATCH v5 00/10] GuC Scrub vol. 1 Arkadiusz Hiler
2017-02-24 15:39 ` [PATCH 01/10] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw() Arkadiusz Hiler
2017-02-24 15:39 ` [PATCH 02/10] drm/i915/uc: Drop superfluous externs in intel_uc.h Arkadiusz Hiler
2017-02-24 15:39 ` [PATCH 03/10] drm/i915/huc: Add huc_to_i915 Arkadiusz Hiler
2017-02-24 15:39 ` [PATCH 04/10] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c Arkadiusz Hiler
2017-02-24 16:28 ` Michal Wajdeczko
2017-02-27 12:36 ` [PATCH v2] " Arkadiusz Hiler
2017-02-24 15:39 ` [PATCH 05/10] drm/i915/uc: Introduce intel_uc_init_fw() Arkadiusz Hiler
2017-02-24 16:39 ` Michal Wajdeczko
2017-02-27 12:09 ` Joonas Lahtinen
2017-02-24 15:40 ` [PATCH 06/10] drm/i915/guc: Extract param logic form guc_init_fw() Arkadiusz Hiler
2017-02-24 16:55 ` Michal Wajdeczko
2017-02-27 12:50 ` [PATCH v5] " Arkadiusz Hiler
2017-03-01 12:18 ` Joonas Lahtinen [this message]
2017-02-24 15:40 ` [PATCH 07/10] drm/i915/guc: Simplify intel_guc_init_hw() Arkadiusz Hiler
2017-02-24 17:26 ` Michal Wajdeczko
2017-02-27 15:48 ` Arkadiusz Hiler
2017-02-24 15:40 ` [PATCH 08/10] drm/i915/uc: Simplify firmware path handling Arkadiusz Hiler
2017-02-24 17:46 ` Michal Wajdeczko
2017-02-24 15:40 ` [PATCH 09/10] drm/i915/uc: Separate firmware selection and preparation Arkadiusz Hiler
2017-02-24 18:29 ` Michal Wajdeczko
2017-03-02 11:53 ` Arkadiusz Hiler
2017-02-27 12:23 ` Joonas Lahtinen
2017-02-24 15:40 ` [PATCH 10/10] drm/i915/uc: Add params for specifying firmware Arkadiusz Hiler
2017-02-24 18:44 ` Michal Wajdeczko
2017-02-27 12:39 ` Joonas Lahtinen
2017-02-27 13:30 ` Jani Nikula
2017-02-24 16:02 ` ✗ Fi.CI.BAT: failure for GuC Scrub vol. 1 (rev5) Patchwork
2017-02-27 14:02 ` ✗ Fi.CI.BAT: failure for GuC Scrub vol. 1 (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488370681.3122.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.