Re: [PATCH v4 5/7] xen: credit2: group the runq manipulating functions.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1138 bytes --]

On Wed, 2017-03-01 at 16:41 +0000, George Dunlap wrote:
> On 01/03/17 14:53, Dario Faggioli wrote:
> > @@ -590,7 +590,7 @@ static s_time_t c2t(struct
> > csched2_runqueue_data *rqd, s_time_t credit, struct c
> >  }
> >  
> >  /*
> > - * Runqueue related code
> > + * Runqueue related code.
> 
> You realize we changed CODING_STYLE to not require a full stop if
> there
> was only one line?  This isn't a complete sentence so I would leave
> the
> full stop out.
> 
Now that you mention it, yes, I remember the thread. But my
understanding of the results of such thread was actually a bit
different from what you say and explain above.

So...

> But that's just for future reference -- I don't care enough about
> this
> in general, I just wanted to raise it to your attention.  :-)
> 
...that's been useful and much appreciated. Thanks!

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel