diff for duplicates of <1488454082.2420.3.camel@baylibre.com> diff --git a/a/1.txt b/N1/1.txt index 7f2853c..a3808ad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,84 +1,38 @@ -On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote: -> Hi Stephen, -> -> On 03/01/2017 08:11 PM, Stephen Boyd wrote: -> > On 03/01, Neil Armstrong wrote: -> > > diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c -> > > index a52063f..31f6090 100644 -> > > --- a/drivers/clk/meson/gxbb.c -> > > +++ b/drivers/clk/meson/gxbb.c -> > > @@ -634,6 +634,131 @@ -> > > ? }, -> > > ?}; -> > > ? -> > > +/* -> > > + * The MALI IP is clocked by two identical clocks (mali_0 and -> > > mali_1) -> > > + * muxed by a glitch-free switch. -> > > + */ -> > > + -> > > +static u32 mux_table_mali_0_1[] = {0, 1, 2, 3, 4, 5, 6, 7}; -> > > +const char *gxbb_mali_0_1_parent_names[] = { -> > -> > static? -> -> Will do ! -> -> > -> > > + "xtal", "gp0_pll", "mpll2", "mpll1", "fclk_div7", -> > > + "fclk_div4", "fclk_div3", "fclk_div5" -> > > +}; -> > > + -> > -> > [..] -> > > + .reg = (void *)HHI_MALI_CLK_CNTL, -> > > + .bit_idx = 24, -> > > + .lock = &clk_lock, -> > > + .hw.init = &(struct clk_init_data){ -> > > + .name = "mali_1", -> > > + .ops = &clk_gate_ops, -> > > + .parent_names = (const char *[]){ "mali_1_div" -> > > }, -> > > + .num_parents = 1, -> > > + .flags = (CLK_SET_RATE_PARENT | -> > > CLK_IGNORE_UNUSED), -> > > + }, -> > > +}; -> > > + -> > > +static u32 mux_table_mali[] = {0, 1}; -> > > +const char *gxbb_mali_parent_names[] = { -> > -> > static? -> > -> > > + "mali_0", "mali_1" -> > > +}; -> > -> > [...] -> > > ?static struct clk_mux *gxbb_clk_muxes[] = { -> > > ? &gxbb_mpeg_clk_sel, -> > > ? &gxbb_sar_adc_clk_sel, -> > > + &gxbb_mali_0_sel, -> > > + &gxbb_mali_1_sel, -> > > + &gxbb_mali, -> > > ?}; -> > > ? -> > > ?static struct clk_divider *gxbb_clk_dividers[] = { -> > -> > Can these arrays be const? If so, please do that in a separate -> > patch. -> -> Hmm, these were introduced by jerome, he should update them -> accordingly. -> - -Will do - -> > > ? &gxbb_mpeg_clk_div, -> > > ? &gxbb_sar_adc_clk_div, -> > > + &gxbb_mali_0_div, -> > > + &gxbb_mali_1_div, -> > > ?}; -> -> -> Thanks, -> Neil +T24gVGh1LCAyMDE3LTAzLTAyIGF0IDEyOjA3ICswMTAwLCBOZWlsIEFybXN0cm9uZyB3cm90ZToK +PiBIaSBTdGVwaGVuLAo+IAo+IE9uIDAzLzAxLzIwMTcgMDg6MTEgUE0sIFN0ZXBoZW4gQm95ZCB3 +cm90ZToKPiA+IE9uIDAzLzAxLCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+ID4gZGlmZiAtLWdp +dCBhL2RyaXZlcnMvY2xrL21lc29uL2d4YmIuYyBiL2RyaXZlcnMvY2xrL21lc29uL2d4YmIuYwo+ +ID4gPiBpbmRleCBhNTIwNjNmLi4zMWY2MDkwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2Ns +ay9tZXNvbi9neGJiLmMKPiA+ID4gKysrIGIvZHJpdmVycy9jbGsvbWVzb24vZ3hiYi5jCj4gPiA+ +IEBAIC02MzQsNiArNjM0LDEzMSBAQAo+ID4gPiDCoAl9LAo+ID4gPiDCoH07Cj4gPiA+IMKgCj4g +PiA+ICsvKgo+ID4gPiArICogVGhlIE1BTEkgSVAgaXMgY2xvY2tlZCBieSB0d28gaWRlbnRpY2Fs +IGNsb2NrcyAobWFsaV8wIGFuZAo+ID4gPiBtYWxpXzEpCj4gPiA+ICsgKiBtdXhlZCBieSBhIGds +aXRjaC1mcmVlIHN3aXRjaC4KPiA+ID4gKyAqLwo+ID4gPiArCj4gPiA+ICtzdGF0aWMgdTMyIG11 +eF90YWJsZV9tYWxpXzBfMVtdID0gezAsIDEsIDIsIDMsIDQsIDUsIDYsIDd9Owo+ID4gPiArY29u +c3QgY2hhciAqZ3hiYl9tYWxpXzBfMV9wYXJlbnRfbmFtZXNbXSA9IHsKPiA+IAo+ID4gc3RhdGlj +Pwo+IAo+IFdpbGwgZG8gIQo+IAo+ID4gCj4gPiA+ICsJInh0YWwiLCAiZ3AwX3BsbCIsICJtcGxs +MiIsICJtcGxsMSIsICJmY2xrX2RpdjciLAo+ID4gPiArCSJmY2xrX2RpdjQiLCAiZmNsa19kaXYz +IiwgImZjbGtfZGl2NSIKPiA+ID4gK307Cj4gPiA+ICsKPiA+IAo+ID4gWy4uXQo+ID4gPiArCS5y +ZWcgPSAodm9pZCAqKUhISV9NQUxJX0NMS19DTlRMLAo+ID4gPiArCS5iaXRfaWR4ID0gMjQsCj4g +PiA+ICsJLmxvY2sgPSAmY2xrX2xvY2ssCj4gPiA+ICsJLmh3LmluaXQgPSAmKHN0cnVjdCBjbGtf +aW5pdF9kYXRhKXsKPiA+ID4gKwkJLm5hbWUgPSAibWFsaV8xIiwKPiA+ID4gKwkJLm9wcyA9ICZj +bGtfZ2F0ZV9vcHMsCj4gPiA+ICsJCS5wYXJlbnRfbmFtZXMgPSAoY29uc3QgY2hhciAqW10peyAi +bWFsaV8xX2RpdiIKPiA+ID4gfSwKPiA+ID4gKwkJLm51bV9wYXJlbnRzID0gMSwKPiA+ID4gKwkJ +LmZsYWdzID0gKENMS19TRVRfUkFURV9QQVJFTlQgfAo+ID4gPiBDTEtfSUdOT1JFX1VOVVNFRCks +Cj4gPiA+ICsJfSwKPiA+ID4gK307Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB1MzIgbXV4X3RhYmxl +X21hbGlbXSA9IHswLCAxfTsKPiA+ID4gK2NvbnN0IGNoYXIgKmd4YmJfbWFsaV9wYXJlbnRfbmFt +ZXNbXSA9IHsKPiA+IAo+ID4gc3RhdGljPwo+ID4gCj4gPiA+ICsJIm1hbGlfMCIsICJtYWxpXzEi +Cj4gPiA+ICt9Owo+ID4gCj4gPiBbLi4uXQo+ID4gPiDCoHN0YXRpYyBzdHJ1Y3QgY2xrX211eCAq +Z3hiYl9jbGtfbXV4ZXNbXSA9IHsKPiA+ID4gwqAJJmd4YmJfbXBlZ19jbGtfc2VsLAo+ID4gPiDC +oAkmZ3hiYl9zYXJfYWRjX2Nsa19zZWwsCj4gPiA+ICsJJmd4YmJfbWFsaV8wX3NlbCwKPiA+ID4g +KwkmZ3hiYl9tYWxpXzFfc2VsLAo+ID4gPiArCSZneGJiX21hbGksCj4gPiA+IMKgfTsKPiA+ID4g +wqAKPiA+ID4gwqBzdGF0aWMgc3RydWN0IGNsa19kaXZpZGVyICpneGJiX2Nsa19kaXZpZGVyc1td +ID0gewo+ID4gCj4gPiBDYW4gdGhlc2UgYXJyYXlzIGJlIGNvbnN0PyBJZiBzbywgcGxlYXNlIGRv +IHRoYXQgaW4gYSBzZXBhcmF0ZQo+ID4gcGF0Y2guCj4gCj4gSG1tLCB0aGVzZSB3ZXJlIGludHJv +ZHVjZWQgYnkgamVyb21lLCBoZSBzaG91bGQgdXBkYXRlIHRoZW0KPiBhY2NvcmRpbmdseS4KPiAK +CldpbGwgZG8KCj4gPiA+IMKgCSZneGJiX21wZWdfY2xrX2RpdiwKPiA+ID4gwqAJJmd4YmJfc2Fy +X2FkY19jbGtfZGl2LAo+ID4gPiArCSZneGJiX21hbGlfMF9kaXYsCj4gPiA+ICsJJmd4YmJfbWFs +aV8xX2RpdiwKPiA+ID4gwqB9Owo+IAo+IAo+IFRoYW5rcywKPiBOZWlsCgpfX19fX19fX19fX19f +X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcg +bGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh +ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== diff --git a/a/content_digest b/N1/content_digest index 378a4dd..baa8f05 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,95 +2,56 @@ "ref\01488365164-22861-3-git-send-email-narmstrong@baylibre.com\0" "ref\020170301191119.GR25384@codeaurora.org\0" "ref\06cd2e42d-6169-a2f0-db33-e13ca1619a41@baylibre.com\0" - "From\0jbrunet@baylibre.com (Jerome Brunet)\0" - "Subject\0[PATCH v2 2/3] clk: meson-gxbb: Add MALI clocks\0" + "From\0Jerome Brunet <jbrunet@baylibre.com>\0" + "Subject\0Re: [PATCH v2 2/3] clk: meson-gxbb: Add MALI clocks\0" "Date\0Thu, 02 Mar 2017 12:28:02 +0100\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0Neil Armstrong <narmstrong@baylibre.com>" + " Stephen Boyd <sboyd@codeaurora.org>\0" + "Cc\0khilman@baylibre.com" + linux-kernel@vger.kernel.org + carlo@caione.org + linux-amlogic@lists.infradead.org + linux-clk@vger.kernel.org + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote:\n" - "> Hi Stephen,\n" - "> \n" - "> On 03/01/2017 08:11 PM, Stephen Boyd wrote:\n" - "> > On 03/01, Neil Armstrong wrote:\n" - "> > > diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c\n" - "> > > index a52063f..31f6090 100644\n" - "> > > --- a/drivers/clk/meson/gxbb.c\n" - "> > > +++ b/drivers/clk/meson/gxbb.c\n" - "> > > @@ -634,6 +634,131 @@\n" - "> > > ?\t},\n" - "> > > ?};\n" - "> > > ?\n" - "> > > +/*\n" - "> > > + * The MALI IP is clocked by two identical clocks (mali_0 and\n" - "> > > mali_1)\n" - "> > > + * muxed by a glitch-free switch.\n" - "> > > + */\n" - "> > > +\n" - "> > > +static u32 mux_table_mali_0_1[] = {0, 1, 2, 3, 4, 5, 6, 7};\n" - "> > > +const char *gxbb_mali_0_1_parent_names[] = {\n" - "> > \n" - "> > static?\n" - "> \n" - "> Will do !\n" - "> \n" - "> > \n" - "> > > +\t\"xtal\", \"gp0_pll\", \"mpll2\", \"mpll1\", \"fclk_div7\",\n" - "> > > +\t\"fclk_div4\", \"fclk_div3\", \"fclk_div5\"\n" - "> > > +};\n" - "> > > +\n" - "> > \n" - "> > [..]\n" - "> > > +\t.reg = (void *)HHI_MALI_CLK_CNTL,\n" - "> > > +\t.bit_idx = 24,\n" - "> > > +\t.lock = &clk_lock,\n" - "> > > +\t.hw.init = &(struct clk_init_data){\n" - "> > > +\t\t.name = \"mali_1\",\n" - "> > > +\t\t.ops = &clk_gate_ops,\n" - "> > > +\t\t.parent_names = (const char *[]){ \"mali_1_div\"\n" - "> > > },\n" - "> > > +\t\t.num_parents = 1,\n" - "> > > +\t\t.flags = (CLK_SET_RATE_PARENT |\n" - "> > > CLK_IGNORE_UNUSED),\n" - "> > > +\t},\n" - "> > > +};\n" - "> > > +\n" - "> > > +static u32 mux_table_mali[] = {0, 1};\n" - "> > > +const char *gxbb_mali_parent_names[] = {\n" - "> > \n" - "> > static?\n" - "> > \n" - "> > > +\t\"mali_0\", \"mali_1\"\n" - "> > > +};\n" - "> > \n" - "> > [...]\n" - "> > > ?static struct clk_mux *gxbb_clk_muxes[] = {\n" - "> > > ?\t&gxbb_mpeg_clk_sel,\n" - "> > > ?\t&gxbb_sar_adc_clk_sel,\n" - "> > > +\t&gxbb_mali_0_sel,\n" - "> > > +\t&gxbb_mali_1_sel,\n" - "> > > +\t&gxbb_mali,\n" - "> > > ?};\n" - "> > > ?\n" - "> > > ?static struct clk_divider *gxbb_clk_dividers[] = {\n" - "> > \n" - "> > Can these arrays be const? If so, please do that in a separate\n" - "> > patch.\n" - "> \n" - "> Hmm, these were introduced by jerome, he should update them\n" - "> accordingly.\n" - "> \n" - "\n" - "Will do\n" - "\n" - "> > > ?\t&gxbb_mpeg_clk_div,\n" - "> > > ?\t&gxbb_sar_adc_clk_div,\n" - "> > > +\t&gxbb_mali_0_div,\n" - "> > > +\t&gxbb_mali_1_div,\n" - "> > > ?};\n" - "> \n" - "> \n" - "> Thanks,\n" - > Neil + "T24gVGh1LCAyMDE3LTAzLTAyIGF0IDEyOjA3ICswMTAwLCBOZWlsIEFybXN0cm9uZyB3cm90ZToK\n" + "PiBIaSBTdGVwaGVuLAo+IAo+IE9uIDAzLzAxLzIwMTcgMDg6MTEgUE0sIFN0ZXBoZW4gQm95ZCB3\n" + "cm90ZToKPiA+IE9uIDAzLzAxLCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+ID4gZGlmZiAtLWdp\n" + "dCBhL2RyaXZlcnMvY2xrL21lc29uL2d4YmIuYyBiL2RyaXZlcnMvY2xrL21lc29uL2d4YmIuYwo+\n" + "ID4gPiBpbmRleCBhNTIwNjNmLi4zMWY2MDkwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2Ns\n" + "ay9tZXNvbi9neGJiLmMKPiA+ID4gKysrIGIvZHJpdmVycy9jbGsvbWVzb24vZ3hiYi5jCj4gPiA+\n" + "IEBAIC02MzQsNiArNjM0LDEzMSBAQAo+ID4gPiDCoAl9LAo+ID4gPiDCoH07Cj4gPiA+IMKgCj4g\n" + "PiA+ICsvKgo+ID4gPiArICogVGhlIE1BTEkgSVAgaXMgY2xvY2tlZCBieSB0d28gaWRlbnRpY2Fs\n" + "IGNsb2NrcyAobWFsaV8wIGFuZAo+ID4gPiBtYWxpXzEpCj4gPiA+ICsgKiBtdXhlZCBieSBhIGds\n" + "aXRjaC1mcmVlIHN3aXRjaC4KPiA+ID4gKyAqLwo+ID4gPiArCj4gPiA+ICtzdGF0aWMgdTMyIG11\n" + "eF90YWJsZV9tYWxpXzBfMVtdID0gezAsIDEsIDIsIDMsIDQsIDUsIDYsIDd9Owo+ID4gPiArY29u\n" + "c3QgY2hhciAqZ3hiYl9tYWxpXzBfMV9wYXJlbnRfbmFtZXNbXSA9IHsKPiA+IAo+ID4gc3RhdGlj\n" + "Pwo+IAo+IFdpbGwgZG8gIQo+IAo+ID4gCj4gPiA+ICsJInh0YWwiLCAiZ3AwX3BsbCIsICJtcGxs\n" + "MiIsICJtcGxsMSIsICJmY2xrX2RpdjciLAo+ID4gPiArCSJmY2xrX2RpdjQiLCAiZmNsa19kaXYz\n" + "IiwgImZjbGtfZGl2NSIKPiA+ID4gK307Cj4gPiA+ICsKPiA+IAo+ID4gWy4uXQo+ID4gPiArCS5y\n" + "ZWcgPSAodm9pZCAqKUhISV9NQUxJX0NMS19DTlRMLAo+ID4gPiArCS5iaXRfaWR4ID0gMjQsCj4g\n" + "PiA+ICsJLmxvY2sgPSAmY2xrX2xvY2ssCj4gPiA+ICsJLmh3LmluaXQgPSAmKHN0cnVjdCBjbGtf\n" + "aW5pdF9kYXRhKXsKPiA+ID4gKwkJLm5hbWUgPSAibWFsaV8xIiwKPiA+ID4gKwkJLm9wcyA9ICZj\n" + "bGtfZ2F0ZV9vcHMsCj4gPiA+ICsJCS5wYXJlbnRfbmFtZXMgPSAoY29uc3QgY2hhciAqW10peyAi\n" + "bWFsaV8xX2RpdiIKPiA+ID4gfSwKPiA+ID4gKwkJLm51bV9wYXJlbnRzID0gMSwKPiA+ID4gKwkJ\n" + "LmZsYWdzID0gKENMS19TRVRfUkFURV9QQVJFTlQgfAo+ID4gPiBDTEtfSUdOT1JFX1VOVVNFRCks\n" + "Cj4gPiA+ICsJfSwKPiA+ID4gK307Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB1MzIgbXV4X3RhYmxl\n" + "X21hbGlbXSA9IHswLCAxfTsKPiA+ID4gK2NvbnN0IGNoYXIgKmd4YmJfbWFsaV9wYXJlbnRfbmFt\n" + "ZXNbXSA9IHsKPiA+IAo+ID4gc3RhdGljPwo+ID4gCj4gPiA+ICsJIm1hbGlfMCIsICJtYWxpXzEi\n" + "Cj4gPiA+ICt9Owo+ID4gCj4gPiBbLi4uXQo+ID4gPiDCoHN0YXRpYyBzdHJ1Y3QgY2xrX211eCAq\n" + "Z3hiYl9jbGtfbXV4ZXNbXSA9IHsKPiA+ID4gwqAJJmd4YmJfbXBlZ19jbGtfc2VsLAo+ID4gPiDC\n" + "oAkmZ3hiYl9zYXJfYWRjX2Nsa19zZWwsCj4gPiA+ICsJJmd4YmJfbWFsaV8wX3NlbCwKPiA+ID4g\n" + "KwkmZ3hiYl9tYWxpXzFfc2VsLAo+ID4gPiArCSZneGJiX21hbGksCj4gPiA+IMKgfTsKPiA+ID4g\n" + "wqAKPiA+ID4gwqBzdGF0aWMgc3RydWN0IGNsa19kaXZpZGVyICpneGJiX2Nsa19kaXZpZGVyc1td\n" + "ID0gewo+ID4gCj4gPiBDYW4gdGhlc2UgYXJyYXlzIGJlIGNvbnN0PyBJZiBzbywgcGxlYXNlIGRv\n" + "IHRoYXQgaW4gYSBzZXBhcmF0ZQo+ID4gcGF0Y2guCj4gCj4gSG1tLCB0aGVzZSB3ZXJlIGludHJv\n" + "ZHVjZWQgYnkgamVyb21lLCBoZSBzaG91bGQgdXBkYXRlIHRoZW0KPiBhY2NvcmRpbmdseS4KPiAK\n" + "CldpbGwgZG8KCj4gPiA+IMKgCSZneGJiX21wZWdfY2xrX2RpdiwKPiA+ID4gwqAJJmd4YmJfc2Fy\n" + "X2FkY19jbGtfZGl2LAo+ID4gPiArCSZneGJiX21hbGlfMF9kaXYsCj4gPiA+ICsJJmd4YmJfbWFs\n" + "aV8xX2RpdiwKPiA+ID4gwqB9Owo+IAo+IAo+IFRoYW5rcywKPiBOZWlsCgpfX19fX19fX19fX19f\n" + "X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcg\n" + "bGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh\n" + ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== -ef565f220450e6c61059b088eab4a6802650f7043031efe3b3a3b8c7ff2657ff +d56a9c8f2c0639c95dc2e58b575075a268f6269aa5af49e2b0435f421dbb6c60
diff --git a/a/content_digest b/N2/content_digest index 378a4dd..5545863 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,7 +5,7 @@ "From\0jbrunet@baylibre.com (Jerome Brunet)\0" "Subject\0[PATCH v2 2/3] clk: meson-gxbb: Add MALI clocks\0" "Date\0Thu, 02 Mar 2017 12:28:02 +0100\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote:\n" @@ -93,4 +93,4 @@ "> Thanks,\n" > Neil -ef565f220450e6c61059b088eab4a6802650f7043031efe3b3a3b8c7ff2657ff +6a69d2b39d27fff4ee771b7c14acc4e79d865e315dd2383ca5d39c53577501d7
diff --git a/a/1.txt b/N3/1.txt index 7f2853c..53129fb 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -8,9 +8,9 @@ On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote: > > > --- a/drivers/clk/meson/gxbb.c > > > +++ b/drivers/clk/meson/gxbb.c > > > @@ -634,6 +634,131 @@ -> > > ? }, -> > > ?}; -> > > ? +> > > }, +> > > }; +> > > > > > +/* > > > + * The MALI IP is clocked by two identical clocks (mali_0 and > > > mali_1) @@ -54,15 +54,15 @@ On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote: > > > +}; > > > > [...] -> > > ?static struct clk_mux *gxbb_clk_muxes[] = { -> > > ? &gxbb_mpeg_clk_sel, -> > > ? &gxbb_sar_adc_clk_sel, +> > > static struct clk_mux *gxbb_clk_muxes[] = { +> > > &gxbb_mpeg_clk_sel, +> > > &gxbb_sar_adc_clk_sel, > > > + &gxbb_mali_0_sel, > > > + &gxbb_mali_1_sel, > > > + &gxbb_mali, -> > > ?}; -> > > ? -> > > ?static struct clk_divider *gxbb_clk_dividers[] = { +> > > }; +> > > +> > > static struct clk_divider *gxbb_clk_dividers[] = { > > > > Can these arrays be const? If so, please do that in a separate > > patch. @@ -73,11 +73,11 @@ On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote: Will do -> > > ? &gxbb_mpeg_clk_div, -> > > ? &gxbb_sar_adc_clk_div, +> > > &gxbb_mpeg_clk_div, +> > > &gxbb_sar_adc_clk_div, > > > + &gxbb_mali_0_div, > > > + &gxbb_mali_1_div, -> > > ?}; +> > > }; > > > Thanks, diff --git a/a/content_digest b/N3/content_digest index 378a4dd..fdf0559 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,10 +2,17 @@ "ref\01488365164-22861-3-git-send-email-narmstrong@baylibre.com\0" "ref\020170301191119.GR25384@codeaurora.org\0" "ref\06cd2e42d-6169-a2f0-db33-e13ca1619a41@baylibre.com\0" - "From\0jbrunet@baylibre.com (Jerome Brunet)\0" - "Subject\0[PATCH v2 2/3] clk: meson-gxbb: Add MALI clocks\0" + "From\0Jerome Brunet <jbrunet@baylibre.com>\0" + "Subject\0Re: [PATCH v2 2/3] clk: meson-gxbb: Add MALI clocks\0" "Date\0Thu, 02 Mar 2017 12:28:02 +0100\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0Neil Armstrong <narmstrong@baylibre.com>" + " Stephen Boyd <sboyd@codeaurora.org>\0" + "Cc\0khilman@baylibre.com" + carlo@caione.org + linux-amlogic@lists.infradead.org + linux-clk@vger.kernel.org + linux-arm-kernel@lists.infradead.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, 2017-03-02 at 12:07 +0100, Neil Armstrong wrote:\n" @@ -18,9 +25,9 @@ "> > > --- a/drivers/clk/meson/gxbb.c\n" "> > > +++ b/drivers/clk/meson/gxbb.c\n" "> > > @@ -634,6 +634,131 @@\n" - "> > > ?\t},\n" - "> > > ?};\n" - "> > > ?\n" + "> > > \302\240\t},\n" + "> > > \302\240};\n" + "> > > \302\240\n" "> > > +/*\n" "> > > + * The MALI IP is clocked by two identical clocks (mali_0 and\n" "> > > mali_1)\n" @@ -64,15 +71,15 @@ "> > > +};\n" "> > \n" "> > [...]\n" - "> > > ?static struct clk_mux *gxbb_clk_muxes[] = {\n" - "> > > ?\t&gxbb_mpeg_clk_sel,\n" - "> > > ?\t&gxbb_sar_adc_clk_sel,\n" + "> > > \302\240static struct clk_mux *gxbb_clk_muxes[] = {\n" + "> > > \302\240\t&gxbb_mpeg_clk_sel,\n" + "> > > \302\240\t&gxbb_sar_adc_clk_sel,\n" "> > > +\t&gxbb_mali_0_sel,\n" "> > > +\t&gxbb_mali_1_sel,\n" "> > > +\t&gxbb_mali,\n" - "> > > ?};\n" - "> > > ?\n" - "> > > ?static struct clk_divider *gxbb_clk_dividers[] = {\n" + "> > > \302\240};\n" + "> > > \302\240\n" + "> > > \302\240static struct clk_divider *gxbb_clk_dividers[] = {\n" "> > \n" "> > Can these arrays be const? If so, please do that in a separate\n" "> > patch.\n" @@ -83,14 +90,14 @@ "\n" "Will do\n" "\n" - "> > > ?\t&gxbb_mpeg_clk_div,\n" - "> > > ?\t&gxbb_sar_adc_clk_div,\n" + "> > > \302\240\t&gxbb_mpeg_clk_div,\n" + "> > > \302\240\t&gxbb_sar_adc_clk_div,\n" "> > > +\t&gxbb_mali_0_div,\n" "> > > +\t&gxbb_mali_1_div,\n" - "> > > ?};\n" + "> > > \302\240};\n" "> \n" "> \n" "> Thanks,\n" > Neil -ef565f220450e6c61059b088eab4a6802650f7043031efe3b3a3b8c7ff2657ff +15b2751888dee56cedd73d0889212f551f900feb17b0a992abae73e0d799b829
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.