From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gcc-source: rewrite do_preconfigure() in shell
Date: Thu, 02 Mar 2017 16:21:37 +0000 [thread overview]
Message-ID: <1488471697.24526.80.camel@linuxfoundation.org> (raw)
In-Reply-To: <1488471409-11114-1-git-send-email-ross.burton@intel.com>
On Thu, 2017-03-02 at 16:16 +0000, Ross Burton wrote:
> This function is essentially just four lines of shell, that for some
> reason was
> written in Python.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-devtools/gcc/gcc-source.inc | 25 +++++++++++-----------
I suspect this will break in the various signature checks and cause
rebuilds when things shouldn't.
http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/?id=f07b7c0da1748afc35fbb2ead7ae10ec66c7c428
hints at why:
"It needs to be a python task to avoid lots of shell exported variables as dependencies."
which should of course be a comment in the code.
I wish we had a better way to control exported variables to shell tasks
which would be a better fix but right now we don't.
Cheers,
Richard
prev parent reply other threads:[~2017-03-02 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:16 [PATCH] gcc-source: rewrite do_preconfigure() in shell Ross Burton
2017-03-02 16:21 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488471697.24526.80.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.