From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Thu, 2 Mar 2017 18:57:19 +0000 Subject: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback In-Reply-To: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> List-ID: Message-ID: <1488481038.2684.14.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Jose, On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote: > This patch adds the necessary DT bindings to get HDMI audio > output in ARC AXS10x SDP. The bindings for I2S controller were > added as well as the bindings for simple audio card. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Rob Herring > Cc: Vineet Gupta > Cc: devicetree at vger.kernel.org > Cc: linux-snps-arc at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > --- > ?arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++---- > ?1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index d6c1bbc..9d882b1 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -149,12 +149,13 @@ > ? interrupts = <14>; > ? }; > ? > - i2c at 0x1e000 { > - compatible = "snps,designware-i2c"; > + i2s: i2s at 1e000 { > + compatible = "snps,designware-i2s"; > ? reg = <0x1e000 0x100>; > - clock-frequency = <400000>; > - clocks = <&i2cclk>; > + clocks = <&i2sclk 0>; > + clock-names = "i2sclk"; > ? interrupts = <15>; > + #sound-dai-cells = <0>; > ? }; > ? > ? i2c at 0x1f000 { > @@ -174,6 +175,7 @@ > ? adi,input-colorspace = "rgb"; > ? adi,input-clock = "1x"; > ? adi,clock-delay = <0x03>; > + #sound-dai-cells = <0>; > ? > ? ports { > ? #address-cells = <1>; > @@ -295,5 +297,17 @@ > ? }; > ? }; > ? }; > + > + sound_playback { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "AXS10x HDMI Audio"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,cpu { > + sound-dai = <&i2s>; > + }; > + simple-audio-card,codec { > + sound-dai = <&adv7511>; > + }; > + }; > ? }; > ?}; Just for the sake of history that's my mods to defconfig that allowed me to play .pcm via HDMI from axs103 board: -------------------------------->8------------------------------- diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig index 30a3d4cf53d2..b11362a32e4e 100644 --- a/arch/arc/configs/axs103_smp_defconfig +++ b/arch/arc/configs/axs103_smp_defconfig @@ -67,25 +67,29 @@ CONFIG_MOUSE_PS2_TOUCHKIT=y ?CONFIG_MOUSE_SERIAL=y ?CONFIG_MOUSE_SYNAPTICS_USB=y ?# CONFIG_LEGACY_PTYS is not set -# CONFIG_DEVKMEM is not set ?CONFIG_SERIAL_8250=y ?CONFIG_SERIAL_8250_CONSOLE=y ?CONFIG_SERIAL_8250_DW=y ?CONFIG_SERIAL_OF_PLATFORM=y ?# CONFIG_HW_RANDOM is not set -CONFIG_I2C=y ?CONFIG_I2C_CHARDEV=y ?CONFIG_I2C_DESIGNWARE_PLATFORM=y ?# CONFIG_HWMON is not set -CONFIG_DRM=m -CONFIG_DRM_I2C_ADV7511=m -CONFIG_DRM_ARCPGU=m -CONFIG_FB=y +CONFIG_DRM=y +CONFIG_DRM_I2C_ADV7511=y +CONFIG_DRM_I2C_ADV7511_AUDIO=y +CONFIG_DRM_ARCPGU=y ?CONFIG_FRAMEBUFFER_CONSOLE=y ?CONFIG_LOGO=y ?# CONFIG_LOGO_LINUX_MONO is not set ?# CONFIG_LOGO_LINUX_VGA16 is not set ?# CONFIG_LOGO_LINUX_CLUT224 is not set +CONFIG_SOUND=y +CONFIG_SND=y +CONFIG_SND_SOC=y +CONFIG_SND_DESIGNWARE_I2S=y +CONFIG_SND_DESIGNWARE_PCM=y +CONFIG_SND_SIMPLE_CARD=y ?CONFIG_USB_EHCI_HCD=y ?CONFIG_USB_EHCI_HCD_PLATFORM=y ?CONFIG_USB_OHCI_HCD=y -------------------------------->8------------------------------- Anyways... Acked-by: Alexey Brodkin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Date: Thu, 2 Mar 2017 18:57:19 +0000 Message-ID: <1488481038.2684.14.camel@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> Content-Language: en-US Content-ID: <30D0E2AEBD7C7B49B13887A610C2895A@internal.synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Jose Abreu Cc: "devicetree@vger.kernel.org" , Vineet Gupta , Carlos Palminha , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-snps-arc@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgSm9zZSwNCg0KT24gV2VkLCAyMDE3LTAyLTIyIGF0IDE4OjE5ICswMDAwLCBKb3NlIEFicmV1 IHdyb3RlOg0KPiBUaGlzIHBhdGNoIGFkZHMgdGhlIG5lY2Vzc2FyeSBEVCBiaW5kaW5ncyB0byBn ZXQgSERNSSBhdWRpbw0KPiBvdXRwdXQgaW4gQVJDIEFYUzEweCBTRFAuIFRoZSBiaW5kaW5ncyBm b3IgSTJTIGNvbnRyb2xsZXIgd2VyZQ0KPiBhZGRlZCBhcyB3ZWxsIGFzIHRoZSBiaW5kaW5ncyBm b3Igc2ltcGxlIGF1ZGlvIGNhcmQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKb3NlIEFicmV1IDxq b2FicmV1QHN5bm9wc3lzLmNvbT4NCj4gQ2M6IENhcmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lu b3BzeXMuY29tPg0KPiBDYzogQWxleGV5IEJyb2RraW4gPGFicm9ka2luQHN5bm9wc3lzLmNvbT4N Cj4gQ2M6IFJvYiBIZXJyaW5nIDxyb2JoK2R0QGtlcm5lbC5vcmc+DQo+IENjOiBWaW5lZXQgR3Vw dGEgPHZndXB0YUBzeW5vcHN5cy5jb20+DQo+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9y Zw0KPiBDYzogbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBDYzogbGludXgt a2VybmVsQHZnZXIua2VybmVsLm9yZw0KPiAtLS0NCj4gwqBhcmNoL2FyYy9ib290L2R0cy9heHMx MHhfbWIuZHRzaSB8IDIyICsrKysrKysrKysrKysrKysrKy0tLS0NCj4gwqAxIGZpbGUgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9h cmNoL2FyYy9ib290L2R0cy9heHMxMHhfbWIuZHRzaSBiL2FyY2gvYXJjL2Jvb3QvZHRzL2F4czEw eF9tYi5kdHNpDQo+IGluZGV4IGQ2YzFiYmMuLjlkODgyYjEgMTAwNjQ0DQo+IC0tLSBhL2FyY2gv YXJjL2Jvb3QvZHRzL2F4czEweF9tYi5kdHNpDQo+ICsrKyBiL2FyY2gvYXJjL2Jvb3QvZHRzL2F4 czEweF9tYi5kdHNpDQo+IEBAIC0xNDksMTIgKzE0OSwxMyBAQA0KPiDCoAkJCWludGVycnVwdHMg PSA8MTQ+Ow0KPiDCoAkJfTsNCj4gwqANCj4gLQkJaTJjQDB4MWUwMDAgew0KPiAtCQkJY29tcGF0 aWJsZSA9ICJzbnBzLGRlc2lnbndhcmUtaTJjIjsNCj4gKwkJaTJzOiBpMnNAMWUwMDAgew0KPiAr CQkJY29tcGF0aWJsZSA9ICJzbnBzLGRlc2lnbndhcmUtaTJzIjsNCj4gwqAJCQlyZWcgPSA8MHgx ZTAwMCAweDEwMD47DQo+IC0JCQljbG9jay1mcmVxdWVuY3kgPSA8NDAwMDAwPjsNCj4gLQkJCWNs b2NrcyA9IDwmaTJjY2xrPjsNCj4gKwkJCWNsb2NrcyA9IDwmaTJzY2xrIDA+Ow0KPiArCQkJY2xv Y2stbmFtZXMgPSAiaTJzY2xrIjsNCj4gwqAJCQlpbnRlcnJ1cHRzID0gPDE1PjsNCj4gKwkJCSNz b3VuZC1kYWktY2VsbHMgPSA8MD47DQo+IMKgCQl9Ow0KPiDCoA0KPiDCoAkJaTJjQDB4MWYwMDAg ew0KPiBAQCAtMTc0LDYgKzE3NSw3IEBADQo+IMKgCQkJCWFkaSxpbnB1dC1jb2xvcnNwYWNlID0g InJnYiI7DQo+IMKgCQkJCWFkaSxpbnB1dC1jbG9jayA9ICIxeCI7DQo+IMKgCQkJCWFkaSxjbG9j ay1kZWxheSA9IDwweDAzPjsNCj4gKwkJCQkjc291bmQtZGFpLWNlbGxzID0gPDA+Ow0KPiDCoA0K PiDCoAkJCQlwb3J0cyB7DQo+IMKgCQkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gQEAgLTI5 NSw1ICsyOTcsMTcgQEANCj4gwqAJCQkJfTsNCj4gwqAJCQl9Ow0KPiDCoAkJfTsNCj4gKw0KPiAr CQlzb3VuZF9wbGF5YmFjayB7DQo+ICsJCQljb21wYXRpYmxlID0gInNpbXBsZS1hdWRpby1jYXJk IjsNCj4gKwkJCXNpbXBsZS1hdWRpby1jYXJkLG5hbWUgPSAiQVhTMTB4IEhETUkgQXVkaW8iOw0K PiArCQkJc2ltcGxlLWF1ZGlvLWNhcmQsZm9ybWF0ID0gImkycyI7DQo+ICsJCQlzaW1wbGUtYXVk aW8tY2FyZCxjcHUgew0KPiArCQkJCXNvdW5kLWRhaSA9IDwmaTJzPjsNCj4gKwkJCX07DQo+ICsJ CQlzaW1wbGUtYXVkaW8tY2FyZCxjb2RlYyB7DQo+ICsJCQkJc291bmQtZGFpID0gPCZhZHY3NTEx PjsNCj4gKwkJCX07DQo+ICsJCX07DQo+IMKgCX07DQo+IMKgfTsNCg0KSnVzdCBmb3IgdGhlIHNh a2Ugb2YgaGlzdG9yeSB0aGF0J3MgbXkgbW9kcyB0byBkZWZjb25maWcgdGhhdCBhbGxvd2VkIG1l DQp0byBwbGF5IC5wY20gdmlhIEhETUkgZnJvbSBheHMxMDMgYm9hcmQ6DQotLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KZGlm ZiAtLWdpdCBhL2FyY2gvYXJjL2NvbmZpZ3MvYXhzMTAzX3NtcF9kZWZjb25maWcgYi9hcmNoL2Fy Yy9jb25maWdzL2F4czEwM19zbXBfZGVmY29uZmlnDQppbmRleCAzMGEzZDRjZjUzZDIuLmIxMTM2 MmEzMmU0ZSAxMDA2NDQNCi0tLSBhL2FyY2gvYXJjL2NvbmZpZ3MvYXhzMTAzX3NtcF9kZWZjb25m aWcNCisrKyBiL2FyY2gvYXJjL2NvbmZpZ3MvYXhzMTAzX3NtcF9kZWZjb25maWcNCkBAIC02Nywy NSArNjcsMjkgQEAgQ09ORklHX01PVVNFX1BTMl9UT1VDSEtJVD15DQrCoENPTkZJR19NT1VTRV9T RVJJQUw9eQ0KwqBDT05GSUdfTU9VU0VfU1lOQVBUSUNTX1VTQj15DQrCoCMgQ09ORklHX0xFR0FD WV9QVFlTIGlzIG5vdCBzZXQNCi0jIENPTkZJR19ERVZLTUVNIGlzIG5vdCBzZXQNCsKgQ09ORklH X1NFUklBTF84MjUwPXkNCsKgQ09ORklHX1NFUklBTF84MjUwX0NPTlNPTEU9eQ0KwqBDT05GSUdf U0VSSUFMXzgyNTBfRFc9eQ0KwqBDT05GSUdfU0VSSUFMX09GX1BMQVRGT1JNPXkNCsKgIyBDT05G SUdfSFdfUkFORE9NIGlzIG5vdCBzZXQNCi1DT05GSUdfSTJDPXkNCsKgQ09ORklHX0kyQ19DSEFS REVWPXkNCsKgQ09ORklHX0kyQ19ERVNJR05XQVJFX1BMQVRGT1JNPXkNCsKgIyBDT05GSUdfSFdN T04gaXMgbm90IHNldA0KLUNPTkZJR19EUk09bQ0KLUNPTkZJR19EUk1fSTJDX0FEVjc1MTE9bQ0K LUNPTkZJR19EUk1fQVJDUEdVPW0NCi1DT05GSUdfRkI9eQ0KK0NPTkZJR19EUk09eQ0KK0NPTkZJ R19EUk1fSTJDX0FEVjc1MTE9eQ0KK0NPTkZJR19EUk1fSTJDX0FEVjc1MTFfQVVESU89eQ0KK0NP TkZJR19EUk1fQVJDUEdVPXkNCsKgQ09ORklHX0ZSQU1FQlVGRkVSX0NPTlNPTEU9eQ0KwqBDT05G SUdfTE9HTz15DQrCoCMgQ09ORklHX0xPR09fTElOVVhfTU9OTyBpcyBub3Qgc2V0DQrCoCMgQ09O RklHX0xPR09fTElOVVhfVkdBMTYgaXMgbm90IHNldA0KwqAjIENPTkZJR19MT0dPX0xJTlVYX0NM VVQyMjQgaXMgbm90IHNldA0KK0NPTkZJR19TT1VORD15DQorQ09ORklHX1NORD15DQorQ09ORklH X1NORF9TT0M9eQ0KK0NPTkZJR19TTkRfREVTSUdOV0FSRV9JMlM9eQ0KK0NPTkZJR19TTkRfREVT SUdOV0FSRV9QQ009eQ0KK0NPTkZJR19TTkRfU0lNUExFX0NBUkQ9eQ0KwqBDT05GSUdfVVNCX0VI Q0lfSENEPXkNCsKgQ09ORklHX1VTQl9FSENJX0hDRF9QTEFURk9STT15DQrCoENPTkZJR19VU0Jf T0hDSV9IQ0Q9eQ0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0NCg0KQW55d2F5cy4uLg0KDQpBY2tlZC1ieTogQWxleGV5IEJy b2RraW4gPGFicm9ka2luQHN5bm9wc3lzLmNvbT4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNu cHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1zbnBzLWFyYw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753032AbdCBTgQ (ORCPT ); Thu, 2 Mar 2017 14:36:16 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:54518 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbdCBTgN (ORCPT ); Thu, 2 Mar 2017 14:36:13 -0500 From: Alexey Brodkin To: Jose Abreu CC: Carlos Palminha , "linux-kernel@vger.kernel.org" , Vineet Gupta , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Thread-Topic: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback Thread-Index: AQHSjThHjY/1NQnLSUe6MpXTxmC2K6GB4mwA Date: Thu, 2 Mar 2017 18:57:19 +0000 Message-ID: <1488481038.2684.14.camel@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> In-Reply-To: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.102] Content-Type: text/plain; charset="utf-8" Content-ID: <30D0E2AEBD7C7B49B13887A610C2895A@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v22Jai4Y017591 Hi Jose, On Wed, 2017-02-22 at 18:19 +0000, Jose Abreu wrote: > This patch adds the necessary DT bindings to get HDMI audio > output in ARC AXS10x SDP. The bindings for I2S controller were > added as well as the bindings for simple audio card. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Rob Herring > Cc: Vineet Gupta > Cc: devicetree@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- >  arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++---- >  1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index d6c1bbc..9d882b1 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -149,12 +149,13 @@ >   interrupts = <14>; >   }; >   > - i2c@0x1e000 { > - compatible = "snps,designware-i2c"; > + i2s: i2s@1e000 { > + compatible = "snps,designware-i2s"; >   reg = <0x1e000 0x100>; > - clock-frequency = <400000>; > - clocks = <&i2cclk>; > + clocks = <&i2sclk 0>; > + clock-names = "i2sclk"; >   interrupts = <15>; > + #sound-dai-cells = <0>; >   }; >   >   i2c@0x1f000 { > @@ -174,6 +175,7 @@ >   adi,input-colorspace = "rgb"; >   adi,input-clock = "1x"; >   adi,clock-delay = <0x03>; > + #sound-dai-cells = <0>; >   >   ports { >   #address-cells = <1>; > @@ -295,5 +297,17 @@ >   }; >   }; >   }; > + > + sound_playback { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "AXS10x HDMI Audio"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,cpu { > + sound-dai = <&i2s>; > + }; > + simple-audio-card,codec { > + sound-dai = <&adv7511>; > + }; > + }; >   }; >  }; Just for the sake of history that's my mods to defconfig that allowed me to play .pcm via HDMI from axs103 board: -------------------------------->8------------------------------- diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig index 30a3d4cf53d2..b11362a32e4e 100644 --- a/arch/arc/configs/axs103_smp_defconfig +++ b/arch/arc/configs/axs103_smp_defconfig @@ -67,25 +67,29 @@ CONFIG_MOUSE_PS2_TOUCHKIT=y  CONFIG_MOUSE_SERIAL=y  CONFIG_MOUSE_SYNAPTICS_USB=y  # CONFIG_LEGACY_PTYS is not set -# CONFIG_DEVKMEM is not set  CONFIG_SERIAL_8250=y  CONFIG_SERIAL_8250_CONSOLE=y  CONFIG_SERIAL_8250_DW=y  CONFIG_SERIAL_OF_PLATFORM=y  # CONFIG_HW_RANDOM is not set -CONFIG_I2C=y  CONFIG_I2C_CHARDEV=y  CONFIG_I2C_DESIGNWARE_PLATFORM=y  # CONFIG_HWMON is not set -CONFIG_DRM=m -CONFIG_DRM_I2C_ADV7511=m -CONFIG_DRM_ARCPGU=m -CONFIG_FB=y +CONFIG_DRM=y +CONFIG_DRM_I2C_ADV7511=y +CONFIG_DRM_I2C_ADV7511_AUDIO=y +CONFIG_DRM_ARCPGU=y  CONFIG_FRAMEBUFFER_CONSOLE=y  CONFIG_LOGO=y  # CONFIG_LOGO_LINUX_MONO is not set  # CONFIG_LOGO_LINUX_VGA16 is not set  # CONFIG_LOGO_LINUX_CLUT224 is not set +CONFIG_SOUND=y +CONFIG_SND=y +CONFIG_SND_SOC=y +CONFIG_SND_DESIGNWARE_I2S=y +CONFIG_SND_DESIGNWARE_PCM=y +CONFIG_SND_SIMPLE_CARD=y  CONFIG_USB_EHCI_HCD=y  CONFIG_USB_EHCI_HCD_PLATFORM=y  CONFIG_USB_OHCI_HCD=y -------------------------------->8------------------------------- Anyways... Acked-by: Alexey Brodkin