From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Fri, 3 Mar 2017 13:27:30 +0000 Subject: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check In-Reply-To: <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> References: <1488475674-6694-1-git-send-email-abrodkin@synopsys.com> <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> List-ID: Message-ID: <1488547649.2940.5.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Daniel, On Thu, 2017-03-02@20:54 +0100, Daniel Vetter wrote: > On Thu, Mar 02, 2017@08:27:54PM +0300, Alexey Brodkin wrote: > > > > Since we cannot always generate exactly requested pixel clock > > there's not much sense in checking requested_clock == clk_round_rate(). > > In that case for quite some modes we'll be getting -EINVAL and no video > > output at all. > > > > But given there's some tolerance to real pixel clock in TVs/monitors > > we may still give it a try with the clock as close to requested one as > > PLL on the board may generate. So we just do a fixup to what current > > board may provide. > > > > Signed-off-by: Alexey Brodkin > > Cc: Daniel Vetter > > Cc: David Airlie > > Cc: Jose Abreu > > --- > > ?drivers/gpu/drm/arc/arcpgu_crtc.c | 16 +++++++--------- > > ?1 file changed, 7 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c > > index ad9a95916f1f..3f2823c1efc3 100644 > > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > > @@ -129,18 +129,16 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) > > ? ??????~ARCPGU_CTRL_ENABLE_MASK); > > ?} > > ? > > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, > > - ?????struct drm_crtc_state *state) > > +static bool arc_pgu_crtc_mode_fixup(struct drm_crtc *crtc, > > + ????const struct drm_display_mode *mode, > > + ????struct drm_display_mode *adjusted_mode) > > This isn't required at all, see drm_crtc_state.adjusted_mode. Just update > that and you're good - .mode_fixup is the backwards compatibility function > for old kms drivers, atomic_check is strictly more powerful. So if I understood you correct here what I really need is just to get rid of existing check, right? I.e. the following is to be in v2 respin: ------------------------------->8------------------------------- diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index ad9a95916f1f..86f1555914e8 100644 --- a/drivers/gpu/drm/arc/arcpgu_crtc.c +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) ??????????????????????????????~ARCPGU_CTRL_ENABLE_MASK); ?} ? -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, -????????????????????????????????????struct drm_crtc_state *state) -{ -???????struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); -???????struct drm_display_mode *mode = &state->adjusted_mode; -???????long rate, clk_rate = mode->clock * 1000; - -???????rate = clk_round_rate(arcpgu->clk, clk_rate); -???????if (rate != clk_rate) -???????????????return -EINVAL; - -???????return 0; -} - ?static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, ??????????????????????????????????????struct drm_crtc_state *state) ?{ @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { ????????.disable????????= arc_pgu_crtc_disable, ????????.prepare????????= arc_pgu_crtc_disable, ????????.commit?????????= arc_pgu_crtc_enable, -???????.atomic_check???= arc_pgu_crtc_atomic_check, ????????.atomic_begin???= arc_pgu_crtc_atomic_begin, ?}; ------------------------------->8------------------------------- > Please also make sure the documentation properly explains this, and if > not, please submit a patch to improve it. You mean explains what? That .mode_fixup is not meant to be used in new code? -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check Date: Fri, 3 Mar 2017 13:27:30 +0000 Message-ID: <1488547649.2940.5.camel@synopsys.com> References: <1488475674-6694-1-git-send-email-abrodkin@synopsys.com> <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> Content-Language: en-US Content-ID: <2F560457E31F02458E7087E5AA1FAF02@internal.synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "daniel@ffwll.ch" Cc: "Jose.Abreu@synopsys.com" , "airlied@linux.ie" , "daniel.vetter@ffwll.ch" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLA0KDQpPbiBUaHUsIDIwMTctMDMtMDIgYXQgMjA6NTQgKzAxMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6DQo+IE9uIFRodSwgTWFyIDAyLCAyMDE3IGF0IDA4OjI3OjU0UE0gKzAzMDAs IEFsZXhleSBCcm9ka2luIHdyb3RlOg0KPiA+IA0KPiA+IFNpbmNlIHdlIGNhbm5vdCBhbHdheXMg Z2VuZXJhdGUgZXhhY3RseSByZXF1ZXN0ZWQgcGl4ZWwgY2xvY2sNCj4gPiB0aGVyZSdzIG5vdCBt dWNoIHNlbnNlIGluIGNoZWNraW5nIHJlcXVlc3RlZF9jbG9jayA9PSBjbGtfcm91bmRfcmF0ZSgp Lg0KPiA+IEluIHRoYXQgY2FzZSBmb3IgcXVpdGUgc29tZSBtb2RlcyB3ZSdsbCBiZSBnZXR0aW5n IC1FSU5WQUwgYW5kIG5vIHZpZGVvDQo+ID4gb3V0cHV0IGF0IGFsbC4NCj4gPiANCj4gPiBCdXQg Z2l2ZW4gdGhlcmUncyBzb21lIHRvbGVyYW5jZSB0byByZWFsIHBpeGVsIGNsb2NrIGluIFRWcy9t b25pdG9ycw0KPiA+IHdlIG1heSBzdGlsbCBnaXZlIGl0IGEgdHJ5IHdpdGggdGhlIGNsb2NrIGFz IGNsb3NlIHRvIHJlcXVlc3RlZCBvbmUgYXMNCj4gPiBQTEwgb24gdGhlIGJvYXJkIG1heSBnZW5l cmF0ZS4gU28gd2UganVzdCBkbyBhIGZpeHVwIHRvIHdoYXQgY3VycmVudA0KPiA+IGJvYXJkIG1h eSBwcm92aWRlLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEFsZXhleSBCcm9ka2luIDxhYnJv ZGtpbkBzeW5vcHN5cy5jb20+DQo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+DQo+ID4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4NCj4gPiBD YzogSm9zZSBBYnJldSA8am9hYnJldUBzeW5vcHN5cy5jb20+DQo+ID4gLS0tDQo+ID4gwqBkcml2 ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9jcnRjLmMgfCAxNiArKysrKysrLS0tLS0tLS0tDQo+ID4g wqAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQ0KPiA+IA0K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9jcnRjLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9jcnRjLmMNCj4gPiBpbmRleCBhZDlhOTU5MTZmMWYuLjNm MjgyM2MxZWZjMyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9j cnRjLmMNCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9jcnRjLmMNCj4gPiBA QCAtMTI5LDE4ICsxMjksMTYgQEAgc3RhdGljIHZvaWQgYXJjX3BndV9jcnRjX2Rpc2FibGUoc3Ry dWN0IGRybV9jcnRjICpjcnRjKQ0KPiA+IMKgCQkJwqDCoMKgwqDCoMKgfkFSQ1BHVV9DVFJMX0VO QUJMRV9NQVNLKTsNCj4gPiDCoH0NCj4gPiDCoA0KPiA+IC1zdGF0aWMgaW50IGFyY19wZ3VfY3J0 Y19hdG9taWNfY2hlY2soc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiA+IC0JCQkJwqDCoMKgwqDC oHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpDQo+ID4gK3N0YXRpYyBib29sIGFyY19wZ3Vf Y3J0Y19tb2RlX2ZpeHVwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywNCj4gPiArCQkJCcKgwqDCoMKg Y29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsDQo+ID4gKwkJCQnCoMKgwqDCoHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlKQ0KPiANCj4gVGhpcyBpc24ndCBy ZXF1aXJlZCBhdCBhbGwsIHNlZSBkcm1fY3J0Y19zdGF0ZS5hZGp1c3RlZF9tb2RlLiBKdXN0IHVw ZGF0ZQ0KPiB0aGF0IGFuZCB5b3UncmUgZ29vZCAtIC5tb2RlX2ZpeHVwIGlzIHRoZSBiYWNrd2Fy ZHMgY29tcGF0aWJpbGl0eSBmdW5jdGlvbg0KPiBmb3Igb2xkIGttcyBkcml2ZXJzLCBhdG9taWNf Y2hlY2sgaXMgc3RyaWN0bHkgbW9yZSBwb3dlcmZ1bC4NCg0KU28gaWYgSSB1bmRlcnN0b29kIHlv dSBjb3JyZWN0IGhlcmUgd2hhdCBJIHJlYWxseSBuZWVkIGlzIGp1c3QgdG8gZ2V0IHJpZCBvZiBl eGlzdGluZyBjaGVjaywNCnJpZ2h0PyBJLmUuIHRoZSBmb2xsb3dpbmcgaXMgdG8gYmUgaW4gdjIg cmVzcGluOg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQ0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcmMvYXJjcGd1 X2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcmMvYXJjcGd1X2NydGMuYw0KaW5kZXggYWQ5YTk1 OTE2ZjFmLi44NmYxNTU1OTE0ZTggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJjL2Fy Y3BndV9jcnRjLmMNCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcmMvYXJjcGd1X2NydGMuYw0KQEAg LTEyOSwyMCArMTI5LDYgQEAgc3RhdGljIHZvaWQgYXJjX3BndV9jcnRjX2Rpc2FibGUoc3RydWN0 IGRybV9jcnRjICpjcnRjKQ0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgfkFSQ1BHVV9DVFJMX0VOQUJMRV9NQVNLKTsNCsKgfQ0KwqAN Ci1zdGF0aWMgaW50IGFyY19wZ3VfY3J0Y19hdG9taWNfY2hlY2soc3RydWN0IGRybV9jcnRjICpj cnRjLA0KLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpDQotew0K LcKgwqDCoMKgwqDCoMKgc3RydWN0IGFyY3BndV9kcm1fcHJpdmF0ZSAqYXJjcGd1ID0gY3J0Y190 b19hcmNwZ3VfcHJpdihjcnRjKTsNCi3CoMKgwqDCoMKgwqDCoHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICptb2RlID0gJnN0YXRlLT5hZGp1c3RlZF9tb2RlOw0KLcKgwqDCoMKgwqDCoMKgbG9uZyBy YXRlLCBjbGtfcmF0ZSA9IG1vZGUtPmNsb2NrICogMTAwMDsNCi0NCi3CoMKgwqDCoMKgwqDCoHJh dGUgPSBjbGtfcm91bmRfcmF0ZShhcmNwZ3UtPmNsaywgY2xrX3JhdGUpOw0KLcKgwqDCoMKgwqDC oMKgaWYgKHJhdGUgIT0gY2xrX3JhdGUpDQotwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg cmV0dXJuIC1FSU5WQUw7DQotDQotwqDCoMKgwqDCoMKgwqByZXR1cm4gMDsNCi19DQotDQrCoHN0 YXRpYyB2b2lkIGFyY19wZ3VfY3J0Y19hdG9taWNfYmVnaW4oc3RydWN0IGRybV9jcnRjICpjcnRj LA0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpDQrCoHsN CkBAIC0xNjUsNyArMTUxLDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJf ZnVuY3MgYXJjX3BndV9jcnRjX2hlbHBlcl9mdW5jcyA9IHsNCsKgwqDCoMKgwqDCoMKgwqAuZGlz YWJsZcKgwqDCoMKgwqDCoMKgwqA9IGFyY19wZ3VfY3J0Y19kaXNhYmxlLA0KwqDCoMKgwqDCoMKg wqDCoC5wcmVwYXJlwqDCoMKgwqDCoMKgwqDCoD0gYXJjX3BndV9jcnRjX2Rpc2FibGUsDQrCoMKg wqDCoMKgwqDCoMKgLmNvbW1pdMKgwqDCoMKgwqDCoMKgwqDCoD0gYXJjX3BndV9jcnRjX2VuYWJs ZSwNCi3CoMKgwqDCoMKgwqDCoC5hdG9taWNfY2hlY2vCoMKgwqA9IGFyY19wZ3VfY3J0Y19hdG9t aWNfY2hlY2ssDQrCoMKgwqDCoMKgwqDCoMKgLmF0b21pY19iZWdpbsKgwqDCoD0gYXJjX3BndV9j cnRjX2F0b21pY19iZWdpbiwNCsKgfTsNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+ OC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCg0KPiBQbGVhc2UgYWxzbyBtYWtlIHN1 cmUgdGhlIGRvY3VtZW50YXRpb24gcHJvcGVybHkgZXhwbGFpbnMgdGhpcywgYW5kIGlmDQo+IG5v dCwgcGxlYXNlIHN1Ym1pdCBhIHBhdGNoIHRvIGltcHJvdmUgaXQuDQoNCllvdSBtZWFuIGV4cGxh aW5zIHdoYXQ/IFRoYXQgLm1vZGVfZml4dXAgaXMgbm90IG1lYW50IHRvIGJlIHVzZWQgaW4NCm5l dyBjb2RlPw0KDQotQWxleGV5DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1zbnBzLWFyYyBtYWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXNucHMtYXJj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbdCCN1z (ORCPT ); Fri, 3 Mar 2017 08:27:55 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:36109 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdCCN1x (ORCPT ); Fri, 3 Mar 2017 08:27:53 -0500 From: Alexey Brodkin To: "daniel@ffwll.ch" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Jose.Abreu@synopsys.com" , "daniel.vetter@ffwll.ch" , "linux-snps-arc@lists.infradead.org" , "airlied@linux.ie" Subject: Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check Thread-Topic: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check Thread-Index: AQHSk3pbdSSv6ibt+0alj80EoRWJA6GB5e0AgAEmKoA= Date: Fri, 3 Mar 2017 13:27:30 +0000 Message-ID: <1488547649.2940.5.camel@synopsys.com> References: <1488475674-6694-1-git-send-email-abrodkin@synopsys.com> <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> In-Reply-To: <20170302195437.mlhzia2q2oav27mr@phenom.ffwll.local> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.45] Content-Type: text/plain; charset="utf-8" Content-ID: <2F560457E31F02458E7087E5AA1FAF02@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v23DS5Tq019119 Hi Daniel, On Thu, 2017-03-02 at 20:54 +0100, Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 08:27:54PM +0300, Alexey Brodkin wrote: > > > > Since we cannot always generate exactly requested pixel clock > > there's not much sense in checking requested_clock == clk_round_rate(). > > In that case for quite some modes we'll be getting -EINVAL and no video > > output at all. > > > > But given there's some tolerance to real pixel clock in TVs/monitors > > we may still give it a try with the clock as close to requested one as > > PLL on the board may generate. So we just do a fixup to what current > > board may provide. > > > > Signed-off-by: Alexey Brodkin > > Cc: Daniel Vetter > > Cc: David Airlie > > Cc: Jose Abreu > > --- > >  drivers/gpu/drm/arc/arcpgu_crtc.c | 16 +++++++--------- > >  1 file changed, 7 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c > > index ad9a95916f1f..3f2823c1efc3 100644 > > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > > @@ -129,18 +129,16 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) > >         ~ARCPGU_CTRL_ENABLE_MASK); > >  } > >   > > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, > > -      struct drm_crtc_state *state) > > +static bool arc_pgu_crtc_mode_fixup(struct drm_crtc *crtc, > > +     const struct drm_display_mode *mode, > > +     struct drm_display_mode *adjusted_mode) > > This isn't required at all, see drm_crtc_state.adjusted_mode. Just update > that and you're good - .mode_fixup is the backwards compatibility function > for old kms drivers, atomic_check is strictly more powerful. So if I understood you correct here what I really need is just to get rid of existing check, right? I.e. the following is to be in v2 respin: ------------------------------->8------------------------------- diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index ad9a95916f1f..86f1555914e8 100644 --- a/drivers/gpu/drm/arc/arcpgu_crtc.c +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc)                               ~ARCPGU_CTRL_ENABLE_MASK);  }   -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, -                                    struct drm_crtc_state *state) -{ -       struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); -       struct drm_display_mode *mode = &state->adjusted_mode; -       long rate, clk_rate = mode->clock * 1000; - -       rate = clk_round_rate(arcpgu->clk, clk_rate); -       if (rate != clk_rate) -               return -EINVAL; - -       return 0; -} -  static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,                                       struct drm_crtc_state *state)  { @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {         .disable        = arc_pgu_crtc_disable,         .prepare        = arc_pgu_crtc_disable,         .commit         = arc_pgu_crtc_enable, -       .atomic_check   = arc_pgu_crtc_atomic_check,         .atomic_begin   = arc_pgu_crtc_atomic_begin,  }; ------------------------------->8------------------------------- > Please also make sure the documentation properly explains this, and if > not, please submit a patch to improve it. You mean explains what? That .mode_fixup is not meant to be used in new code? -Alexey