From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Fri, 3 Mar 2017 17:48:19 +0000 Subject: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> List-ID: Message-ID: <1488563298.2940.33.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Liviu, On Fri, 2017-03-03@16:28 +0000, Liviu Dudau wrote: > On Fri, Mar 03, 2017@06:19:24PM +0300, Alexey Brodkin wrote: > > > > - /* find the encoder node and initialize it */ > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > - if (encoder_node) { > > - ret = arcpgu_drm_hdmi_init(drm, encoder_node); > > - of_node_put(encoder_node); > > + /* There is only one output port inside each device, find it */ > > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL); > > + > > + if (port) { > > + if (of_device_is_available(port)) > > + encoder = of_graph_get_remote_port_parent(port); > > + of_node_put(port); > > + } > > You must've been looking at some old version. Current version in -next uses > of_graph_get_remote_node() to replace all those lines you have added (see Rob > Herring's series to introduce of_graph_get_remote_node() function) Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :) Still I made a check of linux-next and don't see any changes in "drivers/gpu/drm/arm" compared to Linus' tree. [1]?http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 [2]?http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 Could you please clarify which exact tree did you mean? Anyways I just tried to rebase my patch on top of linux-next tree and now video output is broken for me - I only see some garbage on top of the screen so I'll need to investigate it first before moving forward with stuff you proposed :) -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Date: Fri, 3 Mar 2017 17:48:19 +0000 Message-ID: <1488563298.2940.33.camel@synopsys.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com> Content-Language: en-US Content-ID: <1813302EC06FDE46A08990C92D967D08@internal.synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "Liviu.Dudau@arm.com" Cc: "devicetree@vger.kernel.org" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "robh+dt@kernel.org" , "daniel@ffwll.ch" , "linux-snps-arc@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgTGl2aXUsDQoNCk9uIEZyaSwgMjAxNy0wMy0wMyBhdCAxNjoyOCArMDAwMCwgTGl2aXUgRHVk YXUgd3JvdGU6DQo+IE9uIEZyaSwgTWFyIDAzLCAyMDE3IGF0IDA2OjE5OjI0UE0gKzAzMDAsIEFs ZXhleSBCcm9ka2luIHdyb3RlOg0KPiA+IA0KPiA+IC0JLyogZmluZCB0aGUgZW5jb2RlciBub2Rl IGFuZCBpbml0aWFsaXplIGl0ICovDQo+ID4gLQllbmNvZGVyX25vZGUgPSBvZl9wYXJzZV9waGFu ZGxlKGRybS0+ZGV2LT5vZl9ub2RlLCAiZW5jb2Rlci1zbGF2ZSIsIDApOw0KPiA+IC0JaWYgKGVu Y29kZXJfbm9kZSkgew0KPiA+IC0JCXJldCA9IGFyY3BndV9kcm1faGRtaV9pbml0KGRybSwgZW5j b2Rlcl9ub2RlKTsNCj4gPiAtCQlvZl9ub2RlX3B1dChlbmNvZGVyX25vZGUpOw0KPiA+ICsJLyog VGhlcmUgaXMgb25seSBvbmUgb3V0cHV0IHBvcnQgaW5zaWRlIGVhY2ggZGV2aWNlLCBmaW5kIGl0 ICovDQo+ID4gKwlwb3J0ID0gb2ZfZ3JhcGhfZ2V0X25leHRfZW5kcG9pbnQocGRldi0+ZGV2Lm9m X25vZGUsIE5VTEwpOw0KPiA+ICsNCj4gPiArCWlmIChwb3J0KSB7DQo+ID4gKwkJaWYgKG9mX2Rl dmljZV9pc19hdmFpbGFibGUocG9ydCkpDQo+ID4gKwkJCWVuY29kZXIgPSBvZl9ncmFwaF9nZXRf cmVtb3RlX3BvcnRfcGFyZW50KHBvcnQpOw0KPiA+ICsJCW9mX25vZGVfcHV0KHBvcnQpOw0KPiA+ ICsJfQ0KPiANCj4gWW91IG11c3QndmUgYmVlbiBsb29raW5nIGF0IHNvbWUgb2xkIHZlcnNpb24u IEN1cnJlbnQgdmVyc2lvbiBpbiAtbmV4dCB1c2VzDQo+IG9mX2dyYXBoX2dldF9yZW1vdGVfbm9k ZSgpIHRvIHJlcGxhY2UgYWxsIHRob3NlIGxpbmVzIHlvdSBoYXZlIGFkZGVkIChzZWUgUm9iDQo+ IEhlcnJpbmcncyBzZXJpZXMgdG8gaW50cm9kdWNlIG9mX2dyYXBoX2dldF9yZW1vdGVfbm9kZSgp IGZ1bmN0aW9uKQ0KDQpIbSwgSSdtIG5vdCBvbiBMaW51cycgbWFzdGVyIHRyZWUgWzFdIGFuZCBz byBJIHRob3VnaHQgSSB3YXMgcXVpdGUgdXAgdG8gZGF0ZSA6KQ0KU3RpbGwgSSBtYWRlIGEgY2hl Y2sgb2YgbGludXgtbmV4dCBhbmQgZG9uJ3Qgc2VlIGFueSBjaGFuZ2VzIGluDQoiZHJpdmVycy9n cHUvZHJtL2FybSIgY29tcGFyZWQgdG8gTGludXMnIHRyZWUuDQoNClsxXcKgaHR0cDovL2dpdC5r ZXJuZWwub3JnL2NnaXQvbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvY29tbWl0 L2RyaXZlcnMvZ3B1L2RybS9hcm0/aWQ9ZTQ1NjNmNmJhNzE3OTJjNzdhZWNjYjIwOTJjYzIzMTQ5 YjQ0ZTY0Mg0KWzJdwqBodHRwOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0 L25leHQvbGludXgtbmV4dC5naXQvY29tbWl0L2RyaXZlcnMvZ3B1L2RybS9hcm0/aWQ9ZTQ1NjNm NmJhNzE3OTJjNzdhZWNjYjIwOTJjYzIzMTQ5YjQ0ZTY0Mg0KDQpDb3VsZCB5b3UgcGxlYXNlIGNs YXJpZnkgd2hpY2ggZXhhY3QgdHJlZSBkaWQgeW91IG1lYW4/DQoNCkFueXdheXMgSSBqdXN0IHRy aWVkIHRvIHJlYmFzZSBteSBwYXRjaCBvbiB0b3Agb2YgbGludXgtbmV4dCB0cmVlIGFuZCBub3cN CnZpZGVvIG91dHB1dCBpcyBicm9rZW4gZm9yIG1lIC0gSSBvbmx5IHNlZSBzb21lIGdhcmJhZ2Ug b24gdG9wIG9mIHRoZSBzY3JlZW4NCnNvIEknbGwgbmVlZCB0byBpbnZlc3RpZ2F0ZSBpdCBmaXJz dCBiZWZvcmUgbW92aW5nIGZvcndhcmQgd2l0aCBzdHVmZiB5b3UNCnByb3Bvc2VkIDopDQoNCi1B bGV4ZXkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBz LWFyYw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbdCCRus (ORCPT ); Fri, 3 Mar 2017 12:50:48 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:44387 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbdCCRuq (ORCPT ); Fri, 3 Mar 2017 12:50:46 -0500 From: Alexey Brodkin To: "Liviu.Dudau@arm.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "daniel@ffwll.ch" , "airlied@linux.ie" , "robh+dt@kernel.org" , "linux-snps-arc@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Topic: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Index: AQHSlDGTEmuTvpdNt0S/hqvgRgNDbqGDPUSAgAAWQwA= Date: Fri, 3 Mar 2017 17:48:19 +0000 Message-ID: <1488563298.2940.33.camel@synopsys.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> In-Reply-To: <20170303162837.GO917@e110455-lin.cambridge.arm.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.45] Content-Type: text/plain; charset="utf-8" Content-ID: <1813302EC06FDE46A08990C92D967D08@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v23HpKfp013649 Hi Liviu, On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote: > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > - /* find the encoder node and initialize it */ > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > - if (encoder_node) { > > - ret = arcpgu_drm_hdmi_init(drm, encoder_node); > > - of_node_put(encoder_node); > > + /* There is only one output port inside each device, find it */ > > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL); > > + > > + if (port) { > > + if (of_device_is_available(port)) > > + encoder = of_graph_get_remote_port_parent(port); > > + of_node_put(port); > > + } > > You must've been looking at some old version. Current version in -next uses > of_graph_get_remote_node() to replace all those lines you have added (see Rob > Herring's series to introduce of_graph_get_remote_node() function) Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :) Still I made a check of linux-next and don't see any changes in "drivers/gpu/drm/arm" compared to Linus' tree. [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 [2] http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642 Could you please clarify which exact tree did you mean? Anyways I just tried to rebase my patch on top of linux-next tree and now video output is broken for me - I only see some garbage on top of the screen so I'll need to investigate it first before moving forward with stuff you proposed :) -Alexey