diff for duplicates of <1488569045.2973.14.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 5837346..1d41404 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Jose, -On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote: +On Fri, 2017-03-03 at 18:05 +0000, Jose Abreu wrote: > Hi Alexey, > > @@ -15,33 +15,33 @@ On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote: > > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) -> > ??????????????????????????????~ARCPGU_CTRL_ENABLE_MASK); -> > ?} -> > ? +> > ~ARCPGU_CTRL_ENABLE_MASK); +> > } +> > > > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, -> > -????????????????????????????????????struct drm_crtc_state *state) +> > - struct drm_crtc_state *state) > > -{ -> > -???????struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); -> > -???????struct drm_display_mode *mode = &state->adjusted_mode; -> > -???????long rate, clk_rate = mode->clock * 1000; +> > - struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); +> > - struct drm_display_mode *mode = &state->adjusted_mode; +> > - long rate, clk_rate = mode->clock * 1000; > > - -> > -???????rate = clk_round_rate(arcpgu->clk, clk_rate); -> > -???????if (rate != clk_rate) -> > -???????????????return -EINVAL; +> > - rate = clk_round_rate(arcpgu->clk, clk_rate); +> > - if (rate != clk_rate) +> > - return -EINVAL; > > - -> > -???????return 0; +> > - return 0; > > -} > > - -> > ?static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, -> > ??????????????????????????????????????struct drm_crtc_state *state) -> > ?{ +> > static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, +> > struct drm_crtc_state *state) +> > { > > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { -> > ????????.disable????????= arc_pgu_crtc_disable, -> > ????????.prepare????????= arc_pgu_crtc_disable, -> > ????????.commit?????????= arc_pgu_crtc_enable, -> > -???????.atomic_check???= arc_pgu_crtc_atomic_check, -> > ????????.atomic_begin???= arc_pgu_crtc_atomic_begin, -> > ?}; +> > .disable = arc_pgu_crtc_disable, +> > .prepare = arc_pgu_crtc_disable, +> > .commit = arc_pgu_crtc_enable, +> > - .atomic_check = arc_pgu_crtc_atomic_check, +> > .atomic_begin = arc_pgu_crtc_atomic_begin, +> > }; > > ------------------------------->8------------------------------- > > I don't think you can remove the check entirely as this will make @@ -71,3 +71,7 @@ BTW I'm wondering if there're any guidelines on what could be pixel clock deviation from the requested one? -Alexey +_______________________________________________ +linux-snps-arc mailing list +linux-snps-arc@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-snps-arc diff --git a/a/content_digest b/N1/content_digest index f889eb3..6a54f71 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,15 +2,21 @@ "ref\020170302195437.mlhzia2q2oav27mr@phenom.ffwll.local\0" "ref\01488547649.2940.5.camel@synopsys.com\0" "ref\0873786fc-406e-850d-f9fb-a6c9ba8cf95c@synopsys.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check\0" "Date\0Fri, 3 Mar 2017 19:24:06 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0Jose Abreu <Jose.Abreu@synopsys.com>\0" + "Cc\0airlied@linux.ie <airlied@linux.ie>" + daniel.vetter@ffwll.ch <daniel.vetter@ffwll.ch> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org> + daniel@ffwll.ch <daniel@ffwll.ch> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi Jose,\n" "\n" - "On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote:\n" + "On Fri, 2017-03-03 at 18:05 +0000, Jose Abreu wrote:\n" "> Hi Alexey,\n" "> \n" "> \n" @@ -25,33 +31,33 @@ "> > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c\n" "> > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c\n" "> > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc)\n" - "> > ??????????????????????????????~ARCPGU_CTRL_ENABLE_MASK);\n" - "> > ?}\n" - "> > ?\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240~ARCPGU_CTRL_ENABLE_MASK);\n" + "> > \302\240}\n" + "> > \302\240\n" "> > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc,\n" - "> > -????????????????????????????????????struct drm_crtc_state *state)\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *state)\n" "> > -{\n" - "> > -???????struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);\n" - "> > -???????struct drm_display_mode *mode = &state->adjusted_mode;\n" - "> > -???????long rate, clk_rate = mode->clock * 1000;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_display_mode *mode = &state->adjusted_mode;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240long rate, clk_rate = mode->clock * 1000;\n" "> > -\n" - "> > -???????rate = clk_round_rate(arcpgu->clk, clk_rate);\n" - "> > -???????if (rate != clk_rate)\n" - "> > -???????????????return -EINVAL;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240rate = clk_round_rate(arcpgu->clk, clk_rate);\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (rate != clk_rate)\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -EINVAL;\n" "> > -\n" - "> > -???????return 0;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240return 0;\n" "> > -}\n" "> > -\n" - "> > ?static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,\n" - "> > ??????????????????????????????????????struct drm_crtc_state *state)\n" - "> > ?{\n" + "> > \302\240static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *state)\n" + "> > \302\240{\n" "> > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {\n" - "> > ????????.disable????????= arc_pgu_crtc_disable,\n" - "> > ????????.prepare????????= arc_pgu_crtc_disable,\n" - "> > ????????.commit?????????= arc_pgu_crtc_enable,\n" - "> > -???????.atomic_check???= arc_pgu_crtc_atomic_check,\n" - "> > ????????.atomic_begin???= arc_pgu_crtc_atomic_begin,\n" - "> > ?};\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.disable\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_disable,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.prepare\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_disable,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.commit\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_enable,\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240.atomic_check\302\240\302\240\302\240= arc_pgu_crtc_atomic_check,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.atomic_begin\302\240\302\240\302\240= arc_pgu_crtc_atomic_begin,\n" + "> > \302\240};\n" "> > ------------------------------->8-------------------------------\n" "> \n" "> I don't think you can remove the check entirely as this will make\n" @@ -80,6 +86,10 @@ "BTW I'm wondering if there're any guidelines on what could be pixel clock\n" "deviation from the requested one?\n" "\n" - -Alexey + "-Alexey\n" + "_______________________________________________\n" + "linux-snps-arc mailing list\n" + "linux-snps-arc@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-snps-arc -acf735cfb0361403213eed1eaffa9ff5ebea4af7c827262c524d941fc2f9f8d5 +cae61e3d65f13f03ef7ccaec480ab2b50a4200bba4038c1243dbc3e1a626262c
diff --git a/a/1.txt b/N2/1.txt index 5837346..4f13f8a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ Hi Jose, -On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote: +On Fri, 2017-03-03 at 18:05 +0000, Jose Abreu wrote: > Hi Alexey, > > @@ -15,33 +15,33 @@ On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote: > > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) -> > ??????????????????????????????~ARCPGU_CTRL_ENABLE_MASK); -> > ?} -> > ? +> > ~ARCPGU_CTRL_ENABLE_MASK); +> > } +> > > > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc, -> > -????????????????????????????????????struct drm_crtc_state *state) +> > - struct drm_crtc_state *state) > > -{ -> > -???????struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); -> > -???????struct drm_display_mode *mode = &state->adjusted_mode; -> > -???????long rate, clk_rate = mode->clock * 1000; +> > - struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc); +> > - struct drm_display_mode *mode = &state->adjusted_mode; +> > - long rate, clk_rate = mode->clock * 1000; > > - -> > -???????rate = clk_round_rate(arcpgu->clk, clk_rate); -> > -???????if (rate != clk_rate) -> > -???????????????return -EINVAL; +> > - rate = clk_round_rate(arcpgu->clk, clk_rate); +> > - if (rate != clk_rate) +> > - return -EINVAL; > > - -> > -???????return 0; +> > - return 0; > > -} > > - -> > ?static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, -> > ??????????????????????????????????????struct drm_crtc_state *state) -> > ?{ +> > static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, +> > struct drm_crtc_state *state) +> > { > > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { -> > ????????.disable????????= arc_pgu_crtc_disable, -> > ????????.prepare????????= arc_pgu_crtc_disable, -> > ????????.commit?????????= arc_pgu_crtc_enable, -> > -???????.atomic_check???= arc_pgu_crtc_atomic_check, -> > ????????.atomic_begin???= arc_pgu_crtc_atomic_begin, -> > ?}; +> > .disable = arc_pgu_crtc_disable, +> > .prepare = arc_pgu_crtc_disable, +> > .commit = arc_pgu_crtc_enable, +> > - .atomic_check = arc_pgu_crtc_atomic_check, +> > .atomic_begin = arc_pgu_crtc_atomic_begin, +> > }; > > ------------------------------->8------------------------------- > > I don't think you can remove the check entirely as this will make diff --git a/a/content_digest b/N2/content_digest index f889eb3..b11b051 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,15 +2,21 @@ "ref\020170302195437.mlhzia2q2oav27mr@phenom.ffwll.local\0" "ref\01488547649.2940.5.camel@synopsys.com\0" "ref\0873786fc-406e-850d-f9fb-a6c9ba8cf95c@synopsys.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check\0" "Date\0Fri, 3 Mar 2017 19:24:06 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0Jose Abreu <Jose.Abreu@synopsys.com>\0" + "Cc\0dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + daniel@ffwll.ch <daniel@ffwll.ch> + daniel.vetter@ffwll.ch <daniel.vetter@ffwll.ch> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + " airlied@linux.ie <airlied@linux.ie>\0" "\00:1\0" "b\0" "Hi Jose,\n" "\n" - "On Fri, 2017-03-03@18:05 +0000, Jose Abreu wrote:\n" + "On Fri, 2017-03-03 at 18:05 +0000, Jose Abreu wrote:\n" "> Hi Alexey,\n" "> \n" "> \n" @@ -25,33 +31,33 @@ "> > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c\n" "> > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c\n" "> > @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc)\n" - "> > ??????????????????????????????~ARCPGU_CTRL_ENABLE_MASK);\n" - "> > ?}\n" - "> > ?\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240~ARCPGU_CTRL_ENABLE_MASK);\n" + "> > \302\240}\n" + "> > \302\240\n" "> > -static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc,\n" - "> > -????????????????????????????????????struct drm_crtc_state *state)\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *state)\n" "> > -{\n" - "> > -???????struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);\n" - "> > -???????struct drm_display_mode *mode = &state->adjusted_mode;\n" - "> > -???????long rate, clk_rate = mode->clock * 1000;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_display_mode *mode = &state->adjusted_mode;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240long rate, clk_rate = mode->clock * 1000;\n" "> > -\n" - "> > -???????rate = clk_round_rate(arcpgu->clk, clk_rate);\n" - "> > -???????if (rate != clk_rate)\n" - "> > -???????????????return -EINVAL;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240rate = clk_round_rate(arcpgu->clk, clk_rate);\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (rate != clk_rate)\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -EINVAL;\n" "> > -\n" - "> > -???????return 0;\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240return 0;\n" "> > -}\n" "> > -\n" - "> > ?static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,\n" - "> > ??????????????????????????????????????struct drm_crtc_state *state)\n" - "> > ?{\n" + "> > \302\240static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *state)\n" + "> > \302\240{\n" "> > @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {\n" - "> > ????????.disable????????= arc_pgu_crtc_disable,\n" - "> > ????????.prepare????????= arc_pgu_crtc_disable,\n" - "> > ????????.commit?????????= arc_pgu_crtc_enable,\n" - "> > -???????.atomic_check???= arc_pgu_crtc_atomic_check,\n" - "> > ????????.atomic_begin???= arc_pgu_crtc_atomic_begin,\n" - "> > ?};\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.disable\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_disable,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.prepare\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_disable,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.commit\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240= arc_pgu_crtc_enable,\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240.atomic_check\302\240\302\240\302\240= arc_pgu_crtc_atomic_check,\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240.atomic_begin\302\240\302\240\302\240= arc_pgu_crtc_atomic_begin,\n" + "> > \302\240};\n" "> > ------------------------------->8-------------------------------\n" "> \n" "> I don't think you can remove the check entirely as this will make\n" @@ -82,4 +88,4 @@ "\n" -Alexey -acf735cfb0361403213eed1eaffa9ff5ebea4af7c827262c524d941fc2f9f8d5 +ced352574bab35e6f4c51ad579be9a66b3e4e81640a3d5a66dc26cddd4008c4c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.