From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdCDBYN (ORCPT ); Fri, 3 Mar 2017 20:24:13 -0500 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:53536 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751917AbdCDBYL (ORCPT ); Fri, 3 Mar 2017 20:24:11 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:4321:5007:6119:7903:8603:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12740:12760:12895:13069:13095:13161:13229:13311:13357:13439:14659:14721:21080:21433:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: apple89_5c1be30df8402 X-Filterd-Recvd-Size: 1548 Message-ID: <1488590630.2179.41.camel@perches.com> Subject: Re: [PATCH] staging: ks7010: clean up code From: Joe Perches To: Ernestas Kulik , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 03 Mar 2017 17:23:50 -0800 In-Reply-To: <20170303205836.32557-1-ernestas.kulik@gmail.com> References: <20170303205836.32557-1-ernestas.kulik@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > This fixes type warnings generated by sparse, replaces instances of > ntohs() with be16_to_cpu() and removes unused fields in structs. There's no real need to convert ntohs to be16_to_cpu > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c [] > > @@ -297,7 +297,8 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer, > hdr = (struct hostif_hdr *)buffer; > > DPRINTK(4, "size=%d\n", hdr->size); > - if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event) { > + if (le16_to_cpu(hdr->event) < HIF_DATA_REQ || > + HIF_REQ_MAX < le16_to_cpu(hdr->event)) { > This isn't mentioned and doesn't match the commit message