From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbdCDHYh (ORCPT ); Sat, 4 Mar 2017 02:24:37 -0500 Received: from smtprelay0225.hostedemail.com ([216.40.44.225]:57830 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750708AbdCDHYg (ORCPT ); Sat, 4 Mar 2017 02:24:36 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3868:3870:3871:3874:4321:5007:7903:8531:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:30012:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: walk14_27ca985ce3b5f X-Filterd-Recvd-Size: 1471 Message-ID: <1488612271.2179.48.camel@perches.com> Subject: Re: [PATCH] staging: ks7010: clean up code From: Joe Perches To: Ernestas Kulik , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 03 Mar 2017 23:24:31 -0800 In-Reply-To: <20170304064927.GA4470@gmail.com> References: <20170303205836.32557-1-ernestas.kulik@gmail.com> <1488590630.2179.41.camel@perches.com> <20170304062858.GA2120@gmail.com> <1488609447.2179.47.camel@perches.com> <20170304064927.GA4470@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-03-04 at 08:49 +0200, Ernestas Kulik wrote: > On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > > > struct hostif_hdr.event is declared at uint16_t > > and not as __le16 so I believe this is incorrect > > and actually introduces a sparse error. > > Sure, but I change that in the patch. :) More stuff the changelog doesn't show :( On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > This fixes type warnings generated by sparse, replaces instances of > ntohs() with be16_to_cpu() and removes unused fields in structs.