From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org,
"Ondřej Lysoněk" <ondrej.lysonek@seznam.cz>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: Use setup_timer instead of init_timer
Date: Mon, 06 Mar 2017 13:26:52 +0100 [thread overview]
Message-ID: <1488803212.5761.7.camel@sipsolutions.net> (raw)
In-Reply-To: <1488803104.5761.6.camel@sipsolutions.net>
On Mon, 2017-03-06 at 13:25 +0100, Johannes Berg wrote:
> On Fri, 2017-03-03 at 13:45 +0100, Jiri Slaby wrote:
> > From: Ondřej Lysoněk <ondrej.lysonek@seznam.cz>
> >
> > Use setup_timer() and setup_deferrable_timer() to set the data and
> > function timer fields. It makes the code cleaner and will allow for
> > easier change of the timer struct internals.
>
> Btw, I suspect you generated this with coccinelle and didn't put
> enough
> "..." there, because you missed one in mesh_path_new() :)
>
and perhaps mesh_plink_timer_set()?
johannes
next prev parent reply other threads:[~2017-03-06 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 12:45 [PATCH] mac80211: Use setup_timer instead of init_timer Jiri Slaby
2017-03-06 12:23 ` Johannes Berg
2017-03-06 12:25 ` Johannes Berg
2017-03-06 12:25 ` Johannes Berg
2017-03-06 12:26 ` Johannes Berg [this message]
2017-03-06 12:35 ` Jiri Slaby
2017-03-06 12:36 ` Johannes Berg
2017-03-09 9:34 ` ondrej.lysonek
2017-03-09 9:34 ` ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw
2017-03-16 9:54 ` Johannes Berg
2017-03-16 9:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488803212.5761.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ondrej.lysonek@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.