From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbdCGMCc (ORCPT ); Tue, 7 Mar 2017 07:02:32 -0500 Received: from smtprelay0214.hostedemail.com ([216.40.44.214]:43526 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754599AbdCGMCP (ORCPT ); Tue, 7 Mar 2017 07:02:15 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3866:3867:3870:3871:3873:4321:5007:6742:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13311:13357:13439:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: knot96_1167895f08415 X-Filterd-Recvd-Size: 1642 Message-ID: <1488888118.2210.28.camel@perches.com> Subject: Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings From: Joe Perches To: Ingo Molnar , Thomas Gleixner Cc: kbuild test robot , Rik van Riel , kbuild-all@01.org, LKML , tipbuild@zytor.com, "H. Peter Anvin" , x86@kernel.org, Dave Hansen , Yu-cheng Yu , Fenghua Yu , Borislav Petkov , Peter Zijlstra , Linus Torvalds , Andrew Morton Date: Tue, 07 Mar 2017 04:01:58 -0800 In-Reply-To: <20170307090144.GB6946@gmail.com> References: <201703060848.Q2LHSMc4%fengguang.wu@intel.com> <20170306004553.GA25764@lkp-wsm-ep1> <20170307072322.GB29708@gmail.com> <20170307090144.GB6946@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-07 at 10:01 +0100, Ingo Molnar wrote: > To me a lexical 'true/false' instead of '1/0' is a step backwards in readability > in many cases What cases are those to you? I can't think of any case where 1/0 for true/false is "more readable" for boolean returns to me.